lita-slack-standup 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89112ea2047b1056586a00ba012d2512df53e655
-  data.tar.gz: 73e7b3aed31e7f7a3dc1ad27ee2cbe3e574771c7
+  metadata.gz: 38999471fd83dfe57f5adc75dbebb15f93c51fc5
+  data.tar.gz: f527dd1672afc7cb7db53c71bf35270094d9e0f3
 SHA512:
-  metadata.gz: d4b60e34957088fb7216d253e3b96c07dee1a843b3f139c86b88cf060b41685c06e77380cb16cb359538f01c2e774b8446f3b3e87f2714a1bb256b2b6e1f85c8
-  data.tar.gz: 1ae64a78fb0e9c86564f5ef8594aaa3be5a23ec74ada631a9c6aae047527739b45f6afbfb0a19f515834075181d523a20c724d31d13c6e61ee74a311f8bd242b
+  metadata.gz: 7426edba42c616d3c1146c964e8f7a40edb49043178c04768e20779b8f5161650accf1eb5d257e9412c35fb640d8a23d572a4c4e0b84285279131365d9c32a98
+  data.tar.gz: 27effeaa8ba2578fc143105ce37cfdc910e17e7f1670e15cc58c2d45b5d682c47813a539fa1f4c8d7ccf4fb2490a84d2b8562e0f54fe1ad60c51b8bddb332ee6

data/lib/lita/handlers/slack_standup.rb

@@ -43,9 +43,12 @@ module Lita
       end
 
       def reminder
-        standup_members.each do |user, standup|
-          send_message("@#{user}", t("sentence.reminder", user: user)) if standup.empty?
+        if in_standup.value == "true"
+          spam_users_without_report("shame")
+          standup_end
         end
+
+        spam_users_without_report("reminder")
       end
 
       route(/^standup\s+ignore\s*(.*)$/, :standup_ignore, command: true, help: {t("help.ignore_cmd") => t("help.ignore_description")})
@@ -96,6 +99,12 @@ module Lita
 
       private 
 
+      def spam_users_without_report(translate_key)
+        standup_members.each do |user, standup|
+          send_message("@#{user}", t("sentence.#{translate_key}", user: user)) if standup.empty?
+        end
+      end
+
       def extract_user(message)
         message.matches[0][0].gsub('@','')
       end
@@ -176,12 +185,25 @@ module Lita
 
       def prewritten_standups_summary
         standup_members.each do |user, standup|
-          display_standup(user, standup) unless standup.empty?
+          unless standup.empty?
+            report = report_as_attachment(user, standup)
+            slack_client.chat_postMessage(channel: config.channel, text:"", attachments: report, as_user: true)
+          end
         end
       end
 
-      def display_standup(user, standup)
-        send_message(config.channel, t("sentence.standup_done",{user: user, standup: standup}))         
+      def report_as_attachment(user,standup)
+        [{
+          fallback: t("sentence.fallback_standup_done",{user: user, standup: standup}),
+          title: t("sentence.standup_done", user: user),
+          text: standup,
+          color: name_to_color(user) 
+        }]
+      end
+
+      def name_to_color(name)
+        name.each_char.map { |char| ((char.to_i(36)-10) % 16).to_s(16) }.
+          join[0..5].rjust(6,'0')
       end
 
       def save_standup(message)

data/lita-slack-standup.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-slack-standup"
-  spec.version       = "1.0.1"
+  spec.version       = "1.1.0"
   spec.authors       = ["Sybil Deboin"]
   spec.email         = ["sybil.deboin@gmail.com"]
   spec.description   = "Standup feature for slack"
@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "slack-ruby-client"
   spec.add_runtime_dependency "redis-objects"
 
+  spec.add_development_dependency "pry"
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", ">= 3.0.0"

data/locales/en.yml

@@ -22,11 +22,13 @@ en:
           report: "your standup is saved. Thanks :)"
           next: "Good morning <@%{user}> ! It's your turn."
           ignore: "<@%{user}> is now ignored."
+          shame: "Since you didn't report today, I had to end the meeting without your input :("
           reminder: "Good evening <@%{user}> ! You can write your standup for tomorrow !standup report hashtagmylife"
           unignore: "<@%{user}> is now an attendee of the standups"
           list: "Ignored users : "
           next_forbidden: "The command is unavailable outside standups."
-          standup_done: "%{user} has already filled her/his/its standup: \n %{standup}"
+          fallback_standup_done: "%{user}'s report : \n %{standup}"
+          standup_done: "%{user}'s report"
           standup_fill: "Standup done in live."
           already_started: "The standup is already started."
           end_standup: "That's it ! It's all good for today. Thanks everyone :)"

data/locales/fr.yml

@@ -22,11 +22,13 @@ fr:
           report: "Ton standup est enregistré. Merci :)"
           next: "Bonjour <@%{user}> ! C'est à ton tour de parler."
           ignore: "<@%{user}> est désormais ignoré jusqu'à nouvel ordre."
+          shame: "Vu que tu n'as pas participé au standup aujourd'hui, j'ai du terminer le standup sans toi :("
           reminder: "Bonsoir <@%{user}> ! Tu peux donner ton standup pour demain. !standup report 3615mavie"
           unignore: "<@%{user}> est à nouveau inclus dans les standups."
           list: "Utilisateurs ignorés : "
           next_forbidden: "La commande n'est pas disponible en dehors d'un standup."
-          standup_done: "%{user} a déjà renseigné son standup : \n %{standup}"
+          fallback_standup_done: "%{user} a déjà renseigné son standup : \n %{standup}"
+          standup_done: "Rapport de %{user}"  
           standup_fill: "Standup fait en live."
           already_started: "Le standup est déjà en cours."
           end_standup: "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :)"

data/spec/lita/handlers/slack_standup_spec.rb

@@ -9,7 +9,7 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     {'Accept'=>'application/json; charset=utf-8', 
     'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 
     'Content-Type'=>'application/x-www-form-urlencoded', 
-    'User-Agent'=>'Slack Ruby Client/0.6.0'} 
+    'User-Agent'=>'Slack Ruby Client/0.7.0'} 
   }
 
   let(:registry) do
@@ -105,11 +105,18 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
       end
 
       it "displays known reports" do
-        [ "Hello <!channel> ! Le standup va commencer :)",
-          "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
-          "Bonjour <@zaratan> ! C'est à ton tour de parler."
-        ].each do |text|
-          expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})
+        [ {channel: channel, text: "Hello <!channel> ! Le standup va commencer :)", as_user: true},
+          {channel: channel, text: "", as_user: true, attachments:
+            [{
+              fallback: "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
+              title: "Rapport de sybil",
+              text: "My standup report for testing purposes",
+              color: "02818b"
+            }]
+          },
+          {channel: channel, text: "Bonjour <@zaratan> ! C'est à ton tour de parler.", as_user: true}
+        ].each do |message_content|
+          expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with(message_content)
         end
         subject
       end
@@ -121,15 +128,29 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
         end
 
         it "displays the standups and ends the meeting" do
-          [ "Hello <!channel> ! Le standup va commencer :)",
-            "zaratan a déjà renseigné son standup : \n My standup report for testing purposes",
-            "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
-            "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :)"
-          ].each do |text|
-            expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})       
+          [ {channel: channel, text: "Hello <!channel> ! Le standup va commencer :)", as_user: true},
+            {channel: channel, text: "", as_user: true, attachments:
+              [{
+                fallback: "zaratan a déjà renseigné son standup : \n My standup report for testing purposes",
+                title: "Rapport de zaratan",
+                text: "My standup report for testing purposes",
+                color: "901030"
+              }]
+            },         
+            {channel: channel, text: "", as_user: true, attachments:
+              [{
+                fallback: "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
+                title: "Rapport de sybil",
+                text: "My standup report for testing purposes",
+                color: "02818b"
+              }]
+            },
+            {channel: channel, text: "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :)", as_user: true}
+          ].each do |message_content|
+            expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with(message_content)
+          end
+            subject
           end
-          subject
-        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-slack-standup
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Sybil Deboin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-03 00:00:00.000000000 Z
+date: 2016-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement