lita-slack-handler 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5069dda33ad4e37ed62c5bb41f3b229a0e08d721
-  data.tar.gz: c2c56ed04d8fd09c0f6c1f7b2e92bcc1a2d91a0f
+  metadata.gz: 1955f5daca8b60f5b4d0ab9a5cf83850bed932b9
+  data.tar.gz: 4609c8a523f8cb8928993f9fd9c0c27d0cac3ec5
 SHA512:
-  metadata.gz: ceb51b4b012fe77cdb9e3d0f0f290305c9b505a4d3884c580ee37d83478a7de7911504a096fb4e49cc80a638fe377198b0eb66a3a9f9f964de0a55fce9374b9d
-  data.tar.gz: 39e649c5e54076d8bb8983c87eb59f5ef16705f1c5434c8bcd6d37891dd314ce65a585de4c8f0d7360cf304b869fc38ef7b52c4cea390c59365b1b0cd913b4b4
+  metadata.gz: 0db57c56ff22ad26274bf0a99150dafdc1f267057af7890b360d09f9acf1ca3d251602a569fb0aaea45a9990517e0a605c2e2dc51cdc3ebd979d0051f0a12b3f
+  data.tar.gz: b3fa2d566200305eb1356a3b4888fbf3ac66dca4f887bf7562c766e1d65fa554aad0c3f8a41cad273a712b127bc5a272fff178bb71fd619b96fcef0f1f5bdb75

data/.gitignore

@@ -0,0 +1,18 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+lita_config.rb

data/README.md

@@ -1,7 +1,7 @@
 # lita-slack-handler
 
-**lita-hipchat-handler** is a handler for [Lita](https://github.com/jimmycuadra/lita) that allows you to use the robot with [Slack](https://slack.com/). This handler complements [lita-slack](https://github.com/kenjij/lita-slack) adapter gem.
-**lita-hipchat-handler** sets up an HTTP route to accept messages from Slack:Outgoing WebHooks integrations, then feeds it into Lita.
+**lita-slack-handler** is a handler for [Lita](https://github.com/jimmycuadra/lita) that allows you to use the robot with [Slack](https://slack.com/). This handler complements [lita-slack](https://github.com/kenjij/lita-slack) adapter gem.
+**lita-slack-handler** sets up an HTTP route to accept messages from Slack:Outgoing WebHooks integrations, then feeds it into Lita.
 This handler, otherwise, does nothing by itself; i.e., it does not produce any replies.
 
 ## Installation

data/lib/lita/handlers/slack_handler.rb

@@ -11,8 +11,9 @@ module Lita
 				# Slack:Outgoing WebHook integration token
 				default.webhook_token = nil
 				default.team_domain = nil
+				default.ignore_user_name = nil
 			end
-			
+
 			def receive(req, res)
 				# For security, do not run with missing config
 				if not config_valid?
@@ -25,6 +26,12 @@ module Lita
 					res.status = 403
 					return
 				end
+				# Ignore some requests
+				if ignore?(req)
+					log.debug "SlackHandler::receive ignoring request"
+					res.status = 200
+					return
+				end
 				res.status = 200
 				log.debug "SlackHandler::receive webhook_token:#{req['token']} team_domain:#{req['team_domain']}"
 				log.debug "SlackHandler::receive user id:#{req['user_id']} name:#{req['user_name']}"
@@ -67,18 +74,27 @@ module Lita
 				return valid
 			end
 
+			def ignore?(req)
+				ignore = false
+				if !config.ignore_user_name.nil? && req['user_name'].eql?(config.ignore_user_name)
+					log.warn "SlackHandler: #{req['user_name']} matches ignore_user_name #{config.ignore_user_name}"
+					ignore = true
+				end
+				return ignore
+			end
+
 			#
 			# Accessor shortcuts
 			#
 			def log
 				Lita.logger
 			end
-			
+
 			def config
 				Lita.config.handlers.slack_handler
 			end
 		end
-	
+
 		Lita.register_handler(SlackHandler)
 	end
 end

data/lita-slack-handler.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-slack-handler"
-  spec.version       = "0.2.0"
+  spec.version       = "0.2.1"
   spec.authors       = ["Ken J."]
   spec.email         = ["kenjij@gmail.com"]
   spec.description   = %q{Lita handler for Slack}
@@ -14,9 +14,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", "~> 2.7"
+  spec.add_runtime_dependency "lita", "~> 3.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", ">= 2.14"
+  spec.add_development_dependency "rspec", ">= 3.0.0.beta1"
 end

data/spec/lita/handlers/slack_handler_spec.rb

@@ -3,29 +3,28 @@ require "spec_helper"
 describe Lita::Handlers::SlackHandler, lita_handler: true do
 	http_route_path = '/lita/slack-handler'
 	req = {}
-	
+
 	it "registers with Lita" do
 		expect(Lita.handlers).to include(described_class)
 	end
 
 	it "registers HTTP route POST #{http_route_path} to :receive" do
-		expect(described_class.http_routes[0].http_method).to eql('POST')
-		expect(described_class.http_routes[0].path).to eql(http_route_path)
-		expect(described_class.http_routes[0].method_name).to eql(:receive)
+		routes_http(:post, http_route_path).to(:receive)
 	end
 
 	context "with valid config" do
 		before :each do
 		  Lita.config.handlers.slack_handler.webhook_token = "aN1NvAlIdDuMmYt0k3n"
 		  Lita.config.handlers.slack_handler.team_domain = "example"
+		  Lita.config.handlers.slack_handler.ignore_user_name = "lita"
 		end
-		
+
 		describe "#config_valid?" do
 			it 'returns true' do
 				expect(subject.config_valid?).to eql(true)
 			end
 		end
-		
+
 		describe "#request_valid?" do
 			it 'returns true with valid request' do
 				req['token'] = Lita.config.handlers.slack_handler.webhook_token
@@ -47,6 +46,15 @@ describe Lita::Handlers::SlackHandler, lita_handler: true do
 				expect(subject.request_valid?(req)).to eql(false)
 			end
 		end
+
+		describe "#ignore?" do
+			it 'returns true when ignore_user_name matches user_name' do
+				req['token'] = Lita.config.handlers.slack_handler.webhook_token
+				req['team_domain'] = Lita.config.handlers.slack_handler.team_domain
+				req['user_name'] = 'lita'
+				expect(subject.ignore?(req)).to eql(true)
+			end
+		end
 	end
 
 	context "without valid config" do
@@ -54,7 +62,7 @@ describe Lita::Handlers::SlackHandler, lita_handler: true do
 		  Lita.config.handlers.slack_handler.webhook_token = nil
 		  Lita.config.handlers.slack_handler.team_domain = nil
 		end
-		
+
 		describe "#config_valid?" do
 			it 'returns false' do
 				expect(subject.config_valid?).to eql(false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-slack-handler
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ken J.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-29 00:00:00.000000000 Z
+date: 2014-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0.beta1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0.beta1
 description: Lita handler for Slack
 email:
 - kenjij@gmail.com
@@ -73,6 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .gitignore
 - Gemfile
 - LICENSE
 - README.md
@@ -103,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.7
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Lita handler for Slack; complement lita-slack adapter gem.