lita-quote 0.0.2 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54c00850248244df1aea3553cde8489441d1b09c
-  data.tar.gz: 1b3245e1737533291f5ce0c24c5819c7b6a6e5d0
+  metadata.gz: c424f385330f646630dc26dd84265a23be2de82e
+  data.tar.gz: 6dfe8133b5f307084720a34b733e12e2c8acf748
 SHA512:
-  metadata.gz: fd2fe43d19aa5a94fe2719df4e506f656e42aa1a6389b57012bbb8cdff65634f368bd0be8ae8a213eb6425a3a38c109ccde0e03b756e0362dd0ace47e2c12c5e
-  data.tar.gz: e18b972b1405ac78e68e6ed995552d6e473ba8e0f5279f8ab2098f9d1c733bb5909bc44f3e81ec33f9e686305b0f1af7cfddcda69149fbdb28c2efa27ca2f811
+  metadata.gz: 9094e78abbe8175f4ec200cee08f3721580dfe4d78ae26aa5b3fe6229ee4e24c3793ca384782366ee39f20fbd08ba7bad1935cd79bd7ab27f723429dd25453e5
+  data.tar.gz: 6d00d48dc76b8f7eceff30af015f5b60c5859e7cb3399d459e3dbe886c04af8c45cde25d7f734ba1a0d63a5f0404a2b74c7f51819cadee93edab3b5b32232b34

data/README.md

@@ -1,5 +1,8 @@
 # lita-quote
 
+[![Build Status](https://travis-ci.org/josqu4red/lita-quote.png?branch=master)](https://travis-ci.org/josqu4red/lita-quote)
+[![Coverage Status](https://coveralls.io/repos/josqu4red/lita-quote/badge.png)](https://coveralls.io/r/josqu4red/lita-quote)
+
 **lita-quote** is a handler for [Lita](https://github.com/jimmycuadra/lita) to store and retrieve user quotes.
 
 ## Installation
@@ -28,25 +31,25 @@ end
 
 Store a quote:
 ```
-Lita: qadd content of the quote
+Lita: qadd content of the quote # or addquote
 Added quote #42
 ```
 
 Get a random quote:
 ```
-Lita: qget
+Lita: qget # or getquote
 #36: a random quote [2014-03-21]
 ```
 
 Get a given quote:
 ```
-Lita: qget 42
+Lita: qget 42 # or getquote
 #42: content of the quote [2014-03-22]
 ```
 
 Delete a quote:
 ```
-Lita: qdel 42
+Lita: qdel 42 # or delquote
 Deleted quote #42
 ```
 

data/lib/lita/handlers/quote.rb

@@ -2,27 +2,28 @@ module Lita
   module Handlers
     class Quote < Handler
 
-      def self.default_config(config)
-        config.date_format = nil
-      end
+      config :date_format
 
       route /^qadd\s+(.*)$/, :add_quote, command: true,
         help: { "qadd <text>" => "Store quote following the command" }
 
-      route /^qget(\s*(\d+))?$/, :get_quote, command: true,
-        help: { "qget [id]" => "Retrieve a quote by #id or randomly" }
-
-      route /^qdel\s+(\d+)$/, :del_quote, command: true, restrict_to: ["admins"],
-        help: { "qdel <id>" => "Delete quote with given #id (admins only)" }
+      route /^addquote\s+(.*)$/, :add_quote, command: true,
+        help: { "addquote <text>" => "Store quote following the command" }
 
       def add_quote(response)
         quote_id = redis.incr("last_id")
         message = "##{quote_id}: #{response.matches.flatten.first}"
-        message += " #{Time.now.strftime(Lita.config.handlers.quote.date_format)}" if Lita.config.handlers.quote.date_format
+        message += " #{Time.now.strftime(config.date_format)}" if Lita.config.handlers.quote.date_format
         redis.hset("list", quote_id, message)
         response.reply("Added quote ##{quote_id}")
       end
 
+      route /^qget(\s*(\d+))?$/, :get_quote, command: true,
+        help: { "qget [id]" => "Retrieve a quote by #id or randomly" }
+
+      route /^getquote(\s*(\d+))?$/, :get_quote, command: true,
+        help: { "getquote [id]" => "Retrieve a quote by #id or randomly" }
+
       def get_quote(response)
         if quote_id = response.matches.flatten.last
           quote = redis.hget("list", quote_id.to_i)
@@ -38,6 +39,12 @@ module Lita
         end
       end
 
+      route /^qdel\s+(\d+)$/, :del_quote, command: true, restrict_to: ["quote_admins"],
+        help: { "qdel <id>" => "Delete quote with given #id (quote_admins only)" }
+
+      route /^delquote\s+(\d+)$/, :del_quote, command: true, restrict_to: ["quote_admins"],
+        help: { "delquote <id>" => "Delete quote with given #id (quote_admins only)" }
+
       def del_quote(response)
         quote_id = response.matches.flatten.last.to_i
         if redis.hdel("list", quote_id) == 1

data/lita-quote.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-quote"
-  spec.version       = "0.0.2"
+  spec.version       = "0.1.1"
   spec.authors       = ["Jonathan Amiez"]
   spec.email         = ["jonathan.amiez@gmail.com"]
   spec.description   = "Quote handler for Lita"
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", ">= 3.0"
+  spec.add_runtime_dependency "lita", "~> 4.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/spec/lita/handlers/quote_spec.rb

@@ -8,20 +8,34 @@ describe Lita::Handlers::Quote, lita_handler: true do
     end
   end
 
-  it { routes_command("qadd dat funny guy").to(:add_quote) }
-  it { doesnt_route("qadd").to(:add_quote) }
-  it { doesnt_route("yo qadd dat funny guy").to(:add_quote) }
-
-  it { routes_command("qget").to(:get_quote) }
-  it { routes_command("qget 22").to(:get_quote) }
-  it { doesnt_route("yo qget").to(:get_quote) }
-  it { doesnt_route("qget dat").to(:get_quote) }
-
-  it { routes_command("qdel 22").to(:del_quote) }
-  it { doesnt_route("qdel").to(:del_quote) }
-  it { doesnt_route("yo qdel dat").to(:del_quote) }
+  it { is_expected.to route_command("qadd dat funny guy").to(:add_quote) }
+  it { is_expected.to route_command("addquote dat funny guy").to(:add_quote) }
+  it { is_expected.not_to route_command("qadd").to(:add_quote) }
+  it { is_expected.not_to route_command("addquote").to(:add_quote) }
+  it { is_expected.not_to route_command("yo qadd dat funny guy").to(:add_quote) }
+  it { is_expected.not_to route_command("yo addquote dat funny guy").to(:add_quote) }
+
+  it { is_expected.to route_command("qget").to(:get_quote) }
+  it { is_expected.to route_command("getquote").to(:get_quote) }
+  it { is_expected.to route_command("qget 22").to(:get_quote) }
+  it { is_expected.to route_command("getquote 22").to(:get_quote) }
+  it { is_expected.not_to route_command("yo qget").to(:get_quote) }
+  it { is_expected.not_to route_command("yo getquote").to(:get_quote) }
+  it { is_expected.not_to route_command("qget dat").to(:get_quote) }
+  it { is_expected.not_to route_command("getquote dat").to(:get_quote) }
+
+  it { is_expected.to route_command("qdel 22").with_authorization_for(:quote_admins).to(:del_quote) }
+  it { is_expected.to route_command("delquote 22").with_authorization_for(:quote_admins).to(:del_quote) }
+  it { is_expected.not_to route_command("qdel").to(:del_quote) }
+  it { is_expected.not_to route_command("delquote").to(:del_quote) }
+  it { is_expected.not_to route_command("yo qdel dat").to(:del_quote) }
+  it { is_expected.not_to route_command("yo delquote dat").to(:del_quote) }
 
   describe "#add_quote" do
+    it "adds a quote to database" do
+      send_command("qadd <+renchap> t'as un user et pas d'accès ? <+josqu4red> nan mais allow")
+      expect(replies.last).to match(/Added quote #\d+/)
+    end
   end
 
   describe "#get_quote" do

data/spec/spec_helper.rb

@@ -8,3 +8,4 @@ SimpleCov.start { add_filter "/spec/" }
 
 require "lita-quote"
 require "lita/rspec"
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: lita-quote
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.1
 platform: ruby
 authors:
 - Jonathan Amiez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-22 00:00:00.000000000 Z
+date: 2014-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement