lita-puppet 2.1.4 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d80423ebb3746f0fda22ff43b2f93086bbc295ca
-  data.tar.gz: c8f55e2beeffe1cfe1e29d99d6c31d006894fa49
+  metadata.gz: 8becf5247bbd3296019d1ee1940b856fbffc0ab8
+  data.tar.gz: 2f53802c6f4505aa8a48071bdc2756c967630a56
 SHA512:
-  metadata.gz: 15fce99d528e4dfc3665481ddf0786debc70c52421a0b24bb00562bc58f446d32b12afb980543ca5277ee4df22c71770dd98700409db839ab696edb86f0cc42b
-  data.tar.gz: da28f2632ec6ebb15f61d8dba2981068193c24a67d707507e6aa6dba9a4226b0a9fa957ab5afe8ece0c2d638fb9cfbca07e0979bec95b7c6ac9a52df5ee82a85
+  metadata.gz: 2cadbf6b61bd758d6c92769eb9d6f0e4ca592649dd247b96cdcf54913471978d6303e62e1c6684698c20cacf1558b865c104859e49f6e0a2bd686a27261501d1
+  data.tar.gz: ee73cac7096ee78f7c3f8ec00baa925a1e93097e6db7aba678149d67206dcf1beecdb9fb38e1b37eb32e9cfb0abdeaea87b4544b84d19681cdf7d82b5f0388b5

data/.rubocop.yml

@@ -10,13 +10,13 @@ Metrics/LineLength:
   Max: 100
 
 Metrics/AbcSize:
-  Max: 22
+  Max: 23
 
 Metrics/MethodLength:
   Max: 25
 
 Metrics/ClassLength:
-  Max: 165
+  Max: 175
 
 Metrics/BlockLength:
   Max: 30

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 rvm:
 - 2.2.5
-- 2.3.1
+- 2.3.4
 - 2.4.1
 services:
 - redis-server

data/lib/lita-puppet.rb

@@ -1,6 +1,7 @@
 require 'lita'
 require 'rye'
 require 'timeout'
+require 'resolv'
 require 'puppetdb'
 
 Lita.load_locales Dir[File.expand_path(

data/lib/lita/handlers/puppet.rb

@@ -87,8 +87,18 @@ module Lita
       def puppet_agent_run(response)
         host = response.matches[0][4]
 
-        response.reply_with_mention(t('replies.puppet_agent_run.working'))
+        resolvable = begin
+          Resolv.getaddress(host)
+        rescue Resolv::ResolvError
+          false
+        end
 
+        unless resolvable
+          response.reply_with_mention(t('replies.puppet_agent_run.dns_failure', machine: host))
+          return false
+        end
+
+        response.reply_with_mention(t('replies.puppet_agent_run.working'))
         result = simple_ssh_command(host, config.ssh_user, agent_command)
 
         # build a reply

data/lita-puppet.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-puppet'
-  spec.version       = '2.1.4'
+  spec.version       = '2.1.5'
   spec.authors       = ['Daniel Schaaff', 'Jonathan Gnagy'].sort
   spec.email         = ['jgnagy@knuedge.com']
   spec.description   = 'Some basic Puppet interactions for Lita'

data/locales/en.yml

@@ -32,6 +32,7 @@ en:
           puppet_agent_run:
             working: "I'll run puppet right away. Give me a sec and I'll let you know how it goes."
             failure: "your puppet run is done, but didn't seem to work... I think it may have timed out."
+            dns_failure: "I couldn't find a machine called '%{machine}'."
             success: "that puppet run is complete! It exited with status %{status}."
           node_profiles:
             notconf: "I would do that, but I don't know how to connect to PuppetDB. Edit my config and add `config.handlers.puppet.puppetdb_url`."

data/spec/lita/handlers/puppet_spec.rb

@@ -112,15 +112,22 @@ describe Lita::Handlers::Puppet, lita_handler: true do
     before do
       robot.auth.add_user_to_group!(lita_user, :puppet_admins)
     end
-    it 'should run a puppet agent' do
+
+    it 'notifies users when server names are not resolvable' do
       allow(Rye::Box).to receive(:new).and_return(rye_box)
       send_command('puppet agent run on server.name', as: lita_user)
+      expect(replies[-1]).to eq('I couldn\'t find a machine called \'server.name\'.')
+    end
+
+    it 'should run a puppet agent' do
+      allow(Rye::Box).to receive(:new).and_return(rye_box)
+      send_command('puppet agent run on localhost', as: lita_user)
       expect(replies[-2]).to eq('that puppet run is complete! It exited with status 0.')
     end
 
     it 'should truncate long results' do
       allow(Rye::Box).to receive(:new).and_return(rye_box)
-      send_command('puppet agent run on server.name', as: lita_user)
+      send_command('puppet agent run on localhost', as: lita_user)
       expect(replies[-1].lines.last).to eq('... truncated to 50 lines')
       expect(replies[-1].lines.size).to eq(51)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-puppet
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.1.5
 platform: ruby
 authors:
 - Daniel Schaaff
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-13 00:00:00.000000000 Z
+date: 2017-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita