lita-puppet 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1b3f7b216de57ce1507c62606049abe09c4a6d7
-  data.tar.gz: bf814b1efdb2b666499d4df0149fe28bbbeff81d
+  metadata.gz: 4093f7f1cf750679f71793b9422435344dfcba71
+  data.tar.gz: 366fb224da2ec58f872484386401c6798645fcde
 SHA512:
-  metadata.gz: 0b01deb2674c47f115759323cae6093828d2aa9d5c727068c3f97edd1e83b69957d4c029682cf07ddaf6a3dc2b6ca8399d9c592a9ca1b64cb2cadc631ff28ed3
-  data.tar.gz: 40617d283ae66ef75a502f68ebcced9c35e126b5227e3057b96f62f92f972b2d557569463729199a5b7fe8d5f4f2b6f37a50dcc407e2d6581c9da6768396ace8
+  metadata.gz: 32cf95a9ed7f69609621ec08c4eb1772047b7f67cf1be37b6ea4b1633ba2b4c3e670fb3b9f3372e2c1384f3dc04b44312164a8670a170aeaca28a602c844e9b2
+  data.tar.gz: 707d26704e241e5638c98e6774e114820ec7551f049c1b273dd0192ac5be24dccda4c8f054f85d3ad264091da9b1b38468db65aafefc5ccf1b0b882e0f49397f

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 rvm:
 - 2.2.5
 - 2.3.1
+- 2.4.1
 services:
 - redis-server
 cache: bundler

data/lib/lita/handlers/puppet.rb

@@ -113,6 +113,8 @@ module Lita
 
         if profiles.is_a? String
           fail_message response, t('replies.node_profiles.failure', error: profiles)
+        elsif profiles == []
+          fail_message response, t('replies.node_profiles.failure_no_roles', host: host)
         else
           success_message(
             response,

data/lita-puppet.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-puppet'
-  spec.version       = '2.1.0'
+  spec.version       = '2.1.1'
   spec.authors       = ['Daniel Schaaff', 'Jonathan Gnagy'].sort
   spec.email         = ['jgnagy@knuedge.com']
   spec.description   = 'Some basic Puppet interactions for Lita'

data/locales/en.yml

@@ -37,6 +37,7 @@ en:
             notconf: "I would do that, but I don't know how to connect to PuppetDB. Edit my config and add `config.handlers.puppet.puppetdb_url`."
             working: "let me see what I can find in PuppetDB for you."
             failure: "Hmmm, that didn't work. Here's what PuppetDB responded with: '%{error}'"
+            failure_no_roles: "The catalog did not contain any roles or profiles for '%{host}'"
             success: "Here are the %{things} for %{host}:"
           nodes_with_class:
             notconf: "I would do that, but I don't know how to connect to PuppetDB. Edit my config and add `config.handlers.puppet.puppetdb_url`."

data/spec/lita/handlers/puppet_spec.rb

@@ -128,6 +128,18 @@ describe Lita::Handlers::Puppet, lita_handler: true do
       send_command('puppet roles and profiles foo', as: lita_user)
       expect(replies.last).to eq("/code profile::foo\nrole::baz")
     end
+    it 'should return error for no profile or role tags' do
+      allow(::PuppetDB::Client).to receive(:get).and_return(
+        'resources' => {
+          'data' => [
+            { 'tags' => ['baz::foo'] },
+            { 'tags' => ['bar::baz'] }
+          ]
+        }
+      )
+      send_command('puppet roles and profiles foo', as: lita_user)
+      expect(replies.last).to eq("The catalog did not contain any roles or profiles for 'foo'")
+    end
   end
 
   describe('#nodes_with_class') do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-puppet
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Daniel Schaaff
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-10 00:00:00.000000000 Z
+date: 2017-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -225,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Allow the Lita bot to handle requests for puppet tasks