lita-pullrequests 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7fb70d9a92880f7968a8abd3630f910c92b5d9b
-  data.tar.gz: 6aeb680bddfb78388f945b2f0a9a4225a5bf0386
+  metadata.gz: bf38c15c07dc898b239cec2885710ce57f6058db
+  data.tar.gz: e5eac46144f31a25048aebe81c41a3b34ee37a70
 SHA512:
-  metadata.gz: b9ba3e4c7f7832e3e8fabe3cb80d0ff157404d1de47dea185f1441db80762bee4e3d59592f6f27f9d5665c7e01affbe927062ff38c8e7f6e982da91991a2b13d
-  data.tar.gz: 92b0e722c461b6b6ff6930b29ef24a31c6e54d0662b0074241ec0fc6c04851258d9390a190f0922c6cc7b7a1b21f30a2c16ef865ba74f525f123ccaf4552b2ff
+  metadata.gz: b9a3d12b32a0b4264389a4e03ff4b5ff81cc444d12972b8ba8a7030553b3173b0252b5d5a0784b508932fc79edcf162a38b89b431bf6c89e0ae95245a44c8a6c
+  data.tar.gz: fe795650db0ba8249c355180bf7abf08108eeccafc6542d01c09ec33c1300919f13ebef483ab0c9c771a5eb386b6484ca8c098068f11b4eff3f1298d139679e2

data/README.md

@@ -1,8 +1,9 @@
 # lita-pullrequests
 
-A Lita handler to help you keep track of your pull requests. It can automatically post in your channels and tell you about which pull requests need attention in all of your repositories.
+A Lita handler to help you **keep track of your pull requests**. It can automatically post in your channels on a schedule and tell you about pull requests that need attention in all of your repositories.
 
-This means that you can mark some pull requests as needing attention, and your Lita bot will automatically know about them and remind you to address them whenever you tell it to.
+1. Organize pull requests with labels on GitHub
+2. Lita will remind you about them later
 
 ## Installation
 
@@ -14,13 +15,24 @@ gem "lita-pullrequests"
 
 ## Configuration
 
+Pull request summaries include three sections:
+
+1. Pull Requests that need a code review
+2. Pull Requests that are ready to be merged
+3. Pull Requests that need quality assurance
+
+These are sorted based on GitHub labels attached to pull requests. You can configure your labels in your `lita_config`.
+
+You will also need a personal access token for an account that has access to all of the repositories that are to be scraped. You can get one of these [here](https://github.com/settings/applications). You'll need to store the access token as an environment variable on Heroku or your server.
+
 Add the following configuration lines to your `lita_config`:
 
 ``` ruby
-config.handlers.pullrequests.access_token = "a-github-api-access-token"
+config.handlers.pullrequests.access_token = ENV["GITHUB_ACCESS_TOKEN"]
 config.handlers.pullrequests.repos = ["username/reponame"]
-config.handlers.pullrequests.review_label = "title of a label that represents a pr ready for review"
-config.handlers.pullrequests.merge_label  = "title of a label that represents a pr ready for merge"
+config.handlers.pullrequests.review_label = "needs-review"
+config.handlers.pullrequests.merge_label  = "ready-for-merge"
+config.handlers.pullrequests.qa_label     = "qa-needed"
 ```
 
 ## Usage

data/lib/lita/handlers/pullrequests.rb

@@ -7,6 +7,7 @@ module Lita
       config :repos,        type: Array,  required: true
       config :review_label, type: String, required: false
       config :merge_label,  type: String, required: false
+      config :qa_label,     type: String, required: false
 
       on :loaded, :remember_reminder
 
@@ -71,7 +72,7 @@ module Lita
             chat.reply "No pull requests need a review right now!"
           end
         else
-          chat.reply("I'm not configured for a repo with that name.")
+          chat.reply "I'm not configured for a repo with that name."
         end
       end
 
@@ -93,21 +94,28 @@ module Lita
         end
       end
 
-      def formatted_pull_request_summary
-        response = ":heavy_exclamation_mark: *Pull Requests that need review*:\n"
-
-        response += pulls_that_need_reviews.map do |pr|
-          title, user = pr["title"], pr["user"]["login"]
-          url = pr["pull_request"]["html_url"]
-          "- _#{title}_ - #{user} \n    #{url}"
-        end.join("\n\n")
+      def pulls_that_need_qa
+        pulls = fetch_pull_requests
+        merge_label = config.qa_label || "QA Needed"
 
-        response += "\n\n\n:white_check_mark: *Pull Requests that are ready for merging*:\n"
+        pulls.select do |pr|
+          pr["labels"] && pr["labels"].any? { |label| label["name"] == config.qa_label }
+        end
+      end
 
-        response += pulls_that_need_merging.map do |pr|
-          title, user = pr["title"], pr["user"]["login"]
-          url = pr["pull_request"]["html_url"]
-          "- _#{title}_ - #{user} \n    #{url}"
+      def formatted_pull_request_summary
+        {
+          ":heavy_exclamation_mark: *Pull Requests that need review*:\n"     => pulls_that_need_reviews,
+          ":thought_balloon: *Pull Requests that need QA*:\n"                => pulls_that_need_qa,
+          ":white_check_mark: *Pull Requests that are ready for merging*:\n" => pulls_that_need_merging
+        }.map do |heading, pulls|
+          heading + if pulls.any?
+            pulls.map do |pr|
+              "- _#{pr['title']}_ - #{pr['user']['login']} \n    #{pr['pull_request']['html_url']}"
+            end.join("\n\n")
+          else
+            "_None!_\n"
+          end
         end.join("\n\n")
       end
 

data/lita-pullrequests.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-pullrequests"
-  spec.version       = "0.0.8"
+  spec.version       = "0.0.9"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = %q{A Lita handler to help you keep track of your pull requests.}

data/spec/lita/handlers/pullrequests_spec.rb

@@ -6,6 +6,7 @@ describe Lita::Handlers::Pullrequests, lita_handler: true do
     Lita.config.handlers.pullrequests.repos        = ["taylorlapeyre/lita-pullrequests"]
     Lita.config.handlers.pullrequests.review_label = "Needs Review"
     Lita.config.handlers.pullrequests.merge_label  = "Ready To Merge"
+    Lita.config.handlers.pullrequests.qa_label     = "QA Needed"
   end
 
   it { is_expected.to route_command("give me something to review for lita-pullrequests").to(:get_random_pr) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-pullrequests
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-04 00:00:00.000000000 Z
+date: 2015-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita