lita-pullrequests 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67a9de81353aaec844771cb2829ec714ba015481
-  data.tar.gz: 5814f6cc0ba4a548413daae6b5b4821de48fd1ed
+  metadata.gz: 7dd56dc1fe66435afb8b441ba37c57c22350d4bf
+  data.tar.gz: aecf5c8c58d4c5b6506b143cda912d3d28aa1e81
 SHA512:
-  metadata.gz: 856690826d022b56ec598672446823095c833c2c9b0de161b8b1c4cf92e07bd84b9764a69fba8c4b8b90e71473927edb61b00ec1f32d306a7d6947530e81cd27
-  data.tar.gz: 86e57efa9b4303bc6f6e3e200b715ce739bdad36d3d96ad58c114ba555e3d19023199b8be07432dd533ae093acf3e3babbfc631aec0ff82df42a9ca22d02ae7f
+  metadata.gz: d243ebc0217e6c7fd70dfcdd6e9bb1d7861027920ae287f14975b8823685f6fb9f46a9a6babbd8af549be54518952381c5ef95e983450a958b8338f0f3d219c6
+  data.tar.gz: bfae20e85f0ff5def1dcec42fa8a57cd5f95139b656e07d578aafebb3c76f7ff0af8ba53c5603b47cd16912b480357b888bed5ed1383a2d2b2e797220a65f34a

data/README.md

@@ -1,6 +1,8 @@
 # lita-pullrequests
 
-A Lita handler to help you keep track of your pull requests.
+A Lita handler to help you keep track of your pull requests. It can automatically post in your channels and tell you about which pull requests need attention in all of your repositories.
+
+This means that you can mark some pull requests as needing attention, and your Lita bot will automatically know about them and remind you to address them whenever you tell it to.
 
 ## Installation
 
@@ -16,7 +18,7 @@ Add the following configuration lines to your `lita_config`:
 
 ``` ruby
 config.handlers.pullrequests.access_token = "a-github-api-access-token"
-config.handlers.pullrequests.repo = "username/reponame"
+config.handlers.pullrequests.repos = ["username/reponame"]
 config.handlers.pullrequests.review_label = "title of a label that represents a pr ready for review"
 config.handlers.pullrequests.merge_label  = "title of a label that represents a pr ready for merge"
 ```
@@ -24,11 +26,20 @@ config.handlers.pullrequests.merge_label  = "title of a label that represents a
 ## Usage
 
 ```
-> @robot: give me something to review
+> @robot: give me something to review for reponame
 ...
 
 > @robot: summarize pull requests
 ....
+
+> @robot: set pull requests reminder for 0 20 * * 1-5
+....
+
+> @robot: show pull requests reminder
+....
+
+> @robot: stop reminding me about pull requests
+....
 ```
 
 ## License

data/lib/lita/handlers/pullrequests.rb

@@ -4,7 +4,7 @@ module Lita
   module Handlers
     class Pullrequests < Handler
       config :access_token, type: String, required: true
-      config :repo,         type: String, required: true
+      config :repos,        type: Array,  required: true
       config :review_label, type: String, required: false
       config :merge_label,  type: String, required: false
 
@@ -13,9 +13,8 @@ module Lita
       SCHEDULER = Rufus::Scheduler.new
       REDIS_KEY = "pullrequests-cron"
 
-      route(/^(pull request( me)?)|(give me something to review)$/, :get_random_pr, command: true, help: {
-        "give me something to review" => "Shows you a random pull request that needs reviewing.",
-        "pull request (me)" => "Shows you a random pull request that needs reviewing."
+      route(/^give me something to review for (.*)$/, :get_random_pr, command: true, help: {
+        "give me something to review for REPO NAME" => "Shows you a random pull request that needs reviewing.",
       })
 
       route(/^(summarize|all) pull requests$/, :list_all_pull_requests, command: true, help: {
@@ -50,19 +49,28 @@ module Lita
       end
 
       def fetch_pull_requests
-        url    = "https://api.github.com/repos/#{config.repo}/issues"
-        req    = http.get(url, access_token: config.access_token)
-        issues = MultiJson.load(req.body)
-        issues.select { |issue| issue["pull_request"] }
+        config.repos.map do |repo|
+          url    = "https://api.github.com/repos/#{repo}/issues"
+          req    = http.get(url, access_token: config.access_token)
+          issues = MultiJson.load(req.body)
+          issues.select { |issue| issue["pull_request"] }
+        end.flatten
       end
 
       def get_random_pr(chat)
-        pr = pulls_that_need_reviews.sample
-        if pr
-          title, user, url = pr["title"], pr["user"]["login"], pr["pull_request"]["html_url"]
-          chat.reply "_#{title}_ - #{user} \n    #{url}"
+        pulls = pulls_that_need_reviews.group_by { |pr| pr["url"].split("/")[-3] }
+        repo  = chat.matches[0][0]
+
+        if pulls[repo]
+          pr = pulls[repo].sample
+          if pr
+            title, user, url = pr["title"], pr["user"]["login"], pr["pull_request"]["html_url"]
+            chat.reply "_#{title}_ - #{user} \n    #{url}"
+          else
+            chat.reply "No pull requests need reviews right now!"
+          end
         else
-          chat.reply "No pull requests need reviews right now!"
+          chat.reply("I'm not configured for a repo with that name.")
         end
       end
 

data/lita-pullrequests.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-pullrequests"
-  spec.version       = "0.0.5"
+  spec.version       = "0.0.6"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = %q{A Lita handler to help you keep track of your pull requests.}
-  spec.summary       = %q{A Lita handler to help you keep track of your pull requests.}
+  spec.summary       = %q{A Lita handler to help you keep track of your pull requests. It can automatically post in your channels and tell you about which pull requests need attention.}
   spec.homepage      = "https://github.com/taylorlapeyre/lita-pullrequests"
   spec.license       = "MIT"
   spec.metadata      = { "lita_plugin_type" => "handler" }

data/spec/lita/handlers/pullrequests_spec.rb

@@ -3,14 +3,12 @@ require "spec_helper"
 describe Lita::Handlers::Pullrequests, lita_handler: true do
   before do
     Lita.config.handlers.pullrequests.access_token = ENV["GITHUB_ACCESS_TOKEN"]
-    Lita.config.handlers.pullrequests.repo         = "taylorlapeyre/lita-pullrequests"
+    Lita.config.handlers.pullrequests.repos        = ["taylorlapeyre/lita-pullrequests"]
     Lita.config.handlers.pullrequests.review_label = "Needs Review"
     Lita.config.handlers.pullrequests.merge_label  = "Ready To Merge"
   end
 
-  it { is_expected.to route_command("pull request").to(:get_random_pr) }
-  it { is_expected.to route_command("pull request me").to(:get_random_pr) }
-  it { is_expected.to route_command("give me something to review").to(:get_random_pr) }
+  it { is_expected.to route_command("give me something to review for lita-pullrequests").to(:get_random_pr) }
   it { is_expected.to route_command("all pull requests").to(:list_all_pull_requests) }
   it { is_expected.to route_command("summarize pull requests").to(:list_all_pull_requests) }
   it { is_expected.to route_command("set pull requests reminder for 0 20 * * 1-5").to(:set_reminder) }
@@ -22,11 +20,17 @@ describe Lita::Handlers::Pullrequests, lita_handler: true do
   it { is_expected.to_not route_command("all pull requests").to(:get_random_pr) }
 
   it "can respond with a random pull request" do
-    send_command("give me something to review")
+    send_command("give me something to review for lita-pullrequests")
     expect(replies).to_not be_empty
     expect(replies.last).to match /Example of a pull request ready for review/
   end
 
+  it "knows when you asked for a repo that it doesn't know about." do
+    send_command("give me something to review for foobar")
+    expect(replies).to_not be_empty
+    expect(replies.last).to eq "I'm not configured for a repo with that name."
+  end
+
   it "can respond with all pull requests" do
     send_command("summarize pull requests")
     expect(replies).to_not be_empty

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-pullrequests
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Taylor Lapeyre
@@ -136,7 +136,8 @@ rubyforge_project:
 rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: A Lita handler to help you keep track of your pull requests.
+summary: A Lita handler to help you keep track of your pull requests. It can automatically
+  post in your channels and tell you about which pull requests need attention.
 test_files:
 - spec/lita/handlers/pullrequests_spec.rb
 - spec/spec_helper.rb