lita-pubsub 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e66c398ae1aaf4a38282a3123fd82b92dc00af13
-  data.tar.gz: 965c8cd0e81d0b9283008ddc1635c8825b69371a
+  metadata.gz: 68a896e1f4a09f59163397b82b838cca616d71d2
+  data.tar.gz: 1e6d2a0da4e961588b9ed11f4796df2e00e045dc
 SHA512:
-  metadata.gz: ef4af4cc4e7f9d87e3eb422b7a38458524e2b2ab7565b65534dd923aaedee24380a3ceea7f1184ff7a810520403bfdfbddf1de74ed87f766d9c3834d0763d268
-  data.tar.gz: 473d304d75f7f76aa4f2fbc14b07de150c37dfc6ca7dea0b71f245e1f95a727f7eec5527d5c57c8387497112f2e4e43bf53cf2a1d5891271970650021b7a2fb8
+  metadata.gz: f0ba0e1107797510cd6bc27f77539a80226a4fbc87221df94daa7ca4a17dff046f3469781393fc37c63932b85fb4919fd14e66b3a912cf62e306b3c171ee0115
+  data.tar.gz: 24ea314614874cde1155be2ed13f3a21b1a86a5a3ff4d30ff70fcf9c5e9175d17772cca8b8d4c687339f279da139bfedc63dc54d7553c2e771900498f5b7da7b

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [0.2.0] - 2017-11-14
+### Added
+- Send asynchronous early response to http publish requests

data/lib/lita/handlers/pubsub.rb

@@ -76,23 +76,27 @@ module Lita
 
       def http_get(request, response)
         validate_http_password!(request.params['password'])
-        robot.trigger(
-          :publish,
-          event: request.params['event'],
-          data: request.params['data']
-        )
         response.write('ok')
+        Thread.new do
+          robot.trigger(
+            :publish,
+            event: request.params['event'],
+            data: request.params['data']
+          )
+        end
       end
 
       def http_post(request, response)
         data = JSON.parse(request.body.read)
         validate_http_password!(request.params['password'] || data['password'])
-        robot.trigger(
-          :publish,
-          event: data['event'],
-          data: data['data']
-        )
         response.write('ok')
+        Thread.new do
+          robot.trigger(
+            :publish,
+            event: data['event'],
+            data: data['data']
+          )
+        end
       end
 
       def all_subscriptions(response)

data/lita-pubsub.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-pubsub"
-  spec.version       = "0.1.1"
+  spec.version       = "0.2.0"
   spec.authors       = ["Tomas Varaneckas"]
   spec.email         = ["tomas.varaneckas@gmail.com"]
   spec.description   = "PubSub notification system for Lita"

data/spec/lita/handlers/pubsub_spec.rb

@@ -108,6 +108,7 @@ describe Lita::Handlers::Pubsub, lita_handler: true do
     it 'receives events via http get' do
       send_message("lita subscribe foo", from: room)
       http.get('/publish?event=foo&data=bar%20baz&password=secret')
+      sleep 0.1 # Give thread some time
       expect(replies.last).to eq('*foo*: bar baz')
     end
 
@@ -118,6 +119,7 @@ describe Lita::Handlers::Pubsub, lita_handler: true do
         '{"event": "foo", "data":"bar baz", "password":"secret"}',
         'Content-Type' => 'application/json'
       )
+      sleep 0.1 # Give thread some time
       expect(replies.last).to eq('*foo*: bar baz')
     end
 
@@ -125,18 +127,21 @@ describe Lita::Handlers::Pubsub, lita_handler: true do
       send_message("lita subscribe foo", from: room)
       Lita.config.handlers.pubsub.http_password = nil
       http.get('/publish?event=foo&data=bar%20baz')
+      sleep 0.1 # Give thread some time
       expect(replies.last).to eq('*foo*: bar baz')
     end
 
     it 'rejects http request without any password' do
       expect {
         http.get('/publish?event=foo&data=bar%20baz')
+        sleep 0.1 # Give thread some time
       }.to raise_error('incorrect password!')
     end
 
     it 'rejects bad password via http get' do
       expect {
         http.get('/publish?event=foo&data=bar%20baz&password=haxor')
+        sleep 0.1 # Give thread some time
       }.to raise_error('incorrect password!')
     end
 
@@ -147,6 +152,7 @@ describe Lita::Handlers::Pubsub, lita_handler: true do
           '{"event":"foo", "data":"bar baz", "password":"lol"}',
           'Content-Type' => 'application/json'
         )
+        sleep 0.1 # Give thread some time
       }.to raise_error('incorrect password!')
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-pubsub
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Tomas Varaneckas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-31 00:00:00.000000000 Z
+date: 2017-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -131,6 +131,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - README.md
 - Rakefile