lita-poll 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e95ca628bcd95e09d55a7b3f7ad6fb50010d65fd
-  data.tar.gz: e36cd4ade813e7daa1e705840313f98ca0762f4e
+  metadata.gz: a841e0cca4684cbda447fbda0c3d5160c8194c38
+  data.tar.gz: 350e0171517ccebd1dab8fff1dfdfff676da9fb1
 SHA512:
-  metadata.gz: 4b21154eafd2c2cb9bce025467109b035921a732c8634457481266a1bbd46c0494a86044bd3473d27596532ccfacc8844eec870a4811bad78031988cf9d3e11e
-  data.tar.gz: 37329aea6401158078f04dbc971b8b9517df28945e2f454bdd0cc15f9c07a1e5cc4d78575a199ff17db9bb06410e34b143368bad09ce8a97e400c89341826085
+  metadata.gz: dc9eeff602562d8f6b9d2e97e673d106af10c977290659de47e8f8e75838e7b6ec18bf4956faa1d48b2af76928bd35e15cd867d1827edb837617ef9b4e455d4c
+  data.tar.gz: 153ec113bf1958ffec3744e03e7ce348369a90301dbcbc802ba4582597a23fcfdf13993ed467e4af335760b42120ba48dcfc974be9e890fdd8723a8c1646a1cd

data/lib/lita/handlers/pollHandler.rb

@@ -68,7 +68,7 @@ module Lita
           poll = Poll.json_create(JSON.parse(poll))
           idx = 0
           response.reply(t("replies.info.header", poll_topic: poll.topic))
-          every(1) do |timer|
+          every(0.5) do |timer|
             if idx >= poll.options.length
               timer.stop
             else
@@ -92,7 +92,7 @@ module Lita
           response.reply(t("replies.general.poll_not_found", id: id))
         else
           poll = Poll.json_create(JSON.parse(poll))
-          if poll.valid_vote(optNum)
+          if poll.valid_vote?(optNum)
             poll.vote(response.user, optNum)
             redis.set(poll.id, poll.to_json)
             response.reply_privately(t(
@@ -123,7 +123,7 @@ module Lita
 
           idx = 0
           response.reply(t("replies.tally.header"))
-          every(1) do |timer|
+          every(0.5) do |timer|
             if idx >= poll.options.length
               timer.stop
             else
@@ -148,4 +148,4 @@ module Lita
 
     Lita.register_handler(PollHandler)
   end
-end
+end

data/lita-poll.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-poll"
-  spec.version       = "1.0.1"
+  spec.version       = "1.0.2"
   spec.authors       = ["Michael Chua"]
   spec.email         = ["chua.mbt@gmail.com"]
   spec.summary       = %q{Plugin that enables polling functionality for a lita bot.}
@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", ">= 3.3"
+  spec.add_runtime_dependency "lita", ">= 4.2.1"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/spec/lita/handlers/poll_spec.rb

@@ -1,4 +1,140 @@
 require "spec_helper"
 
-describe Lita::Handlers::Poll, lita_handler: true do
+describe Lita::Handlers::PollHandler, lita_handler: true do
+  ph = Lita::Handlers::PollHandler
+  topics = ['Topic1', 'Topic2']
+  options = ['Option1', 'Option2', 'Option3']
+  topic1Id = Poll.new(topics.first).id
+
+  let(:poll_admin) do
+    user = Lita::User.create(1, name: "Poll Admin")
+    Lita::Authorization.new(registry.config).add_user_to_group!(user, :poll_admins)
+    user
+  end
+  let(:poll_user1) { Lita::User.create(2, name: "Poll User1") }
+  let(:poll_user2) { Lita::User.create(3, name: "Poll User2") }
+
+  it { is_expected.to route_command("poll list").to(:list) }
+  topics.map { |topic|
+    poll = Poll.new(topic)
+    it { is_expected.to route_command("poll make "+topic).to(:make) }
+    it { is_expected.to route_command("poll option "+poll.id+" Option 1").to(:option) }
+    it { is_expected.to route_command("poll info "+poll.id).to(:info) }
+    it { is_expected.to route_command("poll vote "+poll.id+" 1").to(:vote) }
+    it { is_expected.to route_command("poll tally "+poll.id).to(:tally) }
+    it { is_expected.not_to route_command("poll complete "+poll.id).to(:complete) }
+    it { is_expected.to route_command("poll complete "+poll.id).with_authorization_for(:poll_admins).to(:complete) }
+
+  }
+  it { is_expected.to route_command("poll clear").with_authorization_for(:poll_admins).to(:clear) }
+  it { is_expected.not_to route_command("poll clear").to(:clear) }
+
+  describe "polling for users" do
+    it "no polls" do
+      send_command('poll list', as: poll_user1)
+      expect(replies.last).to eq(ph::translate("replies.list.no_polls"))
+    end
+
+    it "invalid poll" do
+      dummy_topic = 'Dummy'
+      dummy_poll = Poll.new(dummy_topic)
+      send_command('poll option '+dummy_poll.id+' DummyOption', as: poll_user1)
+      send_command('poll vote '+dummy_poll.id+' 1', as: poll_user1)
+      send_command('poll info '+dummy_poll.id, as: poll_user1)
+      send_command('poll tally '+dummy_poll.id, as: poll_user1)
+      replies.map { |reply| expect(reply).to eq(ph::translate("replies.general.poll_not_found", id: dummy_poll.id))
+      }
+    end
+
+    it "make and use polls" do
+      # make
+      topics.map { |topic|
+        poll = Poll.new(topic)
+        send_command('poll make '+topic, as: poll_user1)
+        success = ph::translate("replies.make.success", poll_id: poll.id, poll_topic: poll.topic)
+        expect(replies.last).to eq(success)
+      }
+      # list
+      send_command('poll list', as: poll_user2)
+      list_reply = replies.last(topics.length+1)
+      expect(list_reply.first).to eq(ph::translate("replies.list.header"))
+      topics.map { |topic, reply|
+        poll = Poll.new(topic)
+        success = ph::translate("replies.list.poll", poll_id: poll.id, poll_topic: poll.topic)
+        expect(list_reply.drop(1)).to include(success)
+      }
+      # add options
+      options.map { |option|
+        topic = topics.first
+        poll = Poll.new(topic)
+        send_command('poll option '+poll.id+' '+option, as: poll_user1)
+        success = ph::translate("replies.option.success", option: option, poll_id: poll.id)
+        expect(replies.last).to eq(success)
+      }
+      # check poll info
+      send_command('poll info '+topic1Id, as: poll_user2)
+      sleep(2)
+      info_reply = replies.last(options.length+1)
+      expect(info_reply.first).to eq(ph::translate("replies.info.header", poll_topic: topics.first))
+      options.zip(info_reply.drop(1)).each_with_index.map { |pair, idx|
+        option = pair.first
+        reply = pair.last
+        success = ph::translate("replies.info.option", idx: idx+1, option: option)
+        expect(reply).to eq(success)
+      }
+      # voting and tallying
+      send_command('poll vote '+topic1Id+' 1', as: poll_user1)
+      expect(replies.last).to eq(ph::translate("replies.vote.success", option: options[0]))
+      send_command('poll vote '+topic1Id+' 2', as: poll_user2)
+      expect(replies.last).to eq(ph::translate("replies.vote.success", option: options[1]))
+      send_command('poll tally '+topic1Id, as: poll_user2)
+      sleep(2)
+      tally_reply = replies.last(options.length+1)
+      expect(tally_reply[0]).to eq(ph::translate("replies.tally.header"))
+      expect(tally_reply[1]).to eq(ph::translate("replies.tally.option", option: options[0], votes: 1))
+      expect(tally_reply[2]).to eq(ph::translate("replies.tally.option", option: options[1], votes: 1))
+      expect(tally_reply[3]).to eq(ph::translate("replies.tally.option", option: options[2], votes: 0))
+      # change vote
+      send_command('poll vote '+topic1Id+' 3', as: poll_user1)
+      expect(replies.last).to eq(ph::translate("replies.vote.success", option: options[2]))
+      send_command('poll tally '+topic1Id, as: poll_user2)
+      sleep(2)
+      tally_reply = replies.last(options.length+1)
+      expect(tally_reply[0]).to eq(ph::translate("replies.tally.header"))
+      expect(tally_reply[1]).to eq(ph::translate("replies.tally.option", option: options[0], votes: 0))
+      expect(tally_reply[2]).to eq(ph::translate("replies.tally.option", option: options[1], votes: 1))
+      expect(tally_reply[3]).to eq(ph::translate("replies.tally.option", option: options[2], votes: 1))
+      # voting for non-existent options
+      send_command('poll vote '+topic1Id+' 4', as: poll_user1)
+      expect(replies.last).to eq(ph::translate("replies.vote.not_found"))
+    end
+  end
+
+  describe "poll administration" do
+    it "complete poll" do
+      topics.map { |topic|
+        poll = Poll.new(topic)
+        send_command('poll make '+topic, as: poll_user1)
+      }
+      send_command('poll complete '+topic1Id, as: poll_admin)
+      expect(replies.last).to eq(ph::translate("replies.complete.success"))
+      send_command('poll list', as: poll_user1)
+      sleep(2)
+      list_reply = replies.last(topics.length)
+      expect(list_reply.first).to eq(ph::translate("replies.list.header"))
+      puts list_reply
+    end
+
+    it "clear polls" do
+      topics.map { |topic|
+        poll = Poll.new(topic)
+        send_command('poll make '+topic, as: poll_user1)
+      }
+      send_command('poll clear', as: poll_admin)
+      expect(replies.last).to eq(ph::translate("replies.clear.success"))
+      send_command('poll list', as: poll_user1)
+      expect(replies.last).to eq(ph::translate("replies.list.no_polls"))
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,2 +1,4 @@
 require "lita-poll"
 require "lita/rspec"
+
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-poll
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Michael Chua
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-07 00:00:00.000000000 Z
+date: 2015-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: 4.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: 4.2.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -106,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Plugin that enables polling functionality for a lita bot.