lita-pagerduty 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 995b4cc2ce45f281596f3db0ad7e743b41366f78
-  data.tar.gz: c372723772d7453a7d61433a35cabd21d2b55496
+  metadata.gz: f267ef87e565e1a057e419594aac1c2355b4b3b6
+  data.tar.gz: 2f1f47d4b76d1cb0343f52608b5bedf2f8e2ee4b
 SHA512:
-  metadata.gz: fe7ab1d8f578117c52e61d6485e7a9a28af17232cc97d6a62f1ff12a782e390669783a9b4064c2f35a65fa19d874c9519a013b2949dba5a6ca9a884500cc5a63
-  data.tar.gz: e795ce52f3318fc166f85d8b1229eddcfdf915a063aef9006d0b3cc2ad37072c82ff8196f2b58d95253d228ce78107d3328b0d4fb4e12a78ba5d792a85ea0dc7
+  metadata.gz: d87edef11c6072ade59a61aba8b89f2324b54943638769d4c378d378f6a9157217c28810c17dc790093ba55e95b8689e64c1f1661cd1f3b26025f90ca5c5c4da
+  data.tar.gz: 9a81f446e593fc25bd7928ed89b7c2b2728ead01c84b24af402741142d1e15f0d276e29a44733740ce979dda4d7aa38689a3d54e65c2340b24710e41412300e5

data/.rspec

@@ -0,0 +1 @@
+--color --profile 5

data/.rubocop.yml

@@ -4,6 +4,3 @@ FileName:
 
 LineLength:
   Max: 130
-
-AbcSize:
-  Enabled: false

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
   - 2.1
-script: bundle exec rake
-before_install:
-  - gem update --system
+  - 2.2
 services:
   - redis-server
+cache: bundler
+sudo: false

data/README.md

@@ -58,6 +58,13 @@ pager resolve mine                 - Resolve all triggered incidents assigned to
 pager resolve <incident ID>        - Resolve a specific incident
 ```
 
+### Schedules
+
+```
+pager oncall - List available schedules
+pager oncall <schedule> - Show who is on call for the given schedule
+```
+
 ### Misc
 
 ```

data/lib/lita-pagerduty.rb

@@ -15,3 +15,23 @@ require 'lita/handlers/pagerduty_incident'
 require 'lita/handlers/pagerduty_note'
 require 'lita/handlers/pagerduty_resolve'
 require 'lita/handlers/pagerduty_utility'
+
+Lita::Handlers::PagerdutyAck.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)
+
+Lita::Handlers::PagerdutyIncident.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)
+
+Lita::Handlers::PagerdutyNote.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)
+
+Lita::Handlers::PagerdutyResolve.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)
+
+Lita::Handlers::PagerdutyUtility.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)

data/lib/lita/handlers/pagerduty_ack.rb

@@ -37,6 +37,7 @@ module Lita
         }
       )
 
+      # rubocop:disable Metrics/AbcSize
       def ack_all(response)
         incidents = fetch_all_incidents
         return response.reply(t('incident.none')) unless incidents.count > 0
@@ -47,7 +48,9 @@ module Lita
           response.reply(t('all.acknowledged', list: completed.join(', ')))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
+      # rubocop:disable Metrics/AbcSize
       def ack_mine(response)
         email = fetch_user(response.user)
         return response.reply(t('identify.missing')) unless email
@@ -60,6 +63,7 @@ module Lita
           response.reply(t('all.acknowledged', list: completed.join(', ')))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       def ack(response)
         incident_id = response.match_data['incident_id']

data/lib/lita/handlers/pagerduty_note.rb

@@ -28,6 +28,7 @@ module Lita
         }
       )
 
+      # rubocop:disable Metrics/AbcSize
       def notes(response)
         incident_id = response.match_data['incident_id']
         incident = fetch_incident(incident_id)
@@ -37,6 +38,7 @@ module Lita
           response.reply(format_note(incident, note))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       def note(response)
         response.reply(t('error.not_implemented'))

data/lib/lita/handlers/pagerduty_resolve.rb

@@ -37,6 +37,7 @@ module Lita
         }
       )
 
+      # rubocop:disable Metrics/AbcSize
       def resolve_all(response)
         incidents = fetch_all_incidents
         return response.reply(t('incident.none')) unless incidents.count > 0
@@ -47,7 +48,9 @@ module Lita
           response.reply(t('all.resolved', list: completed.join(',')))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
+      # rubocop:disable Metrics/AbcSize
       def resolve_mine(response)
         email = fetch_user(response.user)
         return response.reply(t('identify.missing')) unless email
@@ -60,6 +63,7 @@ module Lita
           response.reply(t('all.resolved', list: completed.join(',')))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       def resolve(response)
         incident_id = response.match_data['incident_id']

data/lib/lita/handlers/pagerduty_utility.rb

@@ -54,16 +54,17 @@ module Lita
       def on_call_list(response)
         schedules = pd_client.get_schedules.schedules
         if schedules.any?
-          schedule_list = schedules.map(&:name).join(', ')
+          schedule_list = schedules.map(&:name).join("\n")
           response.reply(t('on_call_list.response', schedules: schedule_list))
         else
           response.reply(t('on_call_list.no_schedules_found'))
         end
       end
 
+      # rubocop:disable Metrics/AbcSize
       def on_call_lookup(response)
         schedule_name = response.match_data[1].strip
-        schedule = pd_client.get_schedules.schedules.find { |s| s.name == schedule_name }
+        schedule = pd_client.get_schedules.schedules.find { |s| s.casecmp(schedule_name) == 0 }
 
         unless schedule
           return response.reply(t('on_call_lookup.no_matching_schedule', schedule_name: schedule_name))
@@ -75,6 +76,7 @@ module Lita
           response.reply(t('on_call_lookup.no_one_on_call', schedule_name: schedule_name))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       def identify(response)
         email = response.match_data['email']

data/lib/pagerduty_helper/incident.rb

@@ -5,7 +5,8 @@ module PagerdutyHelper
     def format_incident(incident)
       t('incident.info', id: incident.id,
                          subject: incident.trigger_summary_data.subject,
-                         assigned: incident.assigned_to_user.email)
+                         url: incident.html_url,
+                         assigned: incident.assigned_to_user.nil? ? 'none' : incident.assigned_to_user.email)
     end
 
     def resolve_incident(incident_id)
@@ -45,6 +46,7 @@ module PagerdutyHelper
       client.get_incident(id: incident_id)
     end
 
+    # rubocop:disable Metrics/AbcSize
     def acknowledge_incident(incident_id)
       incident = fetch_incident(incident_id)
       return t('incident.not_found', id: incident_id) if incident == 'No results'
@@ -57,5 +59,6 @@ module PagerdutyHelper
         t('incident.unable_to_acknowledge', id: incident_id)
       end
     end
+    # rubocop:enable Metrics/AbcSize
   end
 end

data/lib/pagerduty_helper/regex.rb

@@ -2,7 +2,7 @@
 module PagerdutyHelper
   # Utility functions
   module Regex
-    INCIDENT_ID_PATTERN = /(?<incident_id>[a-zA-Z0-9+]{1,6})/
+    INCIDENT_ID_PATTERN = /(?<incident_id>[a-zA-Z0-9+]+)/
     EMAIL_PATTERN       = /(?<email>[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+)/i
   end
 end

data/lita-pagerduty.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-pagerduty'
-  spec.version       = '0.1.0'
+  spec.version       = '0.1.2'
   spec.authors       = ['Eric Sigler']
   spec.email         = ['eric@pagerduty.com']
   spec.description   = 'A Lita handler to interact with PagerDuty'

data/locales/en.yml

@@ -66,7 +66,7 @@ en:
           resolved: "%{id}: Incident resolved"
           unable_to_acknowledge: "%{id}: Unable to acknowledge incident"
           unable_to_resolve: "%{id}: Unable to resolve incident"
-          info: "%{id}: \"%{subject}\", assigned to: %{assigned}"
+          info: "%{id}: \"%{subject}\", assigned to: %{assigned}, url: %{url}"
         forget:
           complete: Your email has now been forgotten.
           unknown: No email on record for you.
@@ -76,7 +76,7 @@ en:
         note:
           show: "%{id}: %{content} (%{email})"
         on_call_list:
-          response: "Available schedules: %{schedules}"
+          response: "Available schedules:\n%{schedules}"
           no_schedules_found: "No schedules found"
         on_call_lookup:
           response: "%{name} (%{email}) is currently on call for %{schedule_name}"

data/spec/lita/handlers/pagerduty_incident_spec.rb

@@ -15,7 +15,7 @@ describe Lita::Handlers::PagerdutyIncident, lita_handler: true do
         expect(Pagerduty).to receive(:new) { incidents }
         send_command('pager incidents all')
         expect(replies.last).to eq('ABC789: "Still broke", assigned to: '\
-                                   'bar@example.com')
+                                   'bar@example.com, url: https://acme.pagerduty.com/incidents/ABC789')
       end
     end
 
@@ -37,7 +37,7 @@ describe Lita::Handlers::PagerdutyIncident, lita_handler: true do
         send_command('pager identify bar@example.com', as: bar)
         send_command('pager incidents mine', as: bar)
         expect(replies.last).to eq('ABC789: "Still broke", assigned to: ' \
-                                   'bar@example.com')
+                                   'bar@example.com, url: https://acme.pagerduty.com/incidents/ABC789')
       end
     end
 
@@ -67,7 +67,8 @@ describe Lita::Handlers::PagerdutyIncident, lita_handler: true do
         expect(Pagerduty).to receive(:new) { new_incident }
         send_command('pager incident ABC123')
         expect(replies.last).to eq('ABC123: "something broke", ' \
-                                   'assigned to: foo@example.com')
+                                   'assigned to: foo@example.com, ' \
+                                   'url: https://acme.pagerduty.com/incidents/ABC123')
       end
     end
 
@@ -78,5 +79,25 @@ describe Lita::Handlers::PagerdutyIncident, lita_handler: true do
         expect(replies.last).to eq('ABC123: Incident not found')
       end
     end
+
+    describe 'when the incident id is longer than 6 characters' do
+      it 'shows the incident details' do
+        expect(Pagerduty).to receive(:new) { incident_with_long_id }
+        send_command('pager incident ABC123456789')
+        expect(replies.last).to eq('ABC123456789: "something broke", ' \
+                                   'assigned to: foo@example.com, ' \
+                                   'url: https://acme.pagerduty.com/incidents/ABC123456789')
+      end
+    end
+
+    describe 'when the incident is not assigned to anyone' do
+      it 'shows incident details with none user' do
+        expect(Pagerduty).to receive(:new) { incident_without_assigned_user }
+        send_command('pager incident ABC456')
+        expect(replies.last).to eq('ABC456: "something broke", ' \
+                                   'assigned to: none, ' \
+                                   'url: https://acme.pagerduty.com/incidents/ABC456')
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'simplecov'
 require 'coveralls'
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+SimpleCov.formatters = [
   SimpleCov::Formatter::HTMLFormatter,
   Coveralls::SimpleCov::Formatter
 ]
@@ -19,6 +19,21 @@ RSpec.configure do |config|
     registry.register_handler(Lita::Handlers::PagerdutyResolve)
     registry.register_handler(Lita::Handlers::PagerdutyUtility)
   end
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+  config.default_formatter = 'doc' if config.files_to_run.one?
+  config.order = :random
+
+  Kernel.srand config.seed
 end
 
 RSpec.shared_context 'basic fixtures' do
@@ -46,12 +61,14 @@ RSpec.shared_context 'basic fixtures' do
           double(
             id: 'ABC123',
             status: 'resolved',
+            html_url: 'https://acme.pagerduty.com/incidents/ABC123',
             trigger_summary_data: double(subject: 'something broke'),
             assigned_to_user: double(email: 'foo@example.com')
           ),
           double(
             id: 'ABC789',
             status: 'triggered',
+            html_url: 'https://acme.pagerduty.com/incidents/ABC789',
             trigger_summary_data: double(subject: 'Still broke'),
             assigned_to_user: double(email: 'bar@example.com')
           )
@@ -61,6 +78,7 @@ RSpec.shared_context 'basic fixtures' do
     allow(client).to receive(:get_incident) do
       double(
         status: 'triggered',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC789',
         trigger_summary_data: double(subject: 'Still broke'),
         assigned_to_user: double(email: 'bar@example.com'),
         acknowledge: { 'id' => 'ABC789', 'status' => 'acknowledged' },
@@ -77,6 +95,7 @@ RSpec.shared_context 'basic fixtures' do
       double(
         id: 'ABC123',
         status: 'triggered',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         trigger_summary_data: double(subject: 'something broke'),
         assigned_to_user: double(email: 'foo@example.com'),
         acknowledge: { 'id' => 'ABC123', 'status' => 'acknowledged' },
@@ -87,11 +106,26 @@ RSpec.shared_context 'basic fixtures' do
     client
   end
 
+  let(:incident_without_assigned_user) do
+    client = double
+    expect(client).to receive(:get_incident) do
+      double(
+        id: 'ABC456',
+        status: 'triggered',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC456',
+        trigger_summary_data: double(subject: 'something broke'),
+        assigned_to_user: nil
+      )
+    end
+    client
+  end
+
   let(:acknowledged_incident) do
     client = double
     expect(client).to receive(:get_incident) do
       double(
         status: 'acknowledged',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         trigger_summary_data: double(subject: 'something broke'),
         assigned_to_user: double(email: 'foo@example.com'),
         acknowledge: { 'error' =>
@@ -109,6 +143,7 @@ RSpec.shared_context 'basic fixtures' do
     expect(client).to receive(:get_incident) do
       double(
         status: 'resolved',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         trigger_summary_data: double(subject: 'something broke'),
         assigned_to_user: double(email: 'foo@example.com'),
         notes: double(notes: [])
@@ -122,6 +157,7 @@ RSpec.shared_context 'basic fixtures' do
     expect(client).to receive(:get_incident) do
       double(
         status: 'notresolved',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         resolve:  { 'id' => 'ABC123', 'status' => 'notresolved' }
       )
     end
@@ -133,6 +169,7 @@ RSpec.shared_context 'basic fixtures' do
     expect(client).to receive(:get_incident) do
       double(
         status: 'notacked',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         acknowledge: { 'error' => {} },
         resolve:  { 'id' => 'ABC123', 'status' => 'notacked' }
       )
@@ -146,6 +183,7 @@ RSpec.shared_context 'basic fixtures' do
       double(
         id: 'ABC123',
         status: 'resolved',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123',
         trigger_summary_data: double(subject: 'something broke'),
         assigned_to_user: double(email: 'foo@example.com'),
         notes: double(
@@ -156,4 +194,18 @@ RSpec.shared_context 'basic fixtures' do
     end
     client
   end
+
+  let(:incident_with_long_id) do
+    client = double
+    expect(client).to receive(:get_incident) do
+      double(
+        id: 'ABC123456789',
+        status: 'triggered',
+        html_url: 'https://acme.pagerduty.com/incidents/ABC123456789',
+        trigger_summary_data: double(subject: 'something broke'),
+        assigned_to_user: double(email: 'foo@example.com')
+      )
+    end
+    client
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-pagerduty
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Eric Sigler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-19 00:00:00.000000000 Z
+date: 2016-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
 - CONTRIBUTING.md
@@ -175,7 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: A Lita handler to interact with PagerDuty