lita-onewheel-giphy 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea5fa7cf083a32d35ea2cf48737ff557b375f6c0
-  data.tar.gz: beebc189f97b74a11f465051bf4cce5a7d83da82
+  metadata.gz: 5372211883a9026d79a4290b171b25b3cf674e82
+  data.tar.gz: a4ca41660c7db07b507f5dcf7eed61fbd05885f2
 SHA512:
-  metadata.gz: cbf70766a66276f6a214601f01e9df021602e18b695c2239c6e9248ffd61c6fdc6f3550dcda89f1a8bf9526324caddc44ac180480f5e25f4e1ac68634670ed8a
-  data.tar.gz: 53043edb9424498c10534cabbc4b88fe3111699cef98a0663445ff95740994251e92e6dbd7aeb1143ca1f68f412b57bb64e0072aae7f67fab0a0bb8d200b3c05
+  metadata.gz: dbf11d271668b260731bb068983e4efff332da81a4aa7dcbd60679dc29d23400a928dabbfa5df57d2ffce922768f1607afa47b1545fbfa4b37a539b65ebe69a1
+  data.tar.gz: 330a64de8363bfbe976a5a1d8ef23ada34a5974a24ef045999000e9e18550b379e767b5bfa1ea440109b8cf8e4679e3ab9af89852dab64230db1c74eba40c81b

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 rvm:
-  - 2.2.4
-  - 2.3.0
+  - 2.3.4
 script: bundle exec rake
 before_install:
   - gem update --system

data/lib/lita/handlers/onewheel_giphy.rb

@@ -21,6 +21,10 @@ module Lita
             # :search,
             command: true,
             help: {'giphy [keyword]' => 'Returns a random Giphy image with the specified keyword applied.'}
+      route /^giphysearch\s+(.+)$/i,
+            :search,
+            command: true,
+            help: {'giphysearch [keyword]' => 'Returns a random Giphy image with the specified keyword applied via search instead of translate.'}
       route /^gif\s+(.+)$/i,
             :translate,
             command: true,
@@ -38,6 +42,7 @@ module Lita
         keywords = response.matches[0][0]
         Lita.logger.debug "Searching giphy for #{keywords}"
         uri = get_search_uri(keywords)
+        Lita.logger.debug "search: #{uri}"
         giphy_data = call_giphy(uri)
         image = get_random(giphy_data.body)
         response.reply image
@@ -45,6 +50,7 @@ module Lita
 
       def random(response)
         uri = get_random_uri
+        Lita.logger.debug "random: #{uri}"
         giphy_data = call_giphy(uri)
         image = get_image(giphy_data.body)
         response.reply image
@@ -52,6 +58,7 @@ module Lita
 
       def trending(response)
         uri = get_trending_uri
+        Lita.logger.debug "trending: #{uri}"
         giphy_data = call_giphy(uri)
         image = get_random(giphy_data.body)
         response.reply image
@@ -60,6 +67,7 @@ module Lita
       def translate(response)
         keywords = response.matches[0][0]
         uri = get_translate_uri(keywords)
+        Lita.logger.debug "translate: #{uri}"
         giphy_data = call_giphy(uri)
         image = get_translate_image(giphy_data.body)
         response.reply image
@@ -98,7 +106,7 @@ module Lita
       def get_random(data)
         image_data = JSON.parse(data)
         if image_data['data'].count == 0
-          Lita.logger.debug 'No images found.'
+          Lita.logger.debug 'get_random: No images found.'
           return
         end
         image = image_data['data'][get_random_number(image_data['data'].count)]['images']['original']['url']

data/lita-onewheel-giphy.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-onewheel-giphy'
-  spec.version       = '0.4.2'
+  spec.version       = '0.4.3'
   spec.authors       = ['Andrew Kreps']
   spec.email         = ['andrew.kreps@gmail.com']
   spec.description   = 'Lita chat interface to giphy api for MOAR GIFS'

data/spec/fixtures/trending_empty.json

@@ -0,0 +1,11 @@
+{
+  "data": [],
+  "pagination": {
+    "count": 0,
+    "offset": 0
+  },
+  "meta": {
+    "status": 200,
+    "msg": "OK"
+  }
+}

data/spec/lita/handlers/onewheel_giphy_spec.rb

@@ -15,6 +15,7 @@ describe Lita::Handlers::OnewheelGiphy, lita_handler: true do
   it { is_expected.to route_command('giphy soon') }
   it { is_expected.to route_command('giphytrending') }
   it { is_expected.to route_command('giphytranslate boom') }
+  it { is_expected.to route_command('giphysearch boom') }
 
   it 'gets a giphy by string keywords' do
     mock_fixture('translate_good')
@@ -28,12 +29,24 @@ describe Lita::Handlers::OnewheelGiphy, lita_handler: true do
     expect(replies.last).to eq('https://media1.giphy.com/media/T2NINhwlHgOSk/giphy.gif')
   end
 
+  it 'gets a giphy via search' do
+    mock_fixture('search_good')
+    send_command 'giphysearch boom'
+    expect(replies.last).to eq('http://media2.giphy.com/media/FiGiRei2ICzzG/giphy.gif')
+  end
+
   it 'gets a random giphy' do
     mock_fixture('random_good')
     send_command 'giphy'
     expect(replies.last).to eq('http://s3.amazonaws.com/giphygifs/media/Ggjwvmqktuvf2/giphy.gif')
   end
 
+  it 'gets no trending giphy' do
+    mock_fixture('trending_empty')
+    send_command 'giphytrending'
+    expect(replies.last).to eq(nil)
+  end
+
   it 'gets a trending giphy' do
     mock_fixture('trending_good')
     send_command 'giphytrending'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-onewheel-giphy
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Andrew Kreps
@@ -141,6 +141,7 @@ files:
 - spec/fixtures/random_good.json
 - spec/fixtures/search_good.json
 - spec/fixtures/translate_good.json
+- spec/fixtures/trending_empty.json
 - spec/fixtures/trending_good.json
 - spec/lita/handlers/onewheel_giphy_spec.rb
 - spec/spec_helper.rb
@@ -173,6 +174,7 @@ test_files:
 - spec/fixtures/random_good.json
 - spec/fixtures/search_good.json
 - spec/fixtures/translate_good.json
+- spec/fixtures/trending_empty.json
 - spec/fixtures/trending_good.json
 - spec/lita/handlers/onewheel_giphy_spec.rb
 - spec/spec_helper.rb