lita-lunch 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 09440fc049f26143edaffbf0e422d13801620d04
-  data.tar.gz: 21e56d4f1be93ed43a5519828d471ec667fea44c
+  metadata.gz: 755cce4899f9b00ba7eab7bda7a0728fde4a483d
+  data.tar.gz: 3e633a2dbbea3000b0d8edf3aacf33cc5d3e398a
 SHA512:
-  metadata.gz: 2c9450480d92e7111e0f9f25ed90d6ca4b4354368c13923d9baf0ec1c5a20322f56db69817691047ebcb0a7f5146f73fd42f9a4f3d9acd4d343b9f0a72488eb4
-  data.tar.gz: 8940dc9003c4c6a1eb89a29a4fdd7f607417fab303ce3c1464c1c48d97c5917fad3666a126c2e9f573590c59e242c2dd3433259dc54c528e666092fb6501d5d5
+  metadata.gz: abbbf314b32e5974c6b70ceb95415c0ec3a303ab1c1474b17317bf044a9459002ed2146a70249d18e25582aa0dc0a1dc2378786caf1d980497e078da921cfb7e
+  data.tar.gz: 8736ff2b04212544f823ea3820d8767b3534878057002dbe6d272ffbc4bf208acccba6e03a5be14ba3232126504506d86c58765175b6337e0eacf3efc3ad9c3c

data/README.md

@@ -5,6 +5,8 @@
 
 A lita handler to help you pick where to go for lunch.
 
+Populate Lita with a list of of your favourite lunch places, so next next time someone asks "where should I go for lunch?" you get a useful suggestion.
+
 ## Installation
 
 Add lita-lunch to your Lita instance's Gemfile:
@@ -22,25 +24,38 @@ There is no additional configuration.
 First you will to add some of your favorite lunch places:
 
 ```
-lita lunch add the taco hut
-lita lunch add Korean BBQ
+You: lita lunch add the taco hut
+Lita: taco hut has been added
+
+You: lita lunch add Korean BBQ
+Lita: Korean BBQ has been added
+
+You: lita lunch add :hamburger:
+Lita: :hamburger: has been added
 ```
 
 Then you can get a lunch suggestion:
 
 ```
-where should I go for lunch?
-lita lunch suggestion
+You: where should I go for lunch?
+Lita: How about the taco hut?
+
+You: lita lunch suggestion
+Lita: How about :hamburger:?
 ```
 
 You can list all stored places:
 
 ```
-lita lunch places
+You: lita lunch places
+Lita: taco hut
+      Korean BBQ
+      :hamburger:
 ```
 
 And remove unwanted places:
 
 ```
-lita lunch remove the taco hut
+You: lita lunch remove the taco hut
+Lita: taco hut has been removed
 ```

data/lib/lita/handlers/lunch.rb

@@ -10,28 +10,27 @@ module Lita
       route(/where should (we|i|they) go for lunch/i, :suggest, command: false)
 
       def suggest(response)
-        index = Random.rand(redis.llen(REDIS_KEY).nonzero? || 1)
-        random = redis.lindex(REDIS_KEY, index) || t('.fallback')
+        random = redis.srandmember(REDIS_KEY) || t('.fallback')
         response.reply t('.suggest', place: random)
       end
 
       def list_suggestions(response)
-        values = redis.lrange(REDIS_KEY, 0, -1)
-        response.reply values.size > 0 ? values.join("\n") : t('.empty')
+        values = redis.smembers(REDIS_KEY)
+        response.reply values.size > 0 ? values.sort.join("\n") : t('.empty')
       end
 
       def add_suggestion(response)
         place = response.matches[0][0].strip
         return if place.empty?
-        redis.rpush(REDIS_KEY, place)
-        response.reply t('.added', place: place)
+        result = redis.sadd(REDIS_KEY, place)
+        response.reply result ? t('.added', place: place) : t('.duplicate', place: place)
       end
 
       def remove_suggestion(response)
         place = response.matches[0][0].strip
         return if place.empty?
-        result = redis.lrem(REDIS_KEY, 0, place)
-        response.reply result.nonzero? ? t('.removed', place: place) : t('.unfound')
+        result = redis.srem(REDIS_KEY, place)
+        response.reply result ? t('.removed', place: place) : t('.unfound')
       end
 
       def reset!

data/lita-lunch.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-lunch"
-  spec.version       = "0.1.2"
+  spec.version       = "0.2.0"
   spec.authors       = ["neilang"]
   spec.email         = ["neilang@gmail.com"]
   spec.description   = "A lita handler to help you pick where to go for lunch"

data/locales/en.yml

@@ -6,5 +6,6 @@ en:
         suggest: "How about %{place}?"
         empty: "None added yet"
         added: "%{place} has been added"
+        duplicate: "I already know about %{place}"
         removed: "%{place} has been removed"
         unfound: "You will need to be more specific"

data/spec/lita/handlers/lunch_spec.rb

@@ -46,10 +46,18 @@ describe Lita::Handlers::Lunch, lita_handler: true do
     end
 
     it 'lists all the known places' do
-      send_command('lunch place add foo')
       send_command('lunch place add bar')
+      send_command('lunch place add foo')
       send_command('lunch places')
-      expect(replies.last).to eq "foo\nbar"
+      expect(replies.last).to eq "bar\nfoo"
+    end
+
+    it 'sorts the places it knows' do
+      send_command('lunch place add Zoo')
+      send_command('lunch place add Avec')
+      send_command('lunch place add Longs')
+      send_command('lunch places')
+      expect(replies.last).to eq "Avec\nLongs\nZoo"
     end
   end
 
@@ -67,6 +75,12 @@ describe Lita::Handlers::Lunch, lita_handler: true do
       send_command('lunch place add  ')
       expect(replies.last).to eq nil
     end
+
+    it 'will not add a duplicate place' do
+      send_command('lunch place add BurgerCzar')
+      send_command('lunch place add BurgerCzar')
+      expect(replies.last).to eq 'I already know about BurgerCzar'
+    end
   end
 
   describe 'removing a place' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-lunch
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - neilang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-13 00:00:00.000000000 Z
+date: 2015-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita