lita-locker 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa2d24a477b73ed08a9db827531634f0c25e45e9
-  data.tar.gz: fbea28bb67b27ef9d94b17e8122a4f6a1792fdb2
+  metadata.gz: 3c181d2f0a0f98745801e7e5647085d1bebd0cd5
+  data.tar.gz: 692c03ba6ee5feb3ca419c1010ab0e8b39d12ed0
 SHA512:
-  metadata.gz: 0e089cb742fb7dc17e0fdb2dfbf7f2ebc29d06511dd123e0b80f7a4ae4ea7a05f7ce23c04e0d24d86e80e1553bf536eb60a2ffd095444661cd42629103fc98e0
-  data.tar.gz: 5678bdf1db5df1b997d286ba8ea9bf7ec298d7165ed49aac6b9adff1973a7185b122f047708ec87b1d1a66e70cbc60c3edd0930c1780de5be30c0f4915bcf8ea
+  metadata.gz: 22fb70292160337860389978c7f238c7528731ad3f315b2fd3229ba8d30af1f0b2da04674a3e95bfe0b5d3c932298da11e431f0295b6438eeb20af18d7f73a35
+  data.tar.gz: 2a79fccde2e153ca3413f52814bfe6a6a95c5abd42297546c14bc1f9eebda16e1372471351557af9f27b60fab5e5f7e0e067afb63b1a727489e30baa0d9803ab

data/.rubocop.yml

@@ -16,3 +16,9 @@ ClassLength:
 
 Metrics/BlockLength:
   Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Lint/UnneededDisable:
+  Enabled: false

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 2.2
   - 2.4
 cache: bundler
 sudo: false

data/lib/lita/handlers/locker_labels.rb

@@ -121,7 +121,7 @@ module Lita
         name = response.match_data['label']
         return response.reply(failed(t('label.does_not_exist', name: name))) unless Label.exists?(name)
         l = Label.new(name)
-        return response.reply(t('label.has_no_resources', name: name)) unless l.membership.count.positive?
+        return response.reply(t('label.has_no_resources', name: name)) unless l.membership.count > 0
         res = []
         l.membership.each do |member|
           res.push(member)

data/lib/lita/handlers/locker_misc.rb

@@ -48,6 +48,8 @@ module Lita
         end
       end
 
+      # rubocop:disable Performance/RedundantMatch
+      # rubocop:disable Performance/RegexpMatch
       def status(response)
         name = response.match_data['label']
         unless name.match(/\*/)
@@ -62,6 +64,8 @@ module Lita
         return response.reply(failed(t('status.does_not_exist', name: name))) if labels.empty?
         response.reply(labels.map { |l| status_label(l) }.join("\n"))
       end
+      # rubocop:enable Performance/RegexpMatch
+      # rubocop:enable Performance/RedundantMatch
 
       def dequeue(response)
         name = response.match_data['label']
@@ -92,7 +96,7 @@ module Lita
       def status_label(name)
         l = Label.new(name)
         return unlocked(t('label.desc', name: name, state: l.state.value)) unless l.locked?
-        if l.wait_queue.count.positive?
+        if l.wait_queue.count > 0
           queue = []
           l.wait_queue.each do |u|
             usr = Lita::User.find_by_id(u)

data/lib/lita/handlers/locker_resources.rb

@@ -116,7 +116,7 @@ module Lita
         return response.reply(t('resource.does_not_exist', name: name)) unless Resource.exists?(name)
         r = Resource.new(name)
         resp = t('resource.desc', name: name, state: r.state.value)
-        if r.labels.count.positive?
+        if r.labels.count > 0
           resp += ', used by: '
           r.labels.each do |label|
             resp += Label.new(label).id

data/lib/locker/label.rb

@@ -95,7 +95,7 @@ module Locker
         log('Unlocked')
 
         # FIXME: Possible race condition where resources become unavailable between unlock and relock
-        if wait_queue.count.positive?
+        if wait_queue.count > 0
           next_user = wait_queue.shift
           lock!(next_user)
         end

data/lita-locker.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'lita-locker'
-  spec.version       = '1.1.1'
+  spec.version       = '1.2.0'
   spec.authors       = ['Eric Sigler']
   spec.email         = ['me@esigler.com']
   spec.description   = '"lock" and "unlock" arbitrary subjects'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-locker
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Eric Sigler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-16 00:00:00.000000000 Z
+date: 2018-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita