lita-jira 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eca25015401127d628654b155f01c2186adee367
-  data.tar.gz: 8ecded11919390a55da963235b9b7eeb9f272382
+  metadata.gz: 60daa5d9457d96452b4a5173475ea8d0100e3599
+  data.tar.gz: dbe9dd305a9fb2d16131f3aadbd45de6371d60cf
 SHA512:
-  metadata.gz: f736bd91ff2ff195ec600a289f44b1d58397b6eb874643597b4f6fd024c6e6c3fb053eccdc0175f0952354e2ae809ffe63f3a50923bbe9299f3e017daba4de69
-  data.tar.gz: dd89520f0235451055bd7243b011aabf3d65ec6a0334b1937e9139032ff9a5bf14956fd69f38ba137daa734f4ee67e5ae0edab4523ff02b703c1750a626bea83
+  metadata.gz: 26a7c84e39b53e8efd70fa120b1917f6662df89162b947d2e8cb5b9c2f1048550c8e85a70deebb79d5f8583daff6d42465b6c71cf9d9a059b11afcace65f12ba
+  data.tar.gz: 75e000b407485a88e511940c8aeacae0264914196de243fc6f1ba3643756d3414e996d632a3d639500b1571c3b4f3f4d25bf28a047993aa58b98cb33ecbc0266

data/.rspec

@@ -0,0 +1 @@
+--color --profile 5

data/CHANGELOG.md

@@ -0,0 +1,16 @@
+# CHANGELOG
+
+All notable changes to this project will be documented in this file.
+This project adheres to [Semantic Versioning] and [Keep A Changelog].
+
+## [Unreleased]
+
+## [0.7.2] - 2015-12-01
+### Fixed
+- Updated Simplecov invocation to newer style
+- Adjusted ambient issue detection to avoid triggering on URL-like strings
+
+[Unreleased]: https://github.com/esigler/lita-jira/compare/v0.7.2...HEAD
+[0.7.2]: https://github.com/esigler/lita-jira/compare/v0.7.1...v0.7.2
+[Semantic Versioning]: http://semver.org/
+[Keep A Changelog]: http://keepachangelog.com/

data/lib/jirahelper/regex.rb

@@ -8,5 +8,6 @@ module JiraHelper
     PROJECT_PATTERN = /(?<project>[a-zA-Z0-9]{1,10})/
     ISSUE_PATTERN   = /(?<issue>#{PROJECT_PATTERN}-[0-9]{1,5}+)/
     EMAIL_PATTERN   = /(?<email>[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+)/i
+    AMBIENT_PATTERN = /\s#{ISSUE_PATTERN}/
   end
 end

data/lib/lita/handlers/jira.rb

@@ -67,7 +67,7 @@ module Lita
       )
 
       # Detect ambient JIRA issues in non-command messages
-      route ISSUE_PATTERN, :ambient, command: false
+      route AMBIENT_PATTERN, :ambient, command: false
 
       def summary(response)
         issue = fetch_issue(response.match_data['issue'])

data/lita-jira.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-jira'
-  spec.version       = '0.7.1'
+  spec.version       = '0.7.2'
   spec.authors       = ['Eric Sigler', 'Matt Critchlow']
   spec.email         = ['me@esigler.com', 'matt.critchlow@gmail.com']
   spec.description   = 'A JIRA plugin for Lita.'

data/spec/lita/handlers/jira_spec.rb

@@ -180,8 +180,7 @@ describe Lita::Handlers::Jira, lita_handler: true do
   end
 
   describe '#ambient' do
-    it 'does not show details for a detected issue by default' do
-    end
+    it 'does not show details for a detected issue by default'
 
     context 'when enabled in config' do
       before(:each) do
@@ -191,7 +190,8 @@ describe Lita::Handlers::Jira, lita_handler: true do
 
       it 'shows details for a detected issue in a message' do
         send_message('foo XYZ-987 bar')
-        expect(replies.last).to eq("[XYZ-987] Some summary text\nStatus: In Progress, assigned to: A Person, fixVersion: Sprint 2, priority: P0\nhttp://jira.local/browse/XYZ-987")
+        send_message('foo XYZ-987?')
+        expect(replies.size).to eq(2)
       end
 
       it 'does not show details for a detected issue in a command' do
@@ -199,6 +199,12 @@ describe Lita::Handlers::Jira, lita_handler: true do
         expect(replies.size).to eq(0)
       end
 
+      it 'does not show details for a issue in a URL-ish context' do
+        send_message('http://www.example.com/XYZ-987.html')
+        send_message('http://www.example.com/someother-XYZ-987.html')
+        expect(replies.size).to eq(0)
+      end
+
       context 'and an ignore list is defined' do
         before(:each) do
           @user1 = Lita::User.create('U1', name: 'User 1', mention_name: 'user1')

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'simplecov'
 require 'coveralls'
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+SimpleCov.formatters = [
   SimpleCov::Formatter::HTMLFormatter,
   Coveralls::SimpleCov::Formatter
 ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-jira
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Eric Sigler
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2015-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -132,8 +132,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE