lita-jira-issues 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e95a4831033d91c23789d7acd01976b7ad7772a8
-  data.tar.gz: 824e1d5b8dad51e051a317d79ef02f1057a28c57
+  metadata.gz: 5289a8db7eaaeaec996dae6be0bb5d87fb692c6c
+  data.tar.gz: 175e27ae92770ae373629b85300cff41e978d558
 SHA512:
-  metadata.gz: 0a74037ccfcce383aba01ab2ed0536492e3e436a4a54ed19a8adf0e2f24ea219f9d14994b4f2e8e675714b9ed0cbcedc2680cc3783fa71a60b44b5c362d5d5c8
-  data.tar.gz: af2817980dafb19f46eaabb0c3162c88635a81d19b5d5fd90a927e8831592031e1909f9a473e2be31202735a611d7e324eb398eea75a271b38ff4810417e190e
+  metadata.gz: 2d1b42b22ed8a1474faf9a08af9e945b258500c7262ee4e6d46ad426bdbf7764c5ef79797a029d0303db41eacb6b011ee9dc7d88142ae05f0fa35fcf8b05f4ac
+  data.tar.gz: 3c421fa192c00a884798d3f111941a3f2e9311e82a3e081c06af4420d6c60c5af652662d0ac1f802b061fd55ec3a5a187ceb97d5bbe816c4313d9c651a43e31c

data/lib/lita/handlers/jira_issues.rb

@@ -1,4 +1,5 @@
 require_relative 'jira_gateway'
+require 'set'
 
 module Lita
   module Handlers
@@ -14,7 +15,7 @@ module Lita
 
       def jira_message(response)
         @jira ||= JiraGateway.new(http, config)
-        response.matches.each do | key |
+        Set.new(response.matches).each do | key |
           handle_key(response, key)
         end
       end

data/lita-jira-issues.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-jira-issues"
-  spec.version       = "0.2.0"
+  spec.version       = "0.2.1"
   spec.authors       = ["Arthur Maltson"]
   spec.email         = ["arthur@maltson.com"]
   spec.description   = "Lita handler to show JIRA issue details"

data/spec/lita/handlers/jira_issues_spec.rb

@@ -41,6 +41,38 @@ http://jira.local/browse/KEY-424
     end
 
     it 'it should reply with multiple JIRA descriptions if many seen' do
+      mock_multiple_jiras
+      send_message('Some PROJ-9872 message nEw-1 more text')
+      expect(replies.pop).to eq(<<-EOS.chomp
+[NEW-1] New 1
+Status: Open, unassigned, rep. by User2, fixVersion: NONE, priority: High
+http://jira.local/browse/NEW-1
+                                EOS
+                               )
+      expect(replies.pop).to eq(<<-EOS.chomp
+[PROJ-9872] Too many bugs
+Status: Resolved, unassigned, rep. by User, fixVersion: NONE
+http://jira.local/browse/PROJ-9872
+                                EOS
+                               )
+    end
+
+    it 'it should reply once for each seen JIRA issue' do
+      mock_multiple_jiras
+      send_message(
+        'Some PROJ-9872 message nEw-1 more text with PROJ-9872 mentioned')
+      expect(replies.size).to eq(2)
+      expect(replies.pop).to include('[NEW-1] New 1')
+      expect(replies.pop).to include('[PROJ-9872] Too many bugs')
+    end
+
+    def mock_jira(key, result)
+      allow_any_instance_of(JiraGateway).to receive(:data_for_issue)
+        .with(key)
+        .and_return(result)
+    end
+
+    def mock_multiple_jiras
       mock_jira('PROJ-9872',
                 {key:'PROJ-9872',
                  fields: {
@@ -66,26 +98,6 @@ http://jira.local/browse/KEY-424
                   fixVersions: [],
                   priority: { name: 'High' }
                 }})
-
-      send_message('Some PROJ-9872 message nEw-1 more text')
-      expect(replies.pop).to eq(<<-EOS.chomp
-[NEW-1] New 1
-Status: Open, unassigned, rep. by User2, fixVersion: NONE, priority: High
-http://jira.local/browse/NEW-1
-                                EOS
-                               )
-      expect(replies.pop).to eq(<<-EOS.chomp
-[PROJ-9872] Too many bugs
-Status: Resolved, unassigned, rep. by User, fixVersion: NONE
-http://jira.local/browse/PROJ-9872
-                                EOS
-                               )
-    end
-
-    def mock_jira(key, result)
-      allow_any_instance_of(JiraGateway).to receive(:data_for_issue)
-        .with(key)
-        .and_return(result)
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-jira-issues
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Arthur Maltson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-30 00:00:00.000000000 Z
+date: 2014-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita