lita-hipchat 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e89f7ec49f80d0ec744dee829115f6f0f679979a
-  data.tar.gz: 1320411df7e3435973f6e86ed861e113f84f3bf6
+  metadata.gz: 3afeeed54c6b3093fd68a764bdda47a6d925ce4e
+  data.tar.gz: 4bc84ba99ea9bf19751559e8532e8d2d2816da21
 SHA512:
-  metadata.gz: 6dd4f4d590969bb40e15b09fe7d8810b1eb02781921adfb275ae44a576abb4256c35be0abf6fa9b54926d863e9a26eee7339ed2de54606abefa902c842d981c4
-  data.tar.gz: d65bf267d3358c42b9e444dd1eb4bb7a1b1856575761bc7b3d370ea6437a31fe48eeb24fe68124f25d81c8e3d9a3666e2c1cc1b83f1bfa62a6bb8fcfb3f6a46b
+  metadata.gz: af847c34127057fe05a209e1f3131887f18b7b04da82472f15af56dbb4c893106fc77abc10650fd72530a8cb0cf680795de6a9b3dfd8dfea07458488e31389dd
+  data.tar.gz: 80c197bae7c7b5d1740b82b16e45bacd9115481892dd498acff094a3214e25a14468331f533b131da0a8b8554c1105c7a7dc42fae3e52dfb31ba333193630af8

data/README.md

@@ -28,6 +28,7 @@ Values for all of the following attributes can be found on the "XMPP/Jabber info
 * `debug` (Boolean) - If `true`, turns on the underlying Jabber library's (xmpp4r) logger, which is fairly verbose. Default: `false`.
 * `rooms` (Symbol, Array<String>) - An array of room JIDs that Lita should join upon connection. Can also be the symbol `:all`, which will cause Lita to discover and join all rooms. Default: `nil` (no rooms).
 * `muc_domain` (String) - The XMPP Multi-User Chat domain to use. Default: `"conf.hipchat.com"`.
+* `ignore_unknown_users` (Boolean) - Messages generated through HipChat's API which don't come from a real user account will be ignored by the robot. With the default setting of false, Lita will emit a warning but the message will be dispatched to any registered handlers as usual. Default: `false`.
 
 **Note: You must set the robot's name to the value shown as "Room nickname" on the XMPP settings page.**
 

data/lib/lita/adapters/hipchat/callback.rb

@@ -24,6 +24,7 @@ module Lita
         def muc_message(muc)
           muc.on_message do |time, nick, text|
             user = user_by_name(nick)
+            return unless user
             source = Source.new(user: user, room: muc.jid.bare.to_s)
             message = Message.new(robot, text, source)
             Lita.logger.debug(
@@ -62,8 +63,8 @@ module Lita
           items = roster.items.detect { |jid, item| item.iname == name }
           if items
             user_by_jid(items.first)
-          else
-            Lita.logger.warn <<-MSG
+          elsif !Lita.config.adapter.ignore_unknown_users
+            Lita.logger.warn <<-MSG.chomp
 No user with the name #{name.inspect} was found in the roster. The message may
 have been generated from the HipChat API. A temporary user has been created for
 this message, but Lita will not be able to reply.

data/lita-hipchat.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-hipchat"
-  spec.version       = "1.4.0"
+  spec.version       = "1.5.0"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A HipChat adapter for Lita.}

data/spec/lita/adapters/hipchat/callback_spec.rb

@@ -92,6 +92,13 @@ describe Lita::Adapters::HipChat::Callback, lita: true do
       expect(robot).to receive(:receive).with(message)
       subject.muc_message(muc)
     end
+
+    it "ignores messages from unknown users if the config for it is set" do
+      Lita.config.adapter.ignore_unknown_users = true
+      allow(muc).to receive(:on_message).and_yield(nil, "Unknown", "foo")
+      expect(robot).not_to receive(:receive)
+      subject.muc_message(muc)
+    end
   end
 
   describe "#roster_update" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-hipchat
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-11 00:00:00.000000000 Z
+date: 2014-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita