lita-hipchat 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ec7ba5ac4abe138d28e1bd36a4558f813d7fb5b
-  data.tar.gz: e46480f1c832145e7600b534032152f45cdaadb7
+  metadata.gz: e46baadbd74d9736fff4fc3b2e6818368ee0c3f7
+  data.tar.gz: 11c4b886551405419725a94a4dbe6a02bf0be1a4
 SHA512:
-  metadata.gz: d5eff11e4b7489853069890d99420e72f7c01969bdc4f631b69dc7202eeb10250357de6dffe5f9a4051672ecfedb9852608de7c0bfc938427ed62cb9b6ad0e46
-  data.tar.gz: 9441c86938d6beed4b511af951e637aa139addc0eacce13e1c0c798b969dd568640c6e51205f1cd47cebd0d4f3a3f6b647f5c841cb404b5fd0695d1b20c9d72c
+  metadata.gz: aedf688fccc504e8d5706c3a85e9a0977f261af1a037ca72fa7cef9c50304a280f5d33e8787f3ec14d755b291338274afc9eb008e9b179c5f8ef5d5e7406bc5b
+  data.tar.gz: 35e3caa0ddce480ef049d6f23238704a8b364d0b8b85c9d1d678a876c85bdd4b12a2cd5344fb22bb82edd5e51e848e5c6f52013f512a91d49e6fb8a7b26b2f5d

data/lib/lita/adapters/hipchat/callback.rb

@@ -58,8 +58,17 @@ module Lita
 
         def user_by_name(name)
           Lita.logger.debug("Looking up user with name: #{name}.")
-          jid = roster.items.detect { |jid, item| item.iname == name }.first
-          user_by_jid(jid)
+          items = roster.items.detect { |jid, item| item.iname == name }
+          if items
+            user_by_jid(items.first)
+          else
+            Lita.logger.warn <<-MSG
+No user with the name #{name.inspect} was found in the roster. The message may
+have been generated from the HipChat API. A temporary user has been created for
+this message, but Lita will not be able to reply.
+MSG
+            User.new(nil, name: name)
+          end
         end
       end
     end

data/lita-hipchat.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-hipchat"
-  spec.version       = "1.0.0"
+  spec.version       = "1.0.1"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A HipChat adapter for Lita.}
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", ">= 2.14.0.rc1"
+  spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "coveralls"
 end

data/spec/lita/adapters/hipchat/callback_spec.rb

@@ -91,6 +91,22 @@ describe Lita::Adapters::HipChat::Callback, lita: true do
       expect(robot).to receive(:receive).with(message)
       subject.muc_message(muc)
     end
+
+    it "creates a temporary source user if the JID isn't in the roster" do
+      roster = double("Jabber::Roster::Helper", items: {})
+      allow(muc).to receive(:on_message).and_yield(nil, "Unknown", "foo")
+      allow(Lita::Source).to receive(:new).with(
+        an_instance_of(Lita::User),
+        "room_id"
+      ).and_return(source)
+      allow(Lita::Message).to receive(:new).with(
+        robot,
+        "foo",
+        source
+      ).and_return(message)
+      expect(robot).to receive(:receive).with(message)
+      subject.muc_message(muc)
+    end
   end
 
   describe "#roster_update" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-hipchat
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-06 00:00:00.000000000 Z
+date: 2013-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -70,16 +70,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0.rc1
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0.rc1
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement