lita-hcadmin 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a305e9389b1108f8c4a4eaa5194562339a73c7de
-  data.tar.gz: f5bb648d9b55d44c9efde3787229d63cac9b65b4
+  metadata.gz: fc34b2696ab300c6bed1244ed01dc01669cc8c1d
+  data.tar.gz: 95840dec11fcb76abc0fa97e04404557384dc2f1
 SHA512:
-  metadata.gz: ee4b47126ad575be01d78c78c262e3c561fefc4e3b75dc4abe14bc8b3fb097dc8d1bc04f069ad584e8bf55729e25f205ea222a0aa3f11d71e60cb74ba3a03070
-  data.tar.gz: 227e4c67e7e9185b2f6ad0c028136b17f424f4a17907a4a02409fbc30779d3cb2ba600a4077cf218f5308bc8e3f6e170d02622b87d0385ff69db439fa18cc45e
+  metadata.gz: 77fa03c6b253ebc43344c803f928bc53d34d7fe4e03f2ef93a670ed2b179aa05f7999ed2ead110c87a4e2a89d616d3fb04d059e95c184d393a9df512f4c816a6
+  data.tar.gz: c33814a51cf56658ba0d516c09f6a7a36ca3497110404ebbefb02c8e092d3c315532e51568737c2990d053cfff6226da8a5206b0b02aaf8696db17effbdd23c9

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # lita-hcadmin
 
+[0.4.5]
+---------
+- [desktophero] - Update tests to use `subject` and objects to validate private methods
+
 [0.4.4]
 ---------
 - [desktophero] - User invite as a discrete route

data/lita-hcadmin.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-hcadmin"
-  spec.version       = "0.4.4"
+  spec.version       = "0.4.5"
   spec.authors       = ["Jason Walker"]
   spec.email         = ["jason.walker@target.com"]
   spec.description   = "HipChat admin plugin for Lita"

data/spec/lita/handlers/hcadmin_spec.rb

@@ -272,6 +272,30 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
         body: user_v2_not_found,
         headers: {}
       )
+    stub_request(:get, 'https://api.hipchat.com/v2/user/dummy.account@company.com?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_v2_json,
+        headers: {}
+      )
+    stub_request(:get, 'https://api.hipchat.com/v2/user/valid_user@company.com?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_v2_json,
+        headers: {}
+      )
   end
 
   it 'routes the identify room owner command room name has spaces' do
@@ -338,12 +362,6 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
       end
     end
     context 'hipchat account exists' do
-      before(:each) do
-        stub_request(:get, 'https://api.hipchat.com/v2/user/dummy.account@company.com?auth_token=abc&format=json')
-          .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
-          .to_return(status: 200, body: user_v2_json, headers: {})
-      end
-
       it 'responds that the user exists if an ID is found' do
         send_command('hipchat sponsor dummy.account@company.com')
         expect(replies.last).to eq('The email address of dummy.account@company.com already has an account on TestHipChatAccount of 11')
@@ -426,18 +444,16 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
   end # end identify_status
 
   describe '#email_domain_name' do
+    let(:email_domain_test) { subject.send(:email_domain_name) }
     context 'valid email domains are validated' do
-      before(:each) do
-        allow(described_class).to receive(:email_domain_name).and_return(Lita.config.handlers.hcadmin.email_domain_name)
-      end
       it 'returns the approved email domains' do
-        expect(described_class.email_domain_name).to include('@company.com') # individual strings
-        expect(described_class.email_domain_name).to include('@network.net')
-        expect(described_class.email_domain_name).to include('@company.com', '@network.net') # multiple strings
+        expect(email_domain_test).to include('@company.com') # individual strings
+        expect(email_domain_test).to include('@network.net')
+        expect(email_domain_test).to include('@company.com', '@network.net') # multiple strings
       end
 
       it 'does not include email domains outside of the config' do
-        expect(described_class.email_domain_name).to_not include('@dummycorp.com')
+        expect(email_domain_test).to_not include('@dummycorp.com')
       end
     end
   end # end email_domain_name
@@ -468,28 +484,23 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
     end
 
     context 'fetches JSON payload of users from the HipChat API' do
-      before(:each) do
-        allow(described_class).to receive(:fetch_user).with(2_341_755).and_return(user_json)
-      end
-
+      let(:fetch_a_user_v1) { subject.send(:fetch_user, 2_341_755) }
       it 'returns JSON payload on fetch user commands' do
-        expect(described_class.fetch_user(2_341_755)).to eq user_json
+        # expect(subject.fetch_user(2_341_755)).to eq user_json
+        expect(fetch_a_user_v1[:body]).to eq user_json
       end
     end
 
     context 'fetches JSON payload of a user through the V2 api' do
-      before(:each) do
-        allow(described_class).to receive(:fetch_user_v2).with('valid_user@company.com').and_return(user_v2_json)
-      end
+      let(:fetch_a_user_v2) { subject.send(:fetch_user_v2, 'valid_user@company.com') }
       it 'returns JSON of the requested user' do
-        expect(described_class.fetch_user_v2('valid_user@company.com')).to eq user_v2_json
+        expect(fetch_a_user_v2[:body]).to eq user_v2_json
       end
     end
   end # end fetch
 
   describe '#parse' do
     let(:test_room_data) { subject.parse(room_json, 'rooms') }
-
     context 'JSON data from parse should return a JSON object' do
       it 'gets a JSON object during parse' do
         expect(test_room_data.first['room_id']).to eq(31)

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: lita-hcadmin
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Jason Walker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-04 00:00:00.000000000 Z
+date: 2016-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: HipChat admin plugin for Lita
@@ -115,10 +115,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.md
@@ -155,17 +155,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Allow your HipChat admins to interact with the HipChat APIs
@@ -185,3 +185,4 @@ test_files:
 - spec/fixtures/v2_user_not_found.json
 - spec/lita/handlers/hcadmin_spec.rb
 - spec/spec_helper.rb
+has_rdoc: