lita-group-mention 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: efbaf75891c9fffbcf0128ace58f236f95eac9ac
-  data.tar.gz: fd7fdccc2b72a44b3f4e3b5004b1875123bc8c37
+  metadata.gz: b9ac329417c7e01f175785c789205c519fb892e6
+  data.tar.gz: 8d9e3288a0fb0b7e15468e91a016e50a865882db
 SHA512:
-  metadata.gz: 2589abd6c7791bdb06bdfc475195b5bfdc51e56348d8196421d515abd66acdbbb02c8a502ccc395c9b472f33b38d451a6180cb79450c71b39c5d32ad038d8af8
-  data.tar.gz: 8ff5b0abf568e029d8fdc52ba9f1f81395f3a7551ceefc89c493a7954c4c58d40774598f13053c42759e4dd1bb39c2b0a06aeb685654e568e7ff0bf796db48f6
+  metadata.gz: f07ed4e3a0c9f8492fad753902967f7d7c5124d9439a4903fd596ef742bcb44536685a309421f07f445f9079d02dad8222eb594958f01ebcac5f8d75ee878781
+  data.tar.gz: 45257a19b3a2897427a25d418b90d2abdefb036258d183b013da35afe6be0b6a93b35fd74ba5b90b54998820009c75eec35b6ac660776a9defaa8c83f8b7ae32

data/lib/lita/handlers/group_mention.rb

@@ -56,10 +56,7 @@ module Lita
       def group_mention(response) # rubocop:disable AbcSize
         return if response.message.body =~ /group\s+mention/
         groups = response.matches.flatten
-
-        groups.each do |g|
-          groups.delete(g) unless redis_groups.keys.include?(g)
-        end
+        groups.reject! { |g| !redis_groups.keys.include?(g) }
         return if groups.empty?
 
         response.reply(t('mention.cc') + union_members(groups))

data/lita-group-mention.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-group-mention'
-  spec.version       = '1.0.1'
+  spec.version       = '1.0.2'
   spec.authors       = ['Ben House']
   spec.email         = ['ben@benhouse.io']
   spec.description   = 'cc a list of users when a group is @mentioned'

data/spec/lita/handlers/group_mention_spec.rb

@@ -129,4 +129,11 @@ describe Lita::Handlers::GroupMention, lita_handler: true do
       )
     end
   end
+
+  context 'sending a message with multiple mentions of non-groups' do
+    it "doesn't respond with a cc" do
+      send_message('Hello @user1 @user2')
+      expect(replies.last).not_to match(/^cc/)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-group-mention
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Ben House
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-08 00:00:00.000000000 Z
+date: 2015-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita