lita-google-images 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e493620aeca3ed039ad38d944ea1323ccaf430cd
-  data.tar.gz: 534ace49b550eb3eaf6b214432832bbb22248684
+  metadata.gz: 70de47b530e136b71b4cc669084d261366860c42
+  data.tar.gz: 326ee33d20ebfeb13276ab39036cd3bb13de1a11
 SHA512:
-  metadata.gz: 349a8db7a9781211ef23b8ceac4bf77e72ba40335f7f80569e59ec475d49160ca3f4f9dbe9a5aea728890bddeda0f9cfc9329ad5cc64d01faf2ebe00f65bd7b4
-  data.tar.gz: 88ed4d13765e10de95ba9731cbb10a7cadf3190121cb92386c65e13df9ec70f864f6fb102843a1fd8ebd137bf359054d87dd5e4a1d3b76e0e8dbdeade9474072
+  metadata.gz: 0ffdffd8175cf3bde9e0fc3df978824ac39b7f24c596e19f68f78cb59ebdb802be9ecdc15e14976128f3a14ab576f7d534e9653298e166b33ddf2707e88813aa
+  data.tar.gz: 91eb3377b4dfb204225be6c71334cd68285ce0c5bb462c2a86d1de4be304db257b66c18a9f550eac179fb199ebb4838ca653227a3e6dda519f4b9fc1c11caa98

data/lib/lita/handlers/google_images.rb

@@ -29,7 +29,7 @@ module Lita
         if data["responseStatus"] == 200
           choice = data["responseData"]["results"].sample
           if choice
-            response.reply "#{choice["unescapedUrl"]}#.png"
+            response.reply ensure_extension(choice["unescapedUrl"])
           else
             response.reply %{No images found for "#{query}".}
           end
@@ -43,6 +43,14 @@ module Lita
 
       private
 
+      def ensure_extension(url)
+        if [".gif", ".jpg", ".jpeg", ".png"].any? { |ext| url.end_with?(ext) }
+          url
+        else
+          "#{url}#.png"
+        end
+      end
+
       def safe_value
         safe = Lita.config.handlers.google_images.safe_search || "active"
         safe = safe.to_s.downcase

data/lita-google-images.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-google-images"
-  spec.version       = "1.0.4"
+  spec.version       = "1.0.5"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A Lita handler for fetching images from Google.}

data/spec/lita/handlers/google_images_spec.rb

@@ -17,6 +17,26 @@ describe Lita::Handlers::GoogleImages, lita_handler: true do
 
     it "replies with a matching image URL on success" do
       allow(response).to receive(:body).and_return(<<-JSON.chomp
+{
+  "responseStatus": 200,
+  "responseData": {
+    "results": [
+      {
+        "unescapedUrl": "http://www.example.com/path/to/an/image"
+      }
+    ]
+  }
+}
+JSON
+      )
+      send_command("image carl")
+      expect(replies.last).to eq(
+        "http://www.example.com/path/to/an/image#.png"
+      )
+    end
+
+    it "doesn't append a fake file extension if the image URL has a common image extension" do
+      allow(response).to receive(:body).and_return(<<-JSON.chomp
 {
   "responseStatus": 200,
   "responseData": {
@@ -31,7 +51,7 @@ JSON
       )
       send_command("image carl")
       expect(replies.last).to eq(
-        "http://www.example.com/path/to/an/image.jpg#.png"
+        "http://www.example.com/path/to/an/image.jpg"
       )
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-google-images
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -140,4 +140,3 @@ summary: A Lita handler for fetching images from Google.
 test_files:
 - spec/lita/handlers/google_images_spec.rb
 - spec/spec_helper.rb
-has_rdoc: