lita-github 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ece12c721d1b5311529352629acae15998e6d487
-  data.tar.gz: 32877ccdac63d11a2ce09a1afe9368ad6a3000a4
+  metadata.gz: bb3cd200b9fc34080456111f08e27e79a3297311
+  data.tar.gz: eedcd297373ba3f19afe00e3ef460e8cf9248829
 SHA512:
-  metadata.gz: d1baca6ba8a93e75740a0923e2e80947c01c175ca49acff466475247dae4d11357e4f2a21eab3cc24492b823ff394265a8de33e09aeaebe038c9d9de50ea2b4a
-  data.tar.gz: 5c1a9c8fa5d8edfe12c17f082211e7de4db1a36705fad6a0247c3807d586aa549ab3eb027385ac15ebe6617a59643ac795a9194c4d512de0c6034f6c287a363b
+  metadata.gz: dfb028a7d353c084a53a9f9ed6c0811dc78850cad2eaf58f74cb00ab87be8d4f3cecb613a5369d3957ac237822c2207fd1d1af0dbce079c927018d11c1a949ef
+  data.tar.gz: 85f39a45bf8bc5e1b0a1b1308472e8dc5bf5a33c9033691b98ac30876813c36779246786a4cf5300766054db16d712981ace7bcd4143263ca6ced2d60b98c37c

data/.rubocop.yml

@@ -12,3 +12,7 @@ Metrics/LineLength:
   Max: 120
 Metrics/MethodLength:
   Max: 30
+
+# pending: https://github.com/bbatsov/rubocop/issues/1332
+Style/GuardClause:
+  Enabled: false

data/README.md

@@ -57,6 +57,12 @@ Here is the current functionality:
 * `!gh repo delete PagerDuty/lita-github`
   * Deletes the repo you specify, requires confirmation before doing so
   * **Note:** This method is disabled by default, you need to enable it by setting `config.handlers.github.repo_delete_enabled = true` in your configuration file
+* `!gh repo teams PagerDuty/lita-github`
+  * list all of the teams currently attached to a repo
+* `!gh repo team add <TEAM_ID|TEAM_SLUG> PagerDuty/lita-github`
+  * adds the team to the repo -- requires confirmation and enabling via config option (`repo_team_add_enabled = true`)
+* `!gh repo team rm <TEAM_ID|TEAM_SLUG> PagerDuty/lita-github`
+  * removes the team to the repo -- requires confirmation and enabling via config option (`repo_team_rm_enabled = true`)
 
 ### Github PR Handler
 * `!gh pr info PagerDuty/lita-github #42`
@@ -66,3 +72,7 @@ Here is the current functionality:
   * This method can be disabled by setting `config.handlers.github.pr_merge_enabled = false` in your configuration file
 * `!gh pr list PagerDuty/lita-github`
   * list the open pull requests on a repo
+
+### Github Organization Handler
+* `!gh org teams PagerDuty` & `!gh teams PagerDuty`
+  * list the teams for the GitHub repo

data/lib/lita-github.rb

@@ -24,3 +24,4 @@ require 'lita-github/version'
 require 'lita/handlers/github'
 require 'lita/handlers/github_repo'
 require 'lita/handlers/github_pr'
+require 'lita/handlers/github_org'

data/lib/lita-github/org.rb

@@ -20,5 +20,9 @@ module LitaGithub
     def organization(name)
       name.nil? || name.empty? ? config.default_org : name
     end
+
+    def sort_by_name(teams)
+      teams.sort_by { |h| h[:name].downcase }
+    end
   end
 end

data/lib/lita-github/repo.rb

@@ -27,9 +27,13 @@ module LitaGithub
       octo.repository?(r)
     end
 
-    def repo_match(response)
-      md = response.match_data
+    def repo_match(md)
       [organization(md['org']), md['repo']]
     end
+
+    def repo_has_team?(full_name, team_id)
+      octo.repository_teams(full_name).each { |t| return true if t[:id] == team_id }
+      false
+    end
   end
 end

data/lib/lita-github/version.rb

@@ -16,6 +16,6 @@
 
 # Administer your Hub of Gits with Lita!
 module LitaGithub
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
   MAJ, MIN, REV = VERSION.split('.').map(&:to_i)
 end

data/lib/lita/handlers/github.rb

@@ -70,8 +70,10 @@ module Lita
         config.totp_secret = nil
 
         # Lita::Handlers::GithubRepo
-        config.repo_create_enabled = true
-        config.repo_delete_enabled = false
+        config.repo_create_enabled    = true
+        config.repo_delete_enabled    = false
+        config.repo_team_add_enabled  = false
+        config.repo_team_rm_enabled   = false
 
         # Lita::Handlers::GithubPR
         config.pr_merge_enabled = true

data/lib/lita/handlers/github_org.rb

@@ -0,0 +1,70 @@
+# -*- coding: UTF-8 -*-
+#
+# Copyright 2014 PagerDuty, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'lita-github/r'
+require 'lita-github/config'
+require 'lita-github/octo'
+require 'lita-github/org'
+
+module Lita
+  # Lita Handler
+  module Handlers
+    # GitHub Lita Handler
+    class GithubOrg < Handler
+      include LitaGithub::Config  # Github handler Lita configuration methods
+      include LitaGithub::Octo    # Github handler common-use Octokit methods
+      include LitaGithub::Org     # Github handler common-use Organization methods
+
+      on :loaded, :setup_octo # from LitaGithub::Octo
+
+      # rubocop:disable Metrics/LineLength
+      route(
+        /#{LitaGithub::R::A_REG}(?:teams|org\s+?teams|org\s+?team\s+?list)(?<org>\s+[a-zA-Z0-9_\-]+)?/,
+        :org_teams_list,
+        command: true,
+        help: {
+          'gh org teams [organization]' => 'show all teams of an organization',
+          'gh teams [organization]' => 'an alias for gh org teams'
+        }
+      )
+      # rubocop:enable Metrics/LineLength
+
+      def org_teams_list(response)
+        md = response.match_data
+        org = md[:org].nil? ? config.default_org : organization(md[:org].strip)
+
+        begin
+          teams = octo.organization_teams(org)
+        rescue Octokit::NotFound
+          return response.reply(t('org_not_found', org: org))
+        end
+
+        tl = teams.length
+
+        o = teams.shift
+
+        reply = t('org_teams_list.header', org: org, num_teams: tl)
+        reply << t('org_teams_list.team', o.to_h)
+
+        sort_by_name(teams).each { |team| reply << t('org_teams_list.team', team.to_h) }
+
+        response.reply(reply)
+      end
+    end
+
+    Lita.register_handler(GithubOrg)
+  end
+end

data/lib/lita/handlers/github_pr.rb

@@ -63,7 +63,7 @@ module Lita
       # rubocop:disable Metrics/CyclomaticComplexity
       # rubocop:disable Metrics/PerceivedComplexity
       def pr_info(response)
-        org, repo, pr = pr_match(response)
+        org, repo, pr = pr_match(response.match_data)
         full_name = rpo(org, repo)
 
         pr_h = pull_request(full_name, pr)
@@ -82,7 +82,7 @@ module Lita
 
       def pr_merge(response)
         return response.reply(t('method_disabled')) if func_disabled?(__method__)
-        org, repo, pr = pr_match(response)
+        org, repo, pr = pr_match(response.match_data)
         fullname = rpo(org, repo)
 
         pr_h = pull_request(fullname, pr)
@@ -107,7 +107,7 @@ module Lita
       # rubocop:enable Metrics/PerceivedComplexity
 
       def pr_list(response)
-        org, repo = repo_match(response)
+        org, repo = repo_match(response.match_data)
         full_name = rpo(org, repo)
         reply = ''
 
@@ -132,8 +132,7 @@ module Lita
 
       private
 
-      def pr_match(response)
-        md = response.match_data
+      def pr_match(md)
         [organization(md['org']), md['repo'], md['pr']]
       end
 

data/lib/lita/handlers/github_repo.rb

@@ -63,10 +63,33 @@ module Lita
         }
       )
 
+      route(
+        /#{LitaGithub::R::A_REG}repo\s+?(teams|team\s+?list)\s+?#{LitaGithub::R::REPO_REGEX}/,
+        :repo_teams_list,
+        command: true,
+        help: {
+          'gh repo teams PagerDuty/lita-github' => 'list the teams allowed to to access a repo',
+          'gh repo team list PagerDuty/lita-github' => 'list the teams allowed to to access a repo'
+        }
+      )
+
+      # rubocop:disable Metrics/LineLength
+      route(
+        /#{LitaGithub::R::A_REG}repo\s+?team\s+?(?<action>add|rm)\s+?(?<team>[a-zA-Z0-9_\-]+?)(\s+?to)?\s+?#{LitaGithub::R::REPO_REGEX}/,
+        :repo_team_router, command: true, confirmation: true,
+        help: {
+          'gh repo team add everyone PagerDuty/lita-test' => 'add a team using slug to your repo',
+          'gh repo team add 42 PagerDuty/lita-test' => 'add a team using ID to your repo',
+          'gh repo team rm everyone PagerDuty/lita-test' => 'remove a team using slug to your repo',
+          'gh repo team rm 42 PagerDuty/lita-test' => 'remove a team using ID to your repo'
+        }
+      )
+      # rubocop:enable Metrics/LineLength
+
       def repo_create(response)
         return response.reply(t('method_disabled')) if func_disabled?(__method__)
 
-        org, repo = repo_match(response)
+        org, repo = repo_match(response.match_data)
 
         if repo?(rpo(org, repo))
           return response.reply(t('repo_create.exists', org: org, repo: repo))
@@ -80,15 +103,15 @@ module Lita
       def repo_delete(response)
         return response.reply(t('method_disabled')) if func_disabled?(__method__)
 
-        org, repo = repo_match(response)
+        org, repo = repo_match(response.match_data)
 
-        return response.reply(t('repo_delete.not_found', org: org, repo: repo)) unless repo?(rpo(org, repo))
+        return response.reply(t('not_found', org: org, repo: repo)) unless repo?(rpo(org, repo))
 
         response.reply(delete_repo(org, repo))
       end
 
       def repo_info(response)
-        org, repo = repo_match(response)
+        org, repo = repo_match(response.match_data)
         full_name = rpo(org, repo)
         opts = {}
         r_obj = octo.repository(full_name)
@@ -105,8 +128,68 @@ module Lita
         response.reply(t('repo_info.reply', opts))
       end
 
+      def repo_teams_list(response)
+        org, repo = repo_match(response.match_data)
+        full_name = rpo(org, repo)
+
+        begin
+          teams = octo.repository_teams(full_name)
+        rescue Octokit::NotFound
+          return response.reply(t('not_found', org: org, repo: repo))
+        end
+
+        if teams.length == 0
+          reply = t('repo_team_list.none', org: org, repo: full_name)
+        else
+          reply = t('repo_team_list.header', num_teams: teams.length, repo: full_name)
+        end
+
+        sort_by_name(teams).each { |team| reply << t('repo_team_list.team', team.to_h) }
+
+        response.reply(reply)
+      end
+
+      def repo_team_router(response)
+        action = response.match_data['action']
+        response.reply(send("repo_team_#{action}".to_sym, response))
+      end
+
       private
 
+      def repo_team_add(response)
+        return t('method_disabled') if func_disabled?(__method__)
+        md = response.match_data
+        org, repo = repo_match(md)
+        full_name = rpo(org, repo)
+        team = gh_team(org, md['team'])
+
+        return t('not_found', org: org, repo: repo) unless repo?(full_name)
+        return t('team_not_found', team: md['team']) if team.nil?
+
+        if repo_has_team?(full_name, team[:id])
+          return t('repo_team_add.exists', repo: full_name, team: team[:name])
+        end
+
+        add_team_to_repo(full_name, team)
+      end
+
+      def repo_team_rm(response)
+        return t('method_disabled') if func_disabled?(__method__)
+        md = response.match_data
+        org, repo = repo_match(md)
+        full_name = rpo(org, repo)
+        team = gh_team(org, md['team'])
+
+        return t('not_found', org: org, repo: repo) unless repo?(full_name)
+        return t('team_not_found', team: md['team']) if team.nil?
+
+        unless repo_has_team?(full_name, team[:id])
+          return t('repo_team_rm.exists', repo: full_name, team: team[:name])
+        end
+
+        remove_team_from_repo(full_name, team)
+      end
+
       def command_opts(cmd)
         o = {}
         cmd.scan(LitaGithub::R::OPT_REGEX).flatten.compact.each do |opt|
@@ -193,6 +276,34 @@ module Lita
         end
         reply
       end
+
+      def gh_team(org, team)
+        team_id = /^\d+$/.match(team.to_s) ? team : team_id_by_slug(team, org)
+
+        return nil if team_id.nil?
+
+        begin
+          octo.team(team_id)
+        rescue Octokit::NotFound
+          nil
+        end
+      end
+
+      def add_team_to_repo(full_name, team)
+        if octo.add_team_repository(team[:id], full_name)
+          return t('repo_team_add.pass', repo: full_name, team: team[:name])
+        else
+          return t('repo_team_add.fail', repo: full_name, team: team[:name])
+        end
+      end
+
+      def remove_team_from_repo(full_name, team)
+        if octo.remove_team_repository(team[:id], full_name)
+          return t('repo_team_rm.pass', repo: full_name, team: team[:name])
+        else
+          return t('repo_team_rm.fail', repo: full_name, team: team[:name])
+        end
+      end
     end
 
     Lita.register_handler(GithubRepo)

data/lita-github.gemspec

@@ -40,6 +40,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rubocop', '~> 0.26.0'
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'fuubar', '~> 2.0'
+  s.add_development_dependency 'pry', '~> 0.10', '>= 0.10.1'
   s.add_development_dependency 'codeclimate-test-reporter', '~> 0.4', '>= 0.4.0'
 
   s.add_runtime_dependency 'lita', '~> 3.3'

data/locales/en.yml

@@ -11,6 +11,8 @@ en:
           totp: "%{token}"
       github_repo:
         method_disabled: "Sorry, this function has either been disabled or not enabled in the config"
+        not_found: "That repo (%{org}/%{repo}) does not exist"
+        team_not_found: "Unable to match any teams based on: %{team}"
         repo_create:
           pass: "Created %{org}/%{repo}: %{repo_url}"
           fail: "Unable to create %{org}/%{repo}"
@@ -18,9 +20,20 @@ en:
         repo_delete:
           pass: "Deleted %{org}/%{repo}"
           fail: "Unable to delete %{org}/%{repo}"
-          not_found: "That repo (%{org}/%{repo}) does not exist"
         repo_info:
           reply: "%{repo} (private:%{private}) :: %{url}\nDesc: %{description}\nIssues: %{issues_count} PRs: %{pr_count}"
+        repo_team_list:
+          none: "Beyond the '%{org}' org owners, %{repo} has no teams"
+          header: "Showing %{num_teams} team(s) for %{repo}:\n"
+          team: "Name: %{name}, Slug: %{slug}, ID: %{id}, Perms: %{permission}\n"
+        repo_team_add:
+          pass: "Added the '%{team}' team to %{repo}"
+          fail: "Something went wrong trying to add the '%{team}' team to %{repo}. Is that team in your organization?"
+          exists: "The '%{team}' team is already a member of %{repo}"
+        repo_team_rm:
+          pass: "Removed the '%{team}' team from %{repo}"
+          fail: "Something went wrong trying to remove the '%{team}' team from %{repo}"
+          exists: "The '%{team}' team is not a member of %{repo}"
       github_pr:
         method_disabled: "Sorry, this function has either been disabled or not enabled in the config"
         exception: "An unexpected exception was hit during the GitHub API operation. Please make sure all arguments are proper and try again, or try checking the GitHub status (gh status)"
@@ -38,3 +51,8 @@ en:
         pr_list:
           large_list: "You have more than %{max} open pull requests :(! Here are the ten newest oldest:\n"
           no_prs: "This repo has no open pull requests; good job!"
+      github_org:
+        org_not_found: "The organization '%{org}' was not found. Does my user have ownership permission?"
+        org_teams_list:
+          header: "Showing %{num_teams} team(s) for %{org}:\n"
+          team: "Name: %{name}, Slug: %{slug}, ID: %{id}, Perms: %{permission}\n"

data/spec/unit/lita-github/octo_spec.rb

@@ -34,10 +34,11 @@ describe LitaGithub::Octo do
     allow(Octokit::Client).to receive(:new).with(access_token: 'abc123').and_return(DoubleFixer)
     @conf_obj = double('Lita::Config', access_token: 'abc123')
     allow(self).to receive(:config).and_return(@conf_obj)
-    allow_any_instance_of(DummyClass).to receive(:config).and_return(@conf_obj)
     @dummy = DummyClass.new
+    allow(@dummy).to receive(:config).and_return(@conf_obj)
     @dummy.setup_octo(nil)
   end
+  after { allow(Octokit::Client).to receive(:new).and_call_original }
 
   include LitaGithub::Octo
 

data/spec/unit/lita-github/org_spec.rb

@@ -29,4 +29,21 @@ describe LitaGithub::Org do
       end
     end
   end
+
+  describe '.sort_by_name' do
+    let(:unsorted_list) do
+      [
+        { name: 'xy' }, { name: 'a' }, { name: 'Zx' }, { name: 'D' }, { name: 'z' }
+      ]
+    end
+    let(:sorted_list) do
+      [
+        { name: 'a' }, { name: 'D' }, { name: 'xy' }, { name: 'z' }, { name: 'Zx' }
+      ]
+    end
+
+    it 'should properly sort the list' do
+      expect(sort_by_name(unsorted_list)).to eql sorted_list
+    end
+  end
 end

data/spec/unit/lita-github/repo_spec.rb

@@ -45,13 +45,31 @@ describe LitaGithub::Repo do
   describe '.repo_match' do
     before { allow(self).to receive(:organization).and_return('GrapeDuty') }
 
-    let(:resp_obj) do
-      md_mock = { 'org' => 'GrapeDuty', 'repo' => 'lita-test' }
-      double('Lita::Response', match_data: md_mock)
-    end
+    let(:match_data) { { 'org' => 'GrapeDuty', 'repo' => 'lita-test' } }
 
     it 'should return the Org/Repo match' do
-      expect(repo_match(resp_obj)).to eql ['GrapeDuty', 'lita-test']
+      expect(repo_match(match_data)).to eql ['GrapeDuty', 'lita-test']
+    end
+  end
+
+  describe '.repo_has_team?' do
+    before do
+      @teams = [{ id: 1 }, { id: 2 }, { id: 3 }, { id: 4 }, { id: 5 }]
+      @octo_obj = double('Octokit::Client', repository_teams: @teams)
+      allow(self).to receive(:octo).and_return(@octo_obj)
+    end
+
+    context 'when repo has the team' do
+      it 'should return be truthy' do
+        expect(@octo_obj).to receive(:repository_teams).with('GrapeDuty/lita-test').and_return(@teams)
+        expect(repo_has_team?('GrapeDuty/lita-test', 4)).to be_truthy
+      end
+    end
+
+    context 'when the repo does not have the team' do
+      it 'should be falsey' do
+        expect(repo_has_team?('GrapeDuty/lita-test', 42)).to be_falsey
+      end
     end
   end
 end

data/spec/unit/lita/handlers/github_org_spec.rb

@@ -0,0 +1,65 @@
+# -*- coding: UTF-8 -*-
+#
+# Copyright 2014 PagerDuty, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+
+describe Lita::Handlers::GithubOrg, lita_handler: true do
+  it { routes_command('gh teams PagerDuty').to(:org_teams_list) }
+  it { routes_command('gh org teams GrapeDuty').to(:org_teams_list) }
+  it { routes_command('gh org team list PagerDuty').to(:org_teams_list) }
+  it { routes_command('gh teams').to(:org_teams_list) }
+  it { routes_command('gh org teams').to(:org_teams_list) }
+  it { routes_command('gh org team list').to(:org_teams_list) }
+
+  let(:github_org) { Lita::Handlers::GithubOrg.new('robot') }
+
+  describe '.org_teams_list' do
+    before do
+      @teams = [
+        { name: 'Owners', id: 1, slug: 'owners', permission: 'admin' },
+        { name: 'HeckmanTest', slug: 'heckmantest', id: 42, permission: 'push' },
+        { name: 'A Team', slug: 'a-team', id: 84, permission: 'pull' }
+      ]
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty')
+      @octo_obj = double('Octokit::Client', organization_teams: @teams)
+      allow(github_org).to receive(:config).and_return(conf_obj)
+      allow(github_org).to receive(:octo).and_return(@octo_obj)
+    end
+
+    context 'when provided a valid org' do
+      it 'should return a list of the team sorted, with Owners at the top' do
+        expect(@octo_obj).to receive(:organization_teams).with('GrapeDuty').and_return(@teams)
+        send_command('gh teams GrapeDuty')
+        expect(replies.last).to eql 'Showing 3 team(s) for GrapeDuty:
+Name: Owners, Slug: owners, ID: 1, Perms: admin
+Name: A Team, Slug: a-team, ID: 84, Perms: pull
+Name: HeckmanTest, Slug: heckmantest, ID: 42, Perms: push
+'
+      end
+    end
+
+    context 'when provided an invalid org' do
+      before { allow(@octo_obj).to receive(:organization_teams).and_raise(Octokit::NotFound.new) }
+
+      it 'should return a message indicating it could not find the organization' do
+        send_command('gh teams GrapeDuty')
+        expect(replies.last).to eql(
+          "The organization 'GrapeDuty' was not found. Does my user have ownership permission?"
+        )
+      end
+    end
+  end
+end

data/spec/unit/lita/handlers/github_pr_spec.rb

@@ -31,8 +31,7 @@ describe Lita::Handlers::GithubPR, lita_handler: true do
   describe '.pr_match' do
     it 'should return the content of the match data' do
       mock_md = { 'org' => github_org, 'repo' => github_repo, 'pr' => 42 }
-      mock_resp = double('Lita::Response', match_data: mock_md)
-      expect(github_pr.send(:pr_match, mock_resp)).to eql [github_org, github_repo, 42]
+      expect(github_pr.send(:pr_match, mock_md)).to eql [github_org, github_repo, 42]
     end
   end
 

data/spec/unit/lita/handlers/github_repo_spec.rb

@@ -32,6 +32,30 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
   it { routes_command('gh repo info GrapeDuty/lita-test').to(:repo_info) }
   it { routes_command('gh repo info lita-test').to(:repo_info) }
 
+  # repo_teams_list routing
+  it { routes_command('gh repo teams GrapeDuty/lita-test').to(:repo_teams_list) }
+  it { routes_command('gh repo team list GrapeDuty/lita-test').to(:repo_teams_list) }
+  it { routes_command('gh repo teams lita-test').to(:repo_teams_list) }
+  it { routes_command('gh repo team list lita-test').to(:repo_teams_list) }
+
+  # repo_team_router routing
+  it { routes_command('gh repo team add everyone GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add everyone to GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add everyone lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add everyone to lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add 42 GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add 42 to GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add 42 lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team add 42 to lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm everyone GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm everyone to GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm everyone lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm everyone to lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm 42 GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm 42 to GrapeDuty/lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm 42 lita-test').to(:repo_team_router) }
+  it { routes_command('gh repo team rm 42 to lita-test').to(:repo_team_router) }
+
   let(:github_repo) { Lita::Handlers::GithubRepo.new('robot') }
   let(:github_org) { 'GrapeDuty' }
   let(:disabled_reply) { 'Sorry, this function has either been disabled or not enabled in the config' }
@@ -299,6 +323,229 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
     end
   end
 
+  describe '.remove_team_from_repo' do
+    before do
+      @octo_obj = double('Octokit::Client', remove_team_repository: true)
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+    end
+
+    context 'when it succeeds' do
+      it 'should reply with the success message' do
+        expect(@octo_obj).to receive(:remove_team_repository).with(42, 'GrapeDuty/lita-test')
+          .and_return(true)
+        r = github_repo.send(:remove_team_from_repo, 'GrapeDuty/lita-test', id: 42, name: 'HeckmanTest')
+        expect(r).to eql "Removed the 'HeckmanTest' team from GrapeDuty/lita-test"
+      end
+    end
+
+    context 'when it fails' do
+      before { allow(@octo_obj).to receive(:remove_team_repository).and_return(false) }
+
+      it 'should reply with the failure message' do
+        r = github_repo.send(:remove_team_from_repo, 'GrapeDuty/lita-test', id: 42, name: 'HeckTest')
+        expect(r).to eql "Something went wrong trying to remove the 'HeckTest' team from GrapeDuty/lita-test"
+      end
+    end
+  end
+
+  describe '.add_team_to_repo' do
+    before do
+      @octo_obj = double('Octokit::Client', add_team_repository: true)
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+    end
+
+    context 'when it succeeds' do
+      it 'should reply with the success message' do
+        expect(@octo_obj).to receive(:add_team_repository).with(42, 'GrapeDuty/lita-test')
+          .and_return(true)
+        r = github_repo.send(:add_team_to_repo, 'GrapeDuty/lita-test', id: 42, name: 'HeckmanTest')
+        expect(r).to eql "Added the 'HeckmanTest' team to GrapeDuty/lita-test"
+      end
+    end
+
+    context 'when it fails' do
+      before { allow(@octo_obj).to receive(:add_team_repository).and_return(false) }
+
+      it 'should reply with the failure message' do
+        r = github_repo.send(:add_team_to_repo, 'GrapeDuty/lita-test', id: 42, name: 'HeckTest')
+        expect(r).to eql(
+          "Something went wrong trying to add the 'HeckTest' team to GrapeDuty/lita-test. " \
+            'Is that team in your organization?'
+        )
+      end
+    end
+  end
+
+  describe '.gh_team' do
+    before do
+      @team1 = { name: 'HeckTest', id: 42 }
+      @team2 = { name: 'Heckman', id: 84 }
+      @octo_obj = double('Octokit::Client', team: {})
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+      allow(github_repo).to receive(:team_id_by_slug).with('Heckman', 'GrapeDuty').and_return(@team2[:id])
+    end
+
+    context 'when the team provided is the team id' do
+      before { allow(@octo_obj).to receive(:team).with(42).and_return(@team1) }
+
+      it 'should return the specific team' do
+        expect(github_repo.send(:gh_team, 'GrapeDuty', 42)).to eql @team1
+      end
+    end
+
+    context 'when the team provided is the team' do
+      before { allow(@octo_obj).to receive(:team).with(84).and_return(@team2) }
+
+      it 'should return the specific team' do
+        expect(github_repo.send(:gh_team, 'GrapeDuty', 'Heckman')).to eql @team2
+      end
+    end
+
+    context 'when the team was not found' do
+      context 'but it found the id by the slug' do
+        before do
+          allow(github_repo).to receive(:team_id_by_slug).with('Wtf', 'GrapeDuty').and_return(88)
+          allow(@octo_obj).to receive(:team).and_raise(Octokit::NotFound.new)
+        end
+
+        it 'should return nil' do
+          expect(github_repo.send(:gh_team, 'GrapeDuty', 'Wtf')).to eql nil
+        end
+      end
+
+      context 'not even by the slug' do
+        before do
+          allow(github_repo).to receive(:team_id_by_slug).with('Wtf', 'GrapeDuty').and_return(nil)
+          allow(@octo_obj).to receive(:team).and_raise(Octokit::NotFound.new)
+        end
+
+        it 'should return nil' do
+          expect(github_repo.send(:gh_team, 'GrapeDuty', 'Wtf')).to eql nil
+        end
+      end
+    end
+  end
+
+  describe '.repo_team_add' do
+    before do
+      match_data = { 'org' => github_org, 'repo' => 'lita-test', 'team' => 'HeckmanTest' }
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_add_enabled: true)
+      @response = double('Lita::Response', match_data: match_data)
+      team = { id: 42, name: 'HeckmanTest' }
+      allow(github_repo).to receive(:config).and_return(conf_obj)
+      allow(github_repo).to receive(:gh_team).with('GrapeDuty', 'HeckmanTest').and_return(team)
+      allow(github_repo).to receive(:repo?).and_return(true)
+      allow(github_repo).to receive(:repo_has_team?).and_return(false)
+      allow(github_repo).to receive(:add_team_to_repo).and_return('attr')
+    end
+
+    context 'when function is disabled' do
+      before do
+        conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_add_enabled: false)
+        allow(github_repo).to receive(:config).and_return(conf_obj)
+      end
+
+      it 'should return the method disabled error' do
+        r = github_repo.send(:repo_team_add, @response)
+        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+      end
+    end
+
+    context 'when valid inputs provided, and all things work out' do
+      it 'should return the text from add_team_to_repo' do
+        r = github_repo.send(:repo_team_add, @response)
+        expect(r).to eql 'attr'
+      end
+    end
+
+    context 'when repo not found' do
+      before { allow(github_repo).to receive(:repo?).and_return(false) }
+
+      it 'should return the repo not found error' do
+        r = github_repo.send(:repo_team_add, @response)
+        expect(r).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+      end
+    end
+
+    context 'when team not found' do
+      before { allow(github_repo).to receive(:gh_team).and_return(nil) }
+
+      it 'should return the team not found error' do
+        r = github_repo.send(:repo_team_add, @response)
+        expect(r).to eql 'Unable to match any teams based on: HeckmanTest'
+      end
+    end
+
+    context 'when the team is already part of the repo' do
+      before { allow(github_repo).to receive(:repo_has_team?).and_return(true) }
+
+      it 'should mention that the team already exists on the repo' do
+        r = github_repo.send(:repo_team_add, @response)
+        expect(r).to eql "The 'HeckmanTest' team is already a member of GrapeDuty/lita-test"
+      end
+    end
+  end
+
+  describe '.repo_team_rm' do
+    before do
+      match_data = { 'org' => github_org, 'repo' => 'lita-test', 'team' => 'HeckmanTest' }
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_rm_enabled: true)
+      @response = double('Lita::Response', match_data: match_data)
+      team = { id: 42, name: 'HeckmanTest' }
+      allow(github_repo).to receive(:config).and_return(conf_obj)
+      allow(github_repo).to receive(:gh_team).with('GrapeDuty', 'HeckmanTest').and_return(team)
+      allow(github_repo).to receive(:repo?).and_return(true)
+      allow(github_repo).to receive(:repo_has_team?).and_return(true)
+      allow(github_repo).to receive(:remove_team_from_repo).and_return('rtfr')
+    end
+
+    context 'when function is disabled' do
+      before do
+        conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_rm_enabled: false)
+        allow(github_repo).to receive(:config).and_return(conf_obj)
+      end
+
+      it 'should return the method disabled error' do
+        r = github_repo.send(:repo_team_rm, @response)
+        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+      end
+    end
+
+    context 'when valid inputs provided, and all things work out' do
+      it 'should return the text from remove_team_to_repo' do
+        r = github_repo.send(:repo_team_rm, @response)
+        expect(r).to eql 'rtfr'
+      end
+    end
+
+    context 'when repo not found' do
+      before { allow(github_repo).to receive(:repo?).and_return(false) }
+
+      it 'should return the repo not found error' do
+        r = github_repo.send(:repo_team_rm, @response)
+        expect(r).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+      end
+    end
+
+    context 'when team not found' do
+      before { allow(github_repo).to receive(:gh_team).and_return(nil) }
+
+      it 'should return the team not found error' do
+        r = github_repo.send(:repo_team_rm, @response)
+        expect(r).to eql 'Unable to match any teams based on: HeckmanTest'
+      end
+    end
+
+    context 'when the team is not part of the repo' do
+      before { allow(github_repo).to receive(:repo_has_team?).and_return(false) }
+
+      it 'should mention that the team already exists on the repo' do
+        r = github_repo.send(:repo_team_rm, @response)
+        expect(r).to eql "The 'HeckmanTest' team is not a member of GrapeDuty/lita-test"
+      end
+    end
+  end
+
   ####
   # Handlers
   ####
@@ -403,4 +650,49 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
       end
     end
   end
+
+  describe '.repo_teams_list' do
+    before do
+      @teams = [
+        { name: 'Interns', slug: 'interns', id: 84, permission: 'pull' },
+        { name: 'Everyone', slug: 'everyone', id: 42, permission: 'push' }
+      ]
+      @octo_obj = double('Octokit::Client', repository_teams: @teams)
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+    end
+
+    context 'when it finds a repo' do
+      it 'should return the list of teams' do
+        expect(@octo_obj).to receive(:repository_teams).with('GrapeDuty/lita-test').and_return(@teams)
+        send_command("gh repo teams #{github_org}/lita-test")
+        expect(replies.last).to eql 'Showing 2 team(s) for GrapeDuty/lita-test:
+Name: Everyone, Slug: everyone, ID: 42, Perms: push
+Name: Interns, Slug: interns, ID: 84, Perms: pull
+'
+      end
+    end
+
+    context 'when the repo is not valid' do
+      before { allow(@octo_obj).to receive(:repository_teams).and_raise(Octokit::NotFound.new) }
+
+      it 'should say the repo was not found' do
+        send_command("gh repo teams #{github_org}/lita-test")
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+      end
+    end
+  end
+
+  describe '.repo_team_router' do
+    before do
+      allow(github_repo).to receive(:repo_team_something)
+        .with(an_instance_of(Lita::Response)).and_return('ohai')
+    end
+
+    it 'should call the method based on action and respond with its return' do
+      expect(github_repo).to receive(:repo_team_add)
+        .with(an_instance_of(Lita::Response)).and_return('ohai')
+      send_command("gh repo team add 42 #{github_org}/lita-test")
+      expect(replies.last).to eql 'ohai'
+    end
+  end
 end

data/spec/unit/lita/handlers/github_spec.rb

@@ -41,6 +41,14 @@ describe Lita::Handlers::Github, lita_handler: true do
       expect(Lita.config.handlers.github.repo_delete_enabled).to be_falsey
     end
 
+    it 'should disable Lita::Handlers::GithubRepo.repo_team_add by default' do
+      expect(Lita.config.handlers.github.repo_team_add_enabled).to be_falsey
+    end
+
+    it 'should disable Lita::Handlers::GithubRepo.repo_team_rm by default' do
+      expect(Lita.config.handlers.github.repo_team_rm_enabled).to be_falsey
+    end
+
     it 'should enable Lita::Handlers::GithubPR.pr_merge by default' do
       expect(Lita.config.handlers.github.pr_merge_enabled).to be_truthy
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Tim Heckman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-09 00:00:00.000000000 Z
+date: 2014-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.10.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.10.1
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -180,6 +200,7 @@ files:
 - lib/lita-github/repo.rb
 - lib/lita-github/version.rb
 - lib/lita/handlers/github.rb
+- lib/lita/handlers/github_org.rb
 - lib/lita/handlers/github_pr.rb
 - lib/lita/handlers/github_repo.rb
 - lita-github.gemspec
@@ -192,6 +213,7 @@ files:
 - spec/unit/lita-github/r_spec.rb
 - spec/unit/lita-github/repo_spec.rb
 - spec/unit/lita-github/version_spec.rb
+- spec/unit/lita/handlers/github_org_spec.rb
 - spec/unit/lita/handlers/github_pr_spec.rb
 - spec/unit/lita/handlers/github_repo_spec.rb
 - spec/unit/lita/handlers/github_spec.rb
@@ -230,6 +252,7 @@ test_files:
 - spec/unit/lita-github/r_spec.rb
 - spec/unit/lita-github/repo_spec.rb
 - spec/unit/lita-github/version_spec.rb
+- spec/unit/lita/handlers/github_org_spec.rb
 - spec/unit/lita/handlers/github_pr_spec.rb
 - spec/unit/lita/handlers/github_repo_spec.rb
 - spec/unit/lita/handlers/github_spec.rb