lita-github 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84ebbc2e578a216a3e4e15fa00011549924cb610
-  data.tar.gz: 700ad40378f13ab0d10b1775a361ccbca3aca5a1
+  metadata.gz: 807063c8ac3a37a3d99452dd97ca4697b25466ee
+  data.tar.gz: b05330632d6bec6b9e2de3dda514770ad5f5d4fb
 SHA512:
-  metadata.gz: 9b7c3e7b9a3db900ad5033f72d44078935c1e11265764e3be9ead51ba9f1d2422a7100416c0897af2ac0c1b3127b7a8d9f20ef89be7ee563027dbdf3a7f8103f
-  data.tar.gz: af6d62477813175ea4abc97117f4169ff4cd1f64da4028ab129e961fd023745ef38a8f4dcd6279623870cad641cf605832b3b63229b8424042e47f918bf2290e
+  metadata.gz: 89cccb87fe4a2a3dd8023fb53a8e5752bf45dfe1c4ef0d9d45442e5cecbbec80ffaa2040ffcc7d0e1f2ce644c8805be1e712d91fccad001c0dffe1829903d05a
+  data.tar.gz: a880e825a989589478bd1eef547c94d034192370e6b23c659cc92fa1ab791dd0b43e24c3692f3c071091f9ed67bca542f2754781e392c6dceeb85bcd94a58f1a

data/README.md

@@ -63,3 +63,5 @@ Here is the current functionality:
 * `!gh pr merge #42 PagerDuty/lita-github` or `!shipit #42 PagerDuty/lita-github`
   * This merges the specified pull request
   * This method can be disabled by setting `config.handlers.github.pr_merge_enabled = false` in your configuration file
+* `!gh pr list PagerDuty/lita-github`
+  * list the open pull requests on a repo

data/lib/lita-github/repo.rb

@@ -17,6 +17,8 @@
 module LitaGithub
   # Github handler common-use Repository methods
   module Repo
+    PR_LIST_MAX_COUNT = 20
+
     def rpo(org, repo)
       "#{org}/#{repo}"
     end
@@ -24,5 +26,10 @@ module LitaGithub
     def repo?(r)
       octo.repository?(r)
     end
+
+    def repo_match(response)
+      md = response.match_data
+      [organization(md['org']), md['repo']]
+    end
   end
 end

data/lib/lita-github/version.rb

@@ -16,6 +16,6 @@
 
 # Administer your Hub of Gits with Lita!
 module LitaGithub
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
   MAJ, MIN, REV = VERSION.split('.').map(&:to_i)
 end

data/lib/lita/handlers/github.rb

@@ -32,7 +32,7 @@ module Lita
       on :loaded, :setup_octo # from LitaGithub::Octo
 
       route(
-        /#{LitaGithub::R::A_REG}status/, :gh_status,
+        /#{LitaGithub::R::A_REG}status/, :status,
         command: true,
         help: {
           'github status' => 'get the system status from GitHub',
@@ -41,7 +41,7 @@ module Lita
       )
 
       route(
-        /#{LitaGithub::R::A_REG}(?:v|version|build)/, :gh_version,
+        /#{LitaGithub::R::A_REG}(?:v|version|build)/, :version,
         command: true,
         help: {
           'gh version' => 'get the lita-github version'
@@ -76,11 +76,15 @@ module Lita
         config.pr_merge_enabled = true
       end
 
-      def gh_status(response)
+      def status(response)
         status = octo.github_status_last_message
         response.reply(t("status.#{status[:status]}", status))
       end
 
+      def version(response)
+        response.reply("lita-github v#{LitaGithub::VERSION}")
+      end
+
       def token_generate(response)
         if config.totp_secret.is_a?(String)
           response.reply(t('token_generate.totp', token: ROTP::TOTP.new(config.totp_secret).now))
@@ -88,10 +92,6 @@ module Lita
           response.reply(t('token_generate.no_secret'))
         end
       end
-
-      def gh_version(response)
-        response.reply("lita-github v#{LitaGithub::VERSION}")
-      end
     end
 
     Lita.register_handler(Github)

data/lib/lita/handlers/github_pr.rb

@@ -52,6 +52,14 @@ module Lita
         }
       )
 
+      route(
+        /#{LitaGithub::R::A_REG}pr\s+?list\s+?#{LitaGithub::R::REPO_REGEX}/, :pr_list,
+        command: true,
+        help: {
+          'gh pr list PagerDuty/lita-github' => 'list the 10 oldest and newest PRs'
+        }
+      )
+
       # rubocop:disable Metrics/CyclomaticComplexity
       # rubocop:disable Metrics/PerceivedComplexity
       def pr_info(response)
@@ -98,6 +106,30 @@ module Lita
       # rubocop:enable Metrics/CyclomaticComplexity
       # rubocop:enable Metrics/PerceivedComplexity
 
+      def pr_list(response)
+        org, repo = repo_match(response)
+        full_name = rpo(org, repo)
+        reply = ''
+
+        prs = octo.pull_requests(full_name)
+
+        if prs.length > LitaGithub::Repo::PR_LIST_MAX_COUNT
+          reply = t('pr_list.large_list', max: LitaGithub::Repo::PR_LIST_MAX_COUNT)
+
+          prs.slice(0, 10).each { |pr| reply << list_line(pr, full_name) }
+
+          reply << "----\n"
+
+          prs.slice(-10, 10).each { |pr| reply << list_line(pr, full_name) }
+        elsif prs.length > 0
+          prs.each { |pr| reply << list_line(pr, full_name) }
+        else
+          reply = t('pr_list.no_prs')
+        end
+
+        response.reply(reply)
+      end
+
       private
 
       def pr_match(response)
@@ -183,6 +215,10 @@ module Lita
         info[:comments]         = pr_obj[:comments]
         info
       end
+
+      def list_line(pr, full_name)
+        t('pr_info.header', build_pr_header!({}, pr).merge(repo: full_name))
+      end
     end
 
     Lita.register_handler(GithubPR)

data/lib/lita/handlers/github_repo.rb

@@ -117,12 +117,6 @@ module Lita
         o
       end
 
-      # TODO: convert this to a mixin method for reuse
-      def repo_match(response)
-        md = response.match_data
-        [organization(md['org']), md['repo']]
-      end
-
       def extrapolate_create_opts(opts, org)
         opts[:organization] = org
 

data/locales/en.yml

@@ -35,3 +35,6 @@ en:
         pr_merge:
           pass: "Merged pull request #%{pr} from %{org}/%{branch}\n%{title}"
           fail: "Failed trying to merge PR #%{pr} (%{title}) :: %{url}\nMessage: %{msg}"
+        pr_list:
+          large_list: "You have more than %{max} open pull requests :(! Here are the ten newest oldest:\n"
+          no_prs: "This repo has no open pull requests; good job!"

data/spec/unit/lita-github/repo_spec.rb

@@ -5,6 +5,13 @@ require 'spec_helper'
 describe LitaGithub::Repo do
   include LitaGithub::Repo
 
+  describe '::PR_LIST_MAX_COUNT' do
+    subject { LitaGithub::Repo::PR_LIST_MAX_COUNT }
+
+    it { should be_an_instance_of Fixnum }
+    it { should eql 20 }
+  end
+
   describe '.rpo' do
     it 'should return the provided arguments in a Repo-like string' do
       org = 'GrapeDuty'
@@ -34,4 +41,17 @@ describe LitaGithub::Repo do
       it { should be_falsey }
     end
   end
+
+  describe '.repo_match' do
+    before { allow(self).to receive(:organization).and_return('GrapeDuty') }
+
+    let(:resp_obj) do
+      md_mock = { 'org' => 'GrapeDuty', 'repo' => 'lita-test' }
+      double('Lita::Response', match_data: md_mock)
+    end
+
+    it 'should return the Org/Repo match' do
+      expect(repo_match(resp_obj)).to eql ['GrapeDuty', 'lita-test']
+    end
+  end
 end

data/spec/unit/lita/handlers/github_pr_spec.rb

@@ -366,6 +366,16 @@ describe Lita::Handlers::GithubPR, lita_handler: true do
     end
   end
 
+  describe '.list_line' do
+    let(:pr) { { title: 'Test', number: 42, html_url: 'nothtml' } }
+    let(:full_name) { 'GrapeDuty/lita-test' }
+
+    it 'should return a PR header' do
+      l = github_pr.send(:list_line, pr, full_name)
+      expect(l).to eql "GrapeDuty/lita-test #42: Test :: nothtml\n"
+    end
+  end
+
   ####
   # Handlers
   ####
@@ -549,4 +559,95 @@ describe Lita::Handlers::GithubPR, lita_handler: true do
       end
     end
   end
+
+  describe '.pr_list' do
+    before do
+      cfg_obj = double('Lita::Configuration')
+      octo_obj = double('Octokit::Client', pull_requests: [])
+      allow(github_pr).to receive(:octo).and_return(octo_obj)
+      allow(github_pr).to receive(:config).and_return(cfg_obj)
+    end
+
+    context 'when there are no pull requests' do
+      it 'should state that there are no pull requests' do
+        send_command("gh pr list #{github_org}/#{github_repo}")
+        expect(replies.last).to eql 'This repo has no open pull requests; good job!'
+      end
+    end
+
+    context 'when there are less than 20 prs' do
+      before do
+        pr = [
+          { title: 'Test2', number: 84, html_url: 'nohtmlurl' },
+          { title: 'Test1', number: 42, html_url: 'htmlurl' }
+        ]
+        octo_obj = double('Octokit::Client', pull_requests: pr)
+        allow(github_pr).to receive(:octo).and_return(octo_obj)
+      end
+
+      it 'should reply with the PRs' do
+        send_command("gh pr list #{github_org}/#{github_repo}")
+        expect(replies.last).to eql "GrapeDuty/lita-test #84: Test2 :: nohtmlurl\n" \
+                                    "GrapeDuty/lita-test #42: Test1 :: htmlurl\n"
+      end
+    end
+
+    context 'when there are more than 20 prs' do
+      before do
+        pr = [
+          { title: 'Test21', number: 84, html_url: 'xxx' },
+          { title: 'Test20', number: 83, html_url: 'xxx' },
+          { title: 'Test19', number: 82, html_url: 'xxx' },
+          { title: 'Test18', number: 80, html_url: 'xxx' },
+          { title: 'Test17', number: 78, html_url: 'xxx' },
+          { title: 'Test16', number: 74, html_url: 'xxx' },
+          { title: 'Test15', number: 68, html_url: 'xxx' },
+          { title: 'Test14', number: 66, html_url: 'xxx' },
+          { title: 'Test13', number: 64, html_url: 'xxx' },
+          { title: 'Test12', number: 55, html_url: 'xxx' },
+          { title: 'Test11', number: 52, html_url: 'xxx' },
+          { title: 'Test10', number: 51, html_url: 'xxx' },
+          { title: 'Test9', number: 50, html_url: 'xxx' },
+          { title: 'Test8', number: 49, html_url: 'xxx' },
+          { title: 'Test7', number: 48, html_url: 'xxx' },
+          { title: 'Test6', number: 47, html_url: 'xxx' },
+          { title: 'Test5', number: 46, html_url: 'xxx' },
+          { title: 'Test4', number: 45, html_url: 'xxx' },
+          { title: 'Test3', number: 44, html_url: 'xxx' },
+          { title: 'Test2', number: 43, html_url: 'xxx' },
+          { title: 'Test1', number: 42, html_url: 'xxx' }
+        ]
+        octo_obj = double('Octokit::Client', pull_requests: pr)
+        allow(github_pr).to receive(:octo).and_return(octo_obj)
+      end
+
+      it 'should return the list of ten oldest & ten newest' do
+        send_command("gh pr list #{github_org}/#{github_repo}")
+        expect(replies.last)
+          .to eql "You have more than 20 open pull requests :(! Here are the ten newest oldest:
+GrapeDuty/lita-test #84: Test21 :: xxx
+GrapeDuty/lita-test #83: Test20 :: xxx
+GrapeDuty/lita-test #82: Test19 :: xxx
+GrapeDuty/lita-test #80: Test18 :: xxx
+GrapeDuty/lita-test #78: Test17 :: xxx
+GrapeDuty/lita-test #74: Test16 :: xxx
+GrapeDuty/lita-test #68: Test15 :: xxx
+GrapeDuty/lita-test #66: Test14 :: xxx
+GrapeDuty/lita-test #64: Test13 :: xxx
+GrapeDuty/lita-test #55: Test12 :: xxx
+----
+GrapeDuty/lita-test #51: Test10 :: xxx
+GrapeDuty/lita-test #50: Test9 :: xxx
+GrapeDuty/lita-test #49: Test8 :: xxx
+GrapeDuty/lita-test #48: Test7 :: xxx
+GrapeDuty/lita-test #47: Test6 :: xxx
+GrapeDuty/lita-test #46: Test5 :: xxx
+GrapeDuty/lita-test #45: Test4 :: xxx
+GrapeDuty/lita-test #44: Test3 :: xxx
+GrapeDuty/lita-test #43: Test2 :: xxx
+GrapeDuty/lita-test #42: Test1 :: xxx
+"
+      end
+    end
+  end
 end

data/spec/unit/lita/handlers/github_repo_spec.rb

@@ -151,17 +151,6 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
     end
   end
 
-  describe '.repo_match' do
-    let(:resp_obj) do
-      md_mock = { 'org' => github_org, 'repo' => 'lita-test' }
-      double('Lita::Response', match_data: md_mock)
-    end
-
-    it 'should return the Org/Repo match' do
-      expect(github_repo.send(:repo_match, resp_obj)).to eql [github_org, 'lita-test']
-    end
-  end
-
   describe '.command_opts' do
     it 'should find the valid options' do
       o = ' private:true team:heckman bacon:always bacon:sometimes'

data/spec/unit/lita/handlers/github_spec.rb

@@ -19,9 +19,9 @@ require 'spec_helper'
 describe Lita::Handlers::Github, lita_handler: true do
   let(:github) { Lita::Handlers::Github.new('robot') }
 
-  it { routes_command('gh status').to(:gh_status) }
-  it { routes_command('github status').to(:gh_status) }
-  it { routes_command('gh version').to(:gh_version) }
+  it { routes_command('gh status').to(:status) }
+  it { routes_command('github status').to(:status) }
+  it { routes_command('gh version').to(:version) }
   it { routes_command('gh token').to(:token_generate) }
 
   describe '#default_config' do
@@ -42,7 +42,7 @@ describe Lita::Handlers::Github, lita_handler: true do
     end
   end
 
-  describe '.gh_status' do
+  describe '.status' do
     context 'when GitHub status is good' do
       before do
         @octo = double(
@@ -104,7 +104,7 @@ describe Lita::Handlers::Github, lita_handler: true do
     end
   end
 
-  describe '.gh_version' do
+  describe '.version' do
     it 'should send back the Lita version' do
       send_command('gh version')
       expect(replies.last).to eql "lita-github v#{LitaGithub::VERSION}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Tim Heckman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-06 00:00:00.000000000 Z
+date: 2014-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler