lita-github 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9d776a2cd23860fda771d4efd3a3602b672cfb0
-  data.tar.gz: 074232e708387b5457e8162b247ab40042fee1cb
+  metadata.gz: 4bfd623a40a5a5b1c9fbc462dc72f0b286a43dfd
+  data.tar.gz: 84b1958cb141a7295fb744de2ee3d3e6dd2dc798
 SHA512:
-  metadata.gz: 656ec110d8e8461509241198219d5fa7cd7fca49cf92ce6f50bd0260ebfddc3e74a47cc09cfca4c4f948bbfa04d10f0ee614223f16c552a0d7cf86127cc5c80c
-  data.tar.gz: a8cb3ffc5acc22b40f504027d303978eff9043c00ae8bcce84dbc51d73e69adf08610c174edf316b0cea875917b54bf8bed5d2a8db44180d17ea4b029cea6ce5
+  metadata.gz: a82a4d278f7c38781903bd5d9547ed5e784532e96d3243cbc0c066c48f71ed2360044f275b3dd3e4725ae3a68f651ffa1161a9658ba1bbe560fc05b8215fefb6
+  data.tar.gz: 1f454fe23289fa3c0763fa4e889bb09767c80ee6b9203bbdad83810de3fd5fe279b7ce8885df1e3548bfe4a1861606bf1edd9f62a58f0162ee88e4ce2fbec11e

data/.gitignore

@@ -26,10 +26,9 @@ build/
 
 # for a library or gem, you might want to ignore these files since the code is
 # intended to run in multiple environments; otherwise, check them in:
-# Gemfile.lock
-# .ruby-version
-# .ruby-gemset
 Gemfile.lock
+.ruby-version
+.ruby-gemset
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc

data/lib/lita-github/config.rb

@@ -16,7 +16,12 @@
 
 module LitaGithub
   # Github handler Lita configuration methods
+  #
+  # @author Tim Heckman <tim@pagerduty.com>
   module Config
+    # Return the Lita::Config object for the Github handler
+    #
+    # @return [Lita::Config] the config object for Lita::Handlers::Github
     def config
       Lita.config.handlers.github
     end

data/lib/lita-github/filters.rb

@@ -16,7 +16,14 @@
 
 module LitaGithub
   # Github handler common-use method filters
+  #
+  # @author Tim Heckman <tim@pagerduty.com>
   module Filters
+    # Returns whether or not the function has been disabled in the config
+    #
+    # @param method [String] the method name, usually just __method__
+    # @return [TrueClass] if function is disabled
+    # @return [FalseClass] if function is disabled
     def func_disabled?(method)
       config.send("#{method}_enabled".to_sym) ? false : true
     end

data/lib/lita-github/octo.rb

@@ -18,19 +18,33 @@ require 'octokit'
 
 module LitaGithub
   # Github handler common-use Octokit methods
+  #
+  # @author Tim Heckman <tim@pagerduty.com>
   module Octo
-    # pull the access token from the config
+    # Accessor method for the Github access token in the config
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @return [String] the Github API access token
     def access_token
       config.access_token
     end
 
-    # set up the Octokit client
+    # To be used to set up Octokit::Client when loading the Handler class
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @return [NilClass]
     def setup_octo(_)
       @@octo ||= Octokit::Client.new(access_token: access_token)
       @@octo.auto_paginate = true
+      nil
     end
 
-    # object access method for Octokit client
+    # Object access method for Octokit client
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @return [Octokit::Client]
+    # @example
+    #  octo.create_team('PagerDuty', name: 'Example Group', perms:pull)
     def octo
       @@octo
     end

data/lib/lita-github/r.rb

@@ -16,6 +16,8 @@
 
 module LitaGithub
   # Github handler common-use regex constants
+  #
+  # @author Tim Heckman <tim@pagerduty.com>
   module R
     # command alias regex (!gh or !github for example)
     A_REG     ||= '(?:gh|github)\s+?'

data/lib/lita-github/repo.rb

@@ -17,20 +17,44 @@
 module LitaGithub
   # Github handler common-use Repository methods
   module Repo
+    # Maximum number of allowed PRs to be returned when listing
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
     PR_LIST_MAX_COUNT = 20
 
+    # Combine org and repo to get the canonical name
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @param org [String] organization name
+    # @param repo [String] repository name without org prefixed
+    # @return [String] canonical name of repo: <Org>/<Repo>
     def rpo(org, repo)
       "#{org}/#{repo}"
     end
 
+    # Determine if r is a Github repository
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @param r [String] canonical name of the repository
     def repo?(r)
       octo.repository?(r)
     end
 
+    # Helper method for pulling widely used matches out of a MatchData object
+    #
+    # @author Tim Heckman <tim@pagerduty.com>
+    # @param md [MatchData] the match data used to get the matches
+    # @return [Array] [0] is the org name, [1] is the repo name
     def repo_match(md)
       [organization(md['org']), md['repo']]
     end
 
+    # Determine if the team is already on the repository
+    #
+    # @param full_name [String] the canonical name of the repository
+    # @param team_id [Integer] the id for the Github team
+    # @return [TrueClass] if the team is already on the repo
+    # @return [FalseClass] if the team is not on the repo
     def repo_has_team?(full_name, team_id)
       octo.repository_teams(full_name).each { |t| return true if t[:id] == team_id }
       false

data/lib/lita-github/version.rb

@@ -15,7 +15,14 @@
 # limitations under the License.
 
 # Administer your Hub of Gits with Lita!
+#
+# The namespace for non-handler code of the lita-github plugin
+#
+# @author Tim Heckman <tim@pagerduty.com>
 module LitaGithub
-  VERSION = '0.0.11'
+  # lita-github version
+  VERSION = '0.0.12'
+
+  # lita-github version split amongst different revisions
   MAJ, MIN, REV = VERSION.split('.').map(&:to_i)
 end

data/lib/lita/handlers/github.rb

@@ -88,7 +88,7 @@ module Lita
 
       def status(response)
         status = octo.github_status_last_message
-        response.reply(t("status.#{status[:status]}", status))
+        response.reply(t("status.#{status[:status]}", status.to_h))
       end
 
       def version(response)

data/spec/unit/lita/handlers/github_repo_spec.rb

@@ -763,6 +763,15 @@ Name: Interns, Slug: interns, ID: 84, Perms: pull
       end
     end
 
+    context 'when it finds a repo with no teams but the owners' do
+      before { allow(@octo_obj).to receive(:repository_teams).and_return([]) }
+
+      it 'should return the fact there are no teams' do
+        send_command("gh repo teams #{github_org}/lita-test")
+        expect(replies.last).to eql "Beyond the 'GrapeDuty' org owners, GrapeDuty/lita-test has no teams"
+      end
+    end
+
     context 'when the repo is not valid' do
       before { allow(@octo_obj).to receive(:repository_teams).and_raise(Octokit::NotFound.new) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Tim Heckman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-14 00:00:00.000000000 Z
+date: 2014-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler