lita-github 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb3cd200b9fc34080456111f08e27e79a3297311
-  data.tar.gz: eedcd297373ba3f19afe00e3ef460e8cf9248829
+  metadata.gz: 0edd68ade3e5fc642ccb5e606a94b09d40e08d8f
+  data.tar.gz: 8461b46c716ea556aa2c7cf50db4f91c994d91a6
 SHA512:
-  metadata.gz: dfb028a7d353c084a53a9f9ed6c0811dc78850cad2eaf58f74cb00ab87be8d4f3cecb613a5369d3957ac237822c2207fd1d1af0dbce079c927018d11c1a949ef
-  data.tar.gz: 85f39a45bf8bc5e1b0a1b1308472e8dc5bf5a33c9033691b98ac30876813c36779246786a4cf5300766054db16d712981ace7bcd4143263ca6ced2d60b98c37c
+  metadata.gz: 4842ed8a61059de7b651561966c2f074f223c1cc1489ecd92f379dad78ac6c19e5d3d5d7eb727d5254eb4125450e486847aa5a144c9520bff9cdf287ae1aaa01
+  data.tar.gz: d3f24df978afe5d70bd924c8c6165c391b225d55af099c684c06549d3bb615fea9dc73ebd0fe668cfb5b3c0e5ea8e7854b4079c96ec8639968dcec995e73f4e6

data/README.md

@@ -63,6 +63,10 @@ Here is the current functionality:
   * adds the team to the repo -- requires confirmation and enabling via config option (`repo_team_add_enabled = true`)
 * `!gh repo team rm <TEAM_ID|TEAM_SLUG> PagerDuty/lita-github`
   * removes the team to the repo -- requires confirmation and enabling via config option (`repo_team_rm_enabled = true`)
+* `!gh repo update description PagerDuty/lita-github The new lita-github description!`
+  * update the description of the repo, can be disabled with: `repo_update_description_enabled = false`
+* `!gh repo update homepage lita-github https://github.com/PagerDuty/lita-github`
+  * update the homepage of the repo, can be disabled with: `repo_update_homepage_enabled = false`
 
 ### Github PR Handler
 * `!gh pr info PagerDuty/lita-github #42`

data/lib/lita-github/version.rb

@@ -16,6 +16,6 @@
 
 # Administer your Hub of Gits with Lita!
 module LitaGithub
-  VERSION = '0.0.9'
+  VERSION = '0.0.10'
   MAJ, MIN, REV = VERSION.split('.').map(&:to_i)
 end

data/lib/lita/handlers/github.rb

@@ -70,10 +70,12 @@ module Lita
         config.totp_secret = nil
 
         # Lita::Handlers::GithubRepo
-        config.repo_create_enabled    = true
-        config.repo_delete_enabled    = false
-        config.repo_team_add_enabled  = false
-        config.repo_team_rm_enabled   = false
+        config.repo_create_enabled              = true
+        config.repo_delete_enabled              = false
+        config.repo_team_add_enabled            = false
+        config.repo_team_rm_enabled             = false
+        config.repo_update_description_enabled  = true
+        config.repo_update_homepage_enabled     = true
 
         # Lita::Handlers::GithubPR
         config.pr_merge_enabled = true

data/lib/lita/handlers/github_repo.rb

@@ -14,6 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'uri'
 require 'lita-github/r'
 require 'lita-github/config'
 require 'lita-github/octo'
@@ -84,6 +85,14 @@ module Lita
           'gh repo team rm 42 PagerDuty/lita-test' => 'remove a team using ID to your repo'
         }
       )
+
+      route(
+        /#{LitaGithub::R::A_REG}repo\s+update\s+?(?<field>description|homepage)\s+?#{LitaGithub::R::REPO_REGEX}\s+?(?<content>.*)$/,
+        :repo_update_router, command: true, confirmation: true,
+        help: {
+          'gh repo description PagerDuty/lita-github' => 'get the repo description'
+        }
+      )
       # rubocop:enable Metrics/LineLength
 
       def repo_create(response)
@@ -150,10 +159,15 @@ module Lita
       end
 
       def repo_team_router(response)
-        action = response.match_data['action']
+        action = response.match_data['action'].strip
         response.reply(send("repo_team_#{action}".to_sym, response))
       end
 
+      def repo_update_router(response)
+        field = response.match_data['field'].strip
+        response.reply(send("repo_update_#{field}".to_sym, response))
+      end
+
       private
 
       def repo_team_add(response)
@@ -190,6 +204,47 @@ module Lita
         remove_team_from_repo(full_name, team)
       end
 
+      def repo_update_description(response)
+        return t('method_disabled') if func_disabled?(__method__)
+        md = response.match_data
+        org, repo = repo_match(md)
+        full_name = rpo(org, repo)
+
+        return t('not_found', org: org, repo: repo) unless repo?(full_name)
+
+        content = md['content'].strip
+
+        begin
+          resp = octo.edit_repository(full_name, description: content)
+        rescue StandardError
+          return t('repo_update_description.boom', repo: full_name)
+        end
+
+        t('repo_update_description.updated', repo: full_name, desc: resp[:description])
+      end
+
+      def repo_update_homepage(response)
+        return t('method_disabled') if func_disabled?(__method__)
+        md = response.match_data
+        org, repo = repo_match(md)
+        full_name = rpo(org, repo)
+
+        return t('not_found', org: org, repo: repo) unless repo?(full_name)
+
+        regexp = URI::DEFAULT_PARSER.regexp[:ABS_URI]
+        content = md['content'].strip
+
+        return t('repo_update_homepage.invalid_url', url: content) unless regexp.match(content)
+
+        begin
+          resp = octo.edit_repository(full_name, homepage: content)
+        rescue StandardError
+          return t('repo_update_homepage.boom', repo: full_name)
+        end
+
+        t('repo_update_homepage.updated', repo: full_name, url: resp[:homepage])
+      end
+
       def command_opts(cmd)
         o = {}
         cmd.scan(LitaGithub::R::OPT_REGEX).flatten.compact.each do |opt|

data/locales/en.yml

@@ -11,7 +11,7 @@ en:
           totp: "%{token}"
       github_repo:
         method_disabled: "Sorry, this function has either been disabled or not enabled in the config"
-        not_found: "That repo (%{org}/%{repo}) does not exist"
+        not_found: "That repo (%{org}/%{repo}) was not found"
         team_not_found: "Unable to match any teams based on: %{team}"
         repo_create:
           pass: "Created %{org}/%{repo}: %{repo_url}"
@@ -34,6 +34,13 @@ en:
           pass: "Removed the '%{team}' team from %{repo}"
           fail: "Something went wrong trying to remove the '%{team}' team from %{repo}"
           exists: "The '%{team}' team is not a member of %{repo}"
+        repo_update_description:
+          updated: "The description for %{repo} has been updated to: '%{desc}'"
+          boom: "An uncaught exception was hit while trying to update the description of %{repo}. Is GitHub having issues?"
+        repo_update_homepage:
+          updated: "The homepage for %{repo} has been updated to: '%{url}'"
+          invalid_url: "The URL provided is not valid: '%{url}'"
+          boom: "An uncaught exception was hit while trying to update the homepage of %{repo}. Is GitHub having issues?"
       github_pr:
         method_disabled: "Sorry, this function has either been disabled or not enabled in the config"
         exception: "An unexpected exception was hit during the GitHub API operation. Please make sure all arguments are proper and try again, or try checking the GitHub status (gh status)"

data/spec/unit/lita/handlers/github_repo_spec.rb

@@ -56,6 +56,20 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
   it { routes_command('gh repo team rm 42 lita-test').to(:repo_team_router) }
   it { routes_command('gh repo team rm 42 to lita-test').to(:repo_team_router) }
 
+  # repo_update_router routing
+  it do
+    routes_command(
+      'gh repo update homepage GrapeDuty/lita-test https://github.com/GrapeDuty/lita-test'
+    ).to(:repo_update_router)
+  end
+  it do
+    routes_command(
+      'gh repo update homepage lita-test https://github.com/GrapeDuty/lita-test'
+    ).to(:repo_update_router)
+  end
+  it { routes_command('gh repo update description GrapeDuty/lita-test Some description here').to(:repo_update_router) }
+  it { routes_command('gh repo update description lita-test Some description here').to(:repo_update_router) }
+
   let(:github_repo) { Lita::Handlers::GithubRepo.new('robot') }
   let(:github_org) { 'GrapeDuty' }
   let(:disabled_reply) { 'Sorry, this function has either been disabled or not enabled in the config' }
@@ -429,32 +443,30 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
   describe '.repo_team_add' do
     before do
       match_data = { 'org' => github_org, 'repo' => 'lita-test', 'team' => 'HeckmanTest' }
-      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_add_enabled: true)
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty')
       @response = double('Lita::Response', match_data: match_data)
       team = { id: 42, name: 'HeckmanTest' }
       allow(github_repo).to receive(:config).and_return(conf_obj)
       allow(github_repo).to receive(:gh_team).with('GrapeDuty', 'HeckmanTest').and_return(team)
+      allow(github_repo).to receive(:func_disabled?).and_return(false)
       allow(github_repo).to receive(:repo?).and_return(true)
       allow(github_repo).to receive(:repo_has_team?).and_return(false)
       allow(github_repo).to receive(:add_team_to_repo).and_return('attr')
     end
 
-    context 'when function is disabled' do
-      before do
-        conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_add_enabled: false)
-        allow(github_repo).to receive(:config).and_return(conf_obj)
-      end
-
-      it 'should return the method disabled error' do
+    context 'when valid inputs provided, and all things work out' do
+      it 'should return the text from add_team_to_repo' do
         r = github_repo.send(:repo_team_add, @response)
-        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+        expect(r).to eql 'attr'
       end
     end
 
-    context 'when valid inputs provided, and all things work out' do
-      it 'should return the text from add_team_to_repo' do
+    context 'when function is disabled' do
+      before { allow(github_repo).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
         r = github_repo.send(:repo_team_add, @response)
-        expect(r).to eql 'attr'
+        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
       end
     end
 
@@ -463,7 +475,7 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
 
       it 'should return the repo not found error' do
         r = github_repo.send(:repo_team_add, @response)
-        expect(r).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+        expect(r).to eql 'That repo (GrapeDuty/lita-test) was not found'
       end
     end
 
@@ -489,32 +501,30 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
   describe '.repo_team_rm' do
     before do
       match_data = { 'org' => github_org, 'repo' => 'lita-test', 'team' => 'HeckmanTest' }
-      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_rm_enabled: true)
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty')
       @response = double('Lita::Response', match_data: match_data)
       team = { id: 42, name: 'HeckmanTest' }
       allow(github_repo).to receive(:config).and_return(conf_obj)
+      allow(github_repo).to receive(:func_disabled?).and_return(false)
       allow(github_repo).to receive(:gh_team).with('GrapeDuty', 'HeckmanTest').and_return(team)
       allow(github_repo).to receive(:repo?).and_return(true)
       allow(github_repo).to receive(:repo_has_team?).and_return(true)
       allow(github_repo).to receive(:remove_team_from_repo).and_return('rtfr')
     end
 
-    context 'when function is disabled' do
-      before do
-        conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty', repo_team_rm_enabled: false)
-        allow(github_repo).to receive(:config).and_return(conf_obj)
-      end
-
-      it 'should return the method disabled error' do
+    context 'when valid inputs provided, and all things work out' do
+      it 'should return the text from remove_team_to_repo' do
         r = github_repo.send(:repo_team_rm, @response)
-        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+        expect(r).to eql 'rtfr'
       end
     end
 
-    context 'when valid inputs provided, and all things work out' do
-      it 'should return the text from remove_team_to_repo' do
+    context 'when function is disabled' do
+      before { allow(github_repo).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
         r = github_repo.send(:repo_team_rm, @response)
-        expect(r).to eql 'rtfr'
+        expect(r).to eql 'Sorry, this function has either been disabled or not enabled in the config'
       end
     end
 
@@ -523,7 +533,7 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
 
       it 'should return the repo not found error' do
         r = github_repo.send(:repo_team_rm, @response)
-        expect(r).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+        expect(r).to eql 'That repo (GrapeDuty/lita-test) was not found'
       end
     end
 
@@ -546,6 +556,121 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
     end
   end
 
+  describe '.repo_update_description' do
+    before do
+      match_data = { 'org' => github_org, 'repo' => 'lita-test', 'field' => 'description', 'content' => 'oh hello' }
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty')
+      @response = double('Lita::Response', match_data: match_data)
+      @octo_obj = double('Octokit::Client', edit_repository: { description: 'oh hello' })
+      allow(github_repo).to receive(:config).and_return(conf_obj)
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+      allow(github_repo).to receive(:func_disabled?).and_return(false)
+      allow(github_repo).to receive(:repo?).and_return(true)
+    end
+
+    context 'when valid inputs provided, and all things work out' do
+      it 'should respond that the description was updated' do
+        send_command('gh repo update description lita-test oh hello!')
+        expect(replies.last).to eql "The description for GrapeDuty/lita-test has been updated to: 'oh hello'"
+      end
+    end
+
+    context 'when function disabled' do
+      before { allow(github_repo).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
+        send_command('gh repo update description lita-test A new description!')
+        expect(replies.last).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+      end
+    end
+
+    context 'when repo not found' do
+      before { allow(github_repo).to receive(:repo?).and_return(false) }
+
+      it 'should return the repo not found error' do
+        send_command('gh repo update description lita-test A new description!')
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) was not found'
+      end
+    end
+
+    context 'when Octokit call explodes' do
+      before { allow(@octo_obj).to receive(:edit_repository).and_raise(StandardError.new) }
+
+      it 'should let us know things went a bit unexpected' do
+        send_command('gh repo update description lita-test A new description!')
+        expect(replies.last).to eql(
+          'An uncaught exception was hit while trying to update the description of ' \
+          'GrapeDuty/lita-test. Is GitHub having issues?'
+        )
+      end
+    end
+  end
+
+  describe '.repo_update_homepage' do
+    before do
+      match_data = { 'org' => github_org, 'repo' => 'lita-test', 'field' => 'homepage', 'content' => 'https://test.it' }
+      conf_obj = double('Lita::Configuration', default_org: 'GrapeDuty')
+      @response = double('Lita::Response', match_data: match_data)
+      @octo_obj = double('Octokit::Client', edit_repository: { homepage: 'https://test.it' })
+      allow(github_repo).to receive(:config).and_return(conf_obj)
+      allow(github_repo).to receive(:octo).and_return(@octo_obj)
+      allow(github_repo).to receive(:func_disabled?).and_return(false)
+      allow(github_repo).to receive(:repo?).and_return(true)
+    end
+
+    context 'when valid inputs provided, and all things work out' do
+      it 'should respond that the homepage was updated' do
+        send_command('gh repo update homepage lita-test https://test.it')
+        expect(replies.last).to eql "The homepage for GrapeDuty/lita-test has been updated to: 'https://test.it'"
+      end
+    end
+
+    context 'when function disabled' do
+      before { allow(github_repo).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
+        send_command('gh repo update homepage lita-test https://test.it')
+        expect(replies.last).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+      end
+    end
+
+    context 'when repo not found' do
+      before { allow(github_repo).to receive(:repo?).and_return(false) }
+
+      it 'should return the repo not found error' do
+        send_command('gh repo update homepage lita-test https://test.it')
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) was not found'
+      end
+    end
+
+    context 'when Octokit call explodes' do
+      before { allow(@octo_obj).to receive(:edit_repository).and_raise(StandardError.new) }
+
+      it 'should let us know things went a bit unexpected' do
+        send_command('gh repo update homepage lita-test https://test.it')
+        expect(replies.last).to eql(
+          'An uncaught exception was hit while trying to update the homepage of ' \
+          'GrapeDuty/lita-test. Is GitHub having issues?'
+        )
+      end
+    end
+
+    context 'when URL is invalid' do
+      before do
+        match_data = {
+          'org' => github_org, 'repo' => 'lita-test',
+          'field' => 'homepage', 'content' => 'https://test. it'
+        }
+        @response = double('Lita::Response', match_data: match_data)
+      end
+
+      it 'should return the invalid URL error' do
+        send_command('gh repo update homepage lita-test https://test. it')
+        expect(replies.last).to eql "The URL provided is not valid: 'https://test. it'"
+      end
+    end
+  end
+
   ####
   # Handlers
   ####
@@ -602,7 +727,7 @@ describe Lita::Handlers::GithubRepo, lita_handler: true do
 
       it 'should no-op informing you that the repo is not there' do
         send_command("gh repo delete #{github_org}/lita-test")
-        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) was not found'
       end
     end
   end
@@ -677,22 +802,32 @@ Name: Interns, Slug: interns, ID: 84, Perms: pull
 
       it 'should say the repo was not found' do
         send_command("gh repo teams #{github_org}/lita-test")
-        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) does not exist'
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) was not found'
       end
     end
   end
 
   describe '.repo_team_router' do
     before do
-      allow(github_repo).to receive(:repo_team_something)
-        .with(an_instance_of(Lita::Response)).and_return('ohai')
+      allow(github_repo).to receive(:repo_team_add).with(an_instance_of(Lita::Response)).and_return('ohai')
     end
 
     it 'should call the method based on action and respond with its return' do
-      expect(github_repo).to receive(:repo_team_add)
-        .with(an_instance_of(Lita::Response)).and_return('ohai')
+      expect(github_repo).to receive(:repo_team_add).with(an_instance_of(Lita::Response)).and_return('ohai')
       send_command("gh repo team add 42 #{github_org}/lita-test")
       expect(replies.last).to eql 'ohai'
     end
   end
+
+  describe '.repo_update_router' do
+    before do
+      allow(github_repo).to receive(:repo_update_description).with(an_instance_of(Lita::Response)).and_return('ohai')
+    end
+
+    it 'should call the method based on the action and respond with its return' do
+      expect(github_repo).to receive(:repo_update_description).with(an_instance_of(Lita::Response)).and_return('ohai')
+      send_command("gh repo update description #{github_org}/lita-test Something funky here")
+      expect(replies.last).to eql 'ohai'
+    end
+  end
 end

data/spec/unit/lita/handlers/github_spec.rb

@@ -49,6 +49,14 @@ describe Lita::Handlers::Github, lita_handler: true do
       expect(Lita.config.handlers.github.repo_team_rm_enabled).to be_falsey
     end
 
+    it 'should enale Lita::Handlers::GithubRepo.repo_update_description by default' do
+      expect(Lita.config.handlers.github.repo_update_description_enabled).to be_truthy
+    end
+
+    it 'should enale Lita::Handlers::GithubRepo.repo_update_homepage by default' do
+      expect(Lita.config.handlers.github.repo_update_homepage_enabled).to be_truthy
+    end
+
     it 'should enable Lita::Handlers::GithubPR.pr_merge by default' do
       expect(Lita.config.handlers.github.pr_merge_enabled).to be_truthy
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Tim Heckman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-12 00:00:00.000000000 Z
+date: 2014-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler