lita-github-pinger 0.9.7 → 0.9.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '094839bb6f04f078249882a02919475b3661c4b34811a9cb50e0401384eb3898'
-  data.tar.gz: ba0930b35cf5935f6706e297a657c765a60e79220cff83185fe22002995532e4
+  metadata.gz: 0bdd1e180e85f791f7dc861b0c6cc6f6d6a828c0d52eb0ee8ea95a071aa6cfb2
+  data.tar.gz: 45f5f8e03dbb33a06a12fdbb642f6ddc564b6abd0e12516531744a8489bba2e3
 SHA512:
-  metadata.gz: c4c5735aa6fa0f3c89b7b565ac5f12d8f73a0f3a57a25ff8a0b6f2ae62fb2460404ad6cf926922af883c1c067c0ade43f10760fdac6f0ede58977a3f537880e2
-  data.tar.gz: 368d4dba7ad19a30733749b09e2d72796bea574ebce9c761418cb448f36668ea6c3d16a2e113a9261d7297800a16025e5be63121fe40dda013cd4374aa5d4bcd
+  metadata.gz: '08079f6af45a95dd17270504b7a1a851ce696556b143bea79d51b5e4bc5959866cb293b7a12487ce21050cbd863b1b4001de453989a8684d49e8a1b7e0a6846c'
+  data.tar.gz: 883ca754f34895bb844c12f0dbe7985d807543f8fdbabc797c08f1e2e91fb38ac6529933e6a1f35dad8e17cdfe70aff91fac869f66dfa748f27973c1ccd4fda9

data/Gemfile

@@ -1,3 +1,4 @@
 source "https://rubygems.org"
+gem 'mlanett-redis-lock', require: 'redis-lock'
 
 gemspec

data/lib/lita/handlers/github_pinger.rb

@@ -171,46 +171,46 @@ module Lita
         puts "looking at previously notified reviewers for this PR"
 
         pr = body["pull_request"]
-
         url = pr["html_url"]
 
-        notified_engineers = redis.get(REVIEW_REDIS_KEY + ":" + url)
+        redis.lock() do |lock|
+          notified_engineers = redis.get(REVIEW_REDIS_KEY + ":" + url)
 
-        notified_engineers = if notified_engineers
-          JSON.parse(notified_engineers)
-        else
-          []
-        end
+          notified_engineers = if notified_engineers
+            JSON.parse(notified_engineers)
+          else
+            []
+          end
 
-        pr["requested_reviewers"].each do |reviewer|
-          engineer = find_engineer(github: reviewer["login"])
+          pr["requested_reviewers"].each do |reviewer|
+            engineer = find_engineer(github: reviewer["login"])
 
-          if !engineer
-            puts "Could not find engineer #{reviewer["login"]}"
-            next
-          end
+            if !engineer
+              puts "Could not find engineer #{reviewer["login"]}"
+              next
+            end
 
-          if notified_engineers.include?(reviewer["login"])
-            puts "#{reviewer["login"]} has already been notified to review PR, skipping..."
-            next
-          end
+            if notified_engineers.include?(reviewer["login"])
+              puts "#{reviewer["login"]} has already been notified to review PR, skipping..."
+              next
+            end
 
-          puts "#{engineer} determined as a reviewer."
+            puts "#{engineer} determined as a reviewer."
 
-          puts "Looking up preferences..."
-          should_notify = engineer[:github_preferences][:notify_about_review_requests]
+            puts "Looking up preferences..."
+            should_notify = engineer[:github_preferences][:notify_about_review_requests]
 
-          if !should_notify
-            puts "will not notify, preference for :github_preferences[:notify_about_review_requests] is not true"
-          else
-            message = "You've been asked to review a pull request:\n#{url}"
-            send_dm(engineer[:usernames][:slack], message)
-            notified_engineers.push(reviewer["login"])
+            if !should_notify
+              puts "will not notify, preference for :github_preferences[:notify_about_review_requests] is not true"
+            else
+              message = "You've been asked to review a pull request:\n#{url}"
+              send_dm(engineer[:usernames][:slack], message)
+              notified_engineers.push(reviewer["login"])
+            end
           end
-        end
-
-        redis.set(REVIEW_REDIS_KEY + ":" + url, notified_engineers.to_json)
 
+          redis.set(REVIEW_REDIS_KEY + ":" + url, notified_engineers.to_json)
+        end
         response
       end
 

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.9.7"
+  spec.version       = "0.9.8"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.9.8
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-30 00:00:00.000000000 Z
+date: 2018-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita