lita-github-pinger 0.9.6 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22a3c55423931d3500825fc7f3e82a427402c4a9402512aa74a84c98ce743554
-  data.tar.gz: 9f31cd68ecaabd1e1b5a8b41fcfdbc17547d1b169e9890e0e33786162369602a
+  metadata.gz: '094839bb6f04f078249882a02919475b3661c4b34811a9cb50e0401384eb3898'
+  data.tar.gz: ba0930b35cf5935f6706e297a657c765a60e79220cff83185fe22002995532e4
 SHA512:
-  metadata.gz: 8a105fc1e85ba1a43da53af7e1af47313a53a091a8ecff8422af215752d98a6c2d9552ce678c164891a392bea0568354ffd71b5dfef28544e577816f72991063
-  data.tar.gz: 47636bfc97048f6808c29f9d52016117c848d8235929b191cd0240d7cc93dd4c9c8513da017d758593494414d29271088f4e4e3e9bb50bd1469e2077ae74b1fd
+  metadata.gz: c4c5735aa6fa0f3c89b7b565ac5f12d8f73a0f3a57a25ff8a0b6f2ae62fb2460404ad6cf926922af883c1c067c0ade43f10760fdac6f0ede58977a3f537880e2
+  data.tar.gz: 368d4dba7ad19a30733749b09e2d72796bea574ebce9c761418cb448f36668ea6c3d16a2e113a9261d7297800a16025e5be63121fe40dda013cd4374aa5d4bcd

data/lib/lita/handlers/github_pinger.rb

@@ -1,6 +1,9 @@
+require 'json'
+
 module Lita
   module Handlers
     RR_REDIS_KEY = 'lita-github-pinger:roundrobin'.freeze
+    REVIEW_REDIS_KEY = 'lita-github-pinger:reviewrequests'.freeze
 
     class GithubPinger < Handler
 
@@ -165,13 +168,33 @@ module Lita
       def act_on_review_requested(body, response)
         puts "Detected a review request."
 
-        p body["pull_request"]
+        puts "looking at previously notified reviewers for this PR"
+
+        pr = body["pull_request"]
+
+        url = pr["html_url"]
+
+        notified_engineers = redis.get(REVIEW_REDIS_KEY + ":" + url)
+
+        notified_engineers = if notified_engineers
+          JSON.parse(notified_engineers)
+        else
+          []
+        end
+
+        pr["requested_reviewers"].each do |reviewer|
+          engineer = find_engineer(github: reviewer["login"])
 
-        reviewer = body["pull_request"]["requested_reviewer"]
+          if !engineer
+            puts "Could not find engineer #{reviewer["login"]}"
+            next
+          end
 
-        engineer = find_engineer(github: reviewer["login"])
+          if notified_engineers.include?(reviewer["login"])
+            puts "#{reviewer["login"]} has already been notified to review PR, skipping..."
+            next
+          end
 
-        if engineer
           puts "#{engineer} determined as a reviewer."
 
           puts "Looking up preferences..."
@@ -180,17 +203,14 @@ module Lita
           if !should_notify
             puts "will not notify, preference for :github_preferences[:notify_about_review_requests] is not true"
           else
-            url = body["pull_request"]["html_url"]
-
             message = "You've been asked to review a pull request:\n#{url}"
-
-            puts "Sending DM to #{engineer}..."
             send_dm(engineer[:usernames][:slack], message)
+            notified_engineers.push(reviewer["login"])
           end
-        else
-          puts "Could not find engineer #{reviewer["login"]}"
         end
 
+        redis.set(REVIEW_REDIS_KEY + ":" + url, notified_engineers.to_json)
+
         response
       end
 

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.9.6"
+  spec.version       = "0.9.7"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.9.6
+  version: 0.9.7
 platform: ruby
 authors:
 - Taylor Lapeyre