lita-github-pinger 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 24f8027c591f287e67c566c12de074b78419374b
-  data.tar.gz: 2c43fec1e9138ec89ae150d9ffc725d27bdc7fbe
+SHA256:
+  metadata.gz: 322d659976706040591b8a6adace708b6e62f993e4a9a2eeb9de11962313cd43
+  data.tar.gz: 267a815221c9c91ab85d08b132489557a0e637da78e6bccfb671fbb0dd37c15c
 SHA512:
-  metadata.gz: f4cfc8b1e864a6e99621e4e78270ff6b8ceef2e65100393cbdc0bc26c3ba9684456d1414d93d74f8978201889a1b14046812527f481ebd3423f0407d40a842dc
-  data.tar.gz: ccb7dff2e4cab3295634faec9db1b59445d20be31faa5189529c4dd2470de7217435f5e3cdbad4ed3132cc2f058ae02d91a48803cfec351616e1c3d631df1144
+  metadata.gz: bd1d060e1173b44d67146db57da5561651be71c931a3709cb246a27c50691a41523617123326a5f26da1022ceab31aa2681be850d99df375d414ebc8394a5588
+  data.tar.gz: '0769961ff55185d99db6b3b84f336a2d1face79a2aafcbf00de381e84b6c6beee99cdc356da5012ad12b2aaaa1943dd9a2bec5e9ae691e6a7d315f33004833c9'

data/README.md

@@ -2,12 +2,13 @@
 
 This is a Lita handler for pinging you about github events that you should know about.
 
-In particular, it will ping you under four circumstances (right now):
+In particular, it can ping you under four circumstances (right now):
 
 1. Somebody has commented on your pull request
 2. Somebody has @mentioned you through a comment on a pull request
 3. Somebody has assigned you to a pull request
-4. The status of your pull request was set to "failing"
+4. Somebody has requested a pull request review from you
+5. The status of your pull request was set to "failing"
 
 ## Installation
 
@@ -38,9 +39,11 @@ config.handlers.github_pinger.engineers = {
     },
     github_preferences: {
       frequency: "all_discussion",
+      notify_about_assignment: true,
+      notify_about_review_requests: true,
       location: "dm"
     },
-    travis_preferences: { # I know, not everybody uses travis - this will still work.
+    status_preferences: {
       frequency: "only_failures"
     }
   },

data/lib/lita/handlers/github_pinger.rb

@@ -16,7 +16,9 @@ module Lita
       #   },
       #   :github_preferences =>  {
       #     :frequency     => "only_mentions",
-      #     :ping_location => "dm"
+      #     :ping_location => "dm",
+      #     :notify_about_review_requests: true,
+      #     :notify_about_assignment: true,
       #   },
       #   :travis_preferences => {
       #     :frequency => "only_failures"
@@ -34,12 +36,12 @@ module Lita
       #  - "off"
       #  default: "all_discussion"
       #
-      # :travis_preferences[:frequency] can be
+      # :status_preferences[:frequency] can be
       #  - "only_passes"
       #  - "only_failures"
       #  - "everything"
       #  - "off"
-      #  default: "all_discussion"
+      #  default: "everything"
       config :engineers, type: Hash, required: true
       config :enable_round_robin, types: [TrueClass, FalseClass]
 
@@ -60,6 +62,10 @@ module Lita
           act_on_assign(body, response)
         end
 
+        if body["action"] && body["action"] == "review_requested"
+          act_on_review_requested(body, response)
+        end
+
         if body["action"] && body["action"] == "labeled"
           act_on_pr_labeled(body, response)
         end
@@ -77,12 +83,23 @@ module Lita
         commit_url = body["commit"]["html_url"]
         committer = find_engineer(github: body["commit"]["committer"]["login"])
 
-        puts "Detected a travis build failure for commit #{body["sha"]}"
-        message = ":x: Your commit failed some tests."
+        puts "Detected a status failure for commit #{body["sha"]}"
+        message = ":x: Your commit failed CI."
         message += "\n#{commit_url}"
 
-        return if ["off", "only_passes"].include?(committer[:travis_preferences][:frequency])
-        send_dm(committer[:usernames][:slack], message)
+        if committer
+          frequency = if committer[:travis_preferences]
+            committer[:travis_preferences][:frequency]
+          else
+            committer[:status_preferences][:frequency]
+          end
+
+          return if ["off", "only_passes"].include?(frequency)
+
+          send_dm(committer[:usernames][:slack], message)
+        else
+          puts "Could not find configuration for GitHub username " + body["commit"]["committer"]["login"]}
+        end
 
         response
       end
@@ -91,12 +108,23 @@ module Lita
         commit_url = body["commit"]["html_url"]
         committer = find_engineer(github: body["commit"]["committer"]["login"])
 
-        puts "Detected a travis build success for commit #{body["sha"]}"
-        message = ":white_check_mark: Your commit has passed its travis build."
+        puts "Detected a status success for commit #{body["sha"]}"
+        message = ":white_check_mark: Your commit has passed CI."
         message += "\n#{commit_url}"
 
-        return if ["off", "only_failures"].include?(committer[:travis_preferences][:frequency])
-        send_dm(committer[:usernames][:slack], message)
+        if committer
+          frequency = if committer[:travis_preferences]
+            committer[:travis_preferences][:frequency]
+          else
+            committer[:status_preferences][:frequency]
+          end
+
+          return if ["off", "only_failures"].include?(frequency)
+
+          send_dm(committer[:usernames][:slack], message)
+        else
+          puts "Could not find configuration for GitHub username " + body["commit"]["committer"]["login"]}
+        end
 
         response
       end
@@ -105,18 +133,26 @@ module Lita
         type = detect_type(body)
 
         if type.nil?
-          puts 'Neither pull request or issue detected, exiting...'
+          puts "Neither pull request or issue detected, exiting..."
           return
         end
 
         puts "Detected that someone got assigned to a #{type.tr('_', ' ')}."
 
-        assignee_login = body[type]['assignee']['login']
+        assignee_login = body[type]["assignee"]["login"]
         assignee = find_engineer(github: assignee_login)
 
+        puts "Looking up preferences..."
+        should_notify = assignee[:github_preferences][:notify_about_assignment]
+
+        if !should_notify
+          puts "will not notify, preference for :github_preferences[:notify_about_assignment] is not true"
+          return response
+        end
+
         puts "#{assignee} determined as the assignee."
 
-        url = body[type]['html_url']
+        url = body[type]["html_url"]
 
         message = "*Heads up!* You've been assigned to review a #{type.tr('_', ' ')}:\n#{url}"
 
@@ -126,17 +162,49 @@ module Lita
         response
       end
 
+      def act_on_review_requested(body, response)
+        puts "Detected a review request."
+
+        reviewers = body["pull_request"]["requested_reviewers"]
+
+        reviewers.each do |reviewer|
+          engineer = find_engineer(github: reviewer["login"])
+
+          if engineer
+            puts "#{engineer} determined as a reviewer."
+
+            puts "Looking up preferences..."
+            should_notify = engineer[:github_preferences][:notify_about_review_requests]
+
+            if !should_notify
+              puts "will not notify, preference for :github_preferences[:notify_about_review_requests] is not true"
+            else
+              url = body["pull_request"]["html_url"]
+
+              message = "You've been asked to review a pull request:\n#{url}"
+
+              puts "Sending DM to #{engineer}..."
+              send_dm(engineer[:usernames][:slack], message)
+            end
+          else
+            puts "Could not find engineer #{reviewer["login"]}"
+          end
+        end
+
+        response
+      end
+
       def act_on_pr_labeled(body, response)
         type = detect_type(body)
         puts "Detected that someone labeled a #{type.tr('_', ' ')}."
 
         if type.nil?
-          puts 'Neither pull request or issue detected, exiting...'
+          puts "Neither pull request or issue detected, exiting..."
           return
         end
 
         if body["pull_request"]["labels"].none? { |label| label["name"].downcase.include?('review') }
-          puts 'Labels do not include a review label, exiting...'
+          puts "Labels do not include a review label, exiting..."
           return
         end
 
@@ -155,7 +223,7 @@ module Lita
 
           puts "#{chosen_reviewer} determined as the reviewer."
 
-          url = body[type]['html_url']
+          url = body[type]["html_url"]
 
           message_for_reviewer = "You're next in line to review a PR! Please review, or assign to an engineer with more context if you think you are unable to give a thorough review. \n#{url}"
           message_for_owner = "#{chosen_reviewer} has been notified via round-robin to review #{body["pull_request"]["html_url"]}"
@@ -211,8 +279,8 @@ module Lita
 
           # get each @mentioned engineer in the comment
           mentions = comment
-            .split('@')[1..-1] # "a @b @c d" => ["b ", "c d"]
-            .map { |snip| snip.split(' ').first } # ["b ", "c d"] => ["b", "c"]
+            .split("@")[1..-1] # "a @b @c d" => ["b ", "c d"]
+            .map { |snip| snip.split(" ").first } # ["b ", "c d"] => ["b", "c"]
             .map { |name| name.gsub(/[^0-9a-z\-_]/i, '') }
 
           puts "Done. Got #{mentions}"
@@ -310,10 +378,10 @@ module Lita
       end
 
       def detect_type(body)
-        if body['pull_request']
-          'pull_request'
-        elsif body['issue']
-          'issue'
+        if body["pull_request"]
+          "pull_request"
+        elsif body["issue"]
+          "issue"
         end
       end
     end

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.8.0"
+  spec.version       = "0.9.0"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-15 00:00:00.000000000 Z
+date: 2018-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -134,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Lita handler that detects github comment notifications and regurgitates