lita-github-pinger 0.3.6 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: edb3e251d49bce421fdbb52dac861ee107d11f1b
-  data.tar.gz: f51cbd8c58841d51a56c82c95b5d2c96743de0fc
+  metadata.gz: 532eb6b451efd5fedee4eecbbbffe2b942701704
+  data.tar.gz: c0de7f549078d94d25e5f021b9d0131957d2e120
 SHA512:
-  metadata.gz: ec3b49c4cc4340f7100230aa5b7d9ce5fb176cdd7f4d54d94e60be11f5010b6e1555b7a8613d9a7c70df67946fa6268f929a11c570aa7459577c5d7e4e8812de
-  data.tar.gz: 8e40199e6bb6ea34c61019b22cae6cbb051c62137699d453d20f71544b0f7fcc871b2651ade1f870bd7b8d012c70423011d769508442348b36fd5e85baf2a6f9
+  metadata.gz: 9ad21d6f34d595e9f50a1a099cae63b248ac52316c1c8c977534ded78c1a301dff9b9fb54bb66cc8a8ed461202cdc0baa41abec7c703b4009370ed4d321a1875
+  data.tar.gz: ac6abe1e6963aea188aa9fadf88c735732d668dfe4175ba459816f73dbd704f0620b1f248b8c1bddc6816da3c294d623e4491b86ba7240f9a1236f8ac4878945

data/lib/lita/handlers/github_pinger.rb

@@ -12,32 +12,34 @@ module Lita
         body = MultiJson.load(request.body)
 
         if body["comment"]
+          thing     = body["pull_request"] || body["issue"]
+          pr_url    = thing["html_url"]
+          comment   = body["comment"]["body"]
+          commenter = body["comment"]["user"]["login"]
 
-          thing = body["pull_request"] || body["issue"]
+          # automatically include the creator of the PR
+          usernames_to_ping = [thing["user"]["login"]]
 
-          pr_url = thing["html_url"]
-          pr_owner = thing["user"]["login"]
-          commenter = body["comment"]["user"]["login"]
-          comment = body["comment"]["body"].split("\n").join("\n >")
+          # Is anyone mentioned in this comment?
+          if comment.include?("@")
+            # get each @mentioned username in the comment
+            mentions = comment.split("@")[1..-1].map { |snip| snip.split(" ").first }
 
-          pr_owner = config.engineers.select do |eng|
-            eng[:github] == pr_owner
-          end.first[:slack]
+            # add them to the list of usernames to ping
+            usernames_to_ping = usernames_to_ping.concat(mentions).uniq
 
-          commenter = config.engineers.select do |eng|
-            eng[:github] == commenter
-          end.first[:slack]
+            # slackify all of the users
+            usernames_to_ping.map! { |user| github_username_to_slack_username(user) }
+          end
 
           message  = "New PR comment from #{commenter}:\n"
-          message += "#{pr_url}\n> #{comment}"
-
-          puts "Got a comment on something, sending message to #{pr_owner}"
+          message += "#{pr_url}\n#{comment}"
 
-          send_dm(pr_owner, message)
+          puts "Got a comment on something, sending messages to #{usernames_to_ping}"
 
+          usernames_to_ping.each { |user| send_dm(user, message) }
         end
 
-
         response
       end
 
@@ -47,6 +49,12 @@ module Lita
         robot.send_message(source, message)
       end
 
+      def github_username_to_slack_username(github_username)
+        config.engineers.select do |eng|
+          eng[:github] == github_username
+        end.first[:slack]
+      end
+
       def send_dm(username, content)
         if user = Lita::User.fuzzy_find(username)
           source = Lita::Source.new(user: user)

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.3.6"
+  spec.version       = "0.3.7"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.3.7
 platform: ruby
 authors:
 - Taylor Lapeyre