lita-dig 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac579e71c1e85388d7cb92499358dabc99a41c67
-  data.tar.gz: 88f2c620d56a7a6a9331ba39219ff4a09c4eb01a
+  metadata.gz: b2c5d0cb894f600dbdf8221e3ae8fe33b2e4717c
+  data.tar.gz: deaa8b50b4b4186299680ffc494cb22090bebb3b
 SHA512:
-  metadata.gz: 422fc02b081b420758d9f35aee089ed5ba78b571cfcea63f039575f3720b650e580406a0758b7268094ec956e616c1836920d388504df8ef1d3234b026edfec3
-  data.tar.gz: ee3aa1c579a6a10407201495e1ad68bf25eded2e04255567dc9bd6a55a8b7de94e934bd6d9c498c734af9558fb0ca9f5b509ae238b5c58e295184fc63a37ca9e
+  metadata.gz: 0f8e05228af35ef6a4b8a658e0dbd369ee8b9624a7ecb6aede8684c8997cc32ac78169c22841b3220e9e299307cc6c559ad54e4e0e09b7dce9f02a54bd4e553e
+  data.tar.gz: 152849c05aba7d73e7dbee87bb2c94a9258d876d60a5c1c19c391a6bd4669a2f65b44ef7a2e794623d930f27c3bc4feb744b189337221e61b7f57348e3d0ffd9

data/.rspec

@@ -0,0 +1 @@
+--color --profile 5

data/lib/lita-dig.rb

@@ -5,5 +5,8 @@ Lita.load_locales Dir[File.expand_path(
 )]
 
 require 'net/dns'
-
 require 'lita/handlers/dig'
+
+Lita::Handlers::Dig.template_root File.expand_path(
+  File.join('..', '..', 'templates'), __FILE__
+)

data/lib/lita/handlers/dig.rb

@@ -29,6 +29,7 @@ module Lita
         type     = (response.match_data['type'] || 'a').strip
         short    = response.match_data['short']
         result   = lookup(record, type, resolver)
+
         response.reply(format_lookup(result, short))
       end
 
@@ -36,8 +37,8 @@ module Lita
 
       def lookup(argument, type, server = nil)
         return t('error.unknown_type') unless DNS_TYPES.include?(type.downcase)
-        type = Object.const_get('Net::DNS::' + type.upcase)
 
+        type = Object.const_get('Net::DNS::' + type.upcase)
         resolver = Net::DNS::Resolver.new
         resolver.nameservers = server unless server.nil?
 
@@ -49,15 +50,8 @@ module Lita
       end
 
       def format_lookup(lookup, compact = false)
-        result = ''
-        if compact
-          lookup.each_address do |ip|
-            result += "#{ip}\n"
-          end
-        else
-          result = lookup.to_s
-        end
-        result
+        compact ? template = 'compact' : template = 'full'
+        render_template(template, lookup: lookup)
       end
     end
 

data/lita-dig.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-dig'
-  spec.version       = '1.2.0'
+  spec.version       = '1.3.0'
   spec.authors       = ['Eric Sigler']
   spec.email         = ['me@esigler.com']
   spec.description   = 'A DNS record lookup plugin for Lita'
-  spec.summary       = 'A DNS record lookup plugin for Lita'
+  spec.summary       = spec.description
   spec.homepage      = 'https://github.com/esigler/lita-dig'
   spec.license       = 'MIT'
   spec.metadata      = { 'lita_plugin_type' => 'handler' }
@@ -14,13 +14,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'lita', '>= 4.0'
+  spec.add_runtime_dependency 'lita', '>= 4.2'
   spec.add_runtime_dependency 'net-dns2'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '>= 3.0.0'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'simplecov'
 end

data/spec/lita/handlers/dig_spec.rb

@@ -31,7 +31,9 @@ describe Lita::Handlers::Dig, lita_handler: true do
 
   let(:resolve_short) do
     list = double
-    allow(list).to receive(:each_address).and_yield('1.2.3.4')
+    allow(list).to receive(:each_address)
+      .and_yield('1.2.3.4')
+      .and_yield('5.6.7.8')
     client = double
     allow(client).to receive(:nameservers=) { '' }
     expect(client).to receive(:query) { list }
@@ -58,7 +60,7 @@ describe Lita::Handlers::Dig, lita_handler: true do
     it 'shows a short record if the domain exists' do
       expect(Net::DNS::Resolver).to receive(:new) { resolve_short }
       send_command('dig example.com +short')
-      expect(replies.last).to eq("1.2.3.4\n")
+      expect(replies.last).to eq("1.2.3.4\n5.6.7.8\n")
     end
 
     it 'shows a warning if the domain does not exist' do
@@ -89,7 +91,7 @@ describe Lita::Handlers::Dig, lita_handler: true do
        x25 isdn rt nsap nsapptr sig key px gpos aaaa loc nxt eid nimloc srv
        atma naptr kx cert dname opt ds sshfp rrsig nsec dnskey uinfo uid gid
        unspec tkey tsig ixfr axfr mailb maila any).each do |type|
-      it 'resolves a record with a particular type' do
+      it "resolves a record with the #{type} type" do
         expect(Net::DNS::Resolver).to receive(:new) { resolve }
         send_command("dig example.com #{type}")
         expect(replies.last).to eq('Generic A response example.com')

data/spec/spec_helper.rb

@@ -10,3 +10,20 @@ require 'lita-dig'
 require 'lita/rspec'
 
 Lita.version_3_compatibility_mode = false
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+  config.default_formatter = 'doc' if config.files_to_run.one?
+  config.order = :random
+
+  Kernel.srand config.seed
+end

data/templates/compact.erb

@@ -0,0 +1,3 @@
+<% @lookup.each_address do |ip| %>
+<%= "#{ip}\n" %>
+<% end %>

data/templates/compact.hipchat.erb

@@ -0,0 +1,3 @@
+<% @lookup.each_address do |ip| %>
+/code <%= ip %>
+<% end %>

data/templates/compact.slack.erb

@@ -0,0 +1,3 @@
+<% @lookup.each_address do |ip| %>
+`<%= ip %>`
+<% end %>

data/templates/full.erb

@@ -0,0 +1 @@
+<%= @lookup %>

data/templates/full.hipchat.erb

@@ -0,0 +1 @@
+/quote <%= @lookup %>

data/templates/full.slack.erb

@@ -0,0 +1 @@
+```<%= @lookup %>```

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-dig
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Eric Sigler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-21 00:00:00.000000000 Z
+date: 2015-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: net-dns2
   requirement: !ruby/object:Gem::Requirement
@@ -42,18 +42,18 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,21 +67,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
 - CONTRIBUTING.md
@@ -143,6 +144,12 @@ files:
 - locales/en.yml
 - spec/lita/handlers/dig_spec.rb
 - spec/spec_helper.rb
+- templates/compact.erb
+- templates/compact.hipchat.erb
+- templates/compact.slack.erb
+- templates/full.erb
+- templates/full.hipchat.erb
+- templates/full.slack.erb
 homepage: https://github.com/esigler/lita-dig
 licenses:
 - MIT