lita-deploygate 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 477a51d7644b360d5cf0dbf25f20745ad017d3bd
-  data.tar.gz: 9a2003bfed68731cc1820ce86d2fd73deacb9bc1
+  metadata.gz: 38bbbee6ec20f8cce043f2d1c759d30261d86a28
+  data.tar.gz: e74f13293333bd906f036842e15595d2a6a08428
 SHA512:
-  metadata.gz: a6b32a9bdcd887642b0a541e96953700a2f1390837ceef6dab775e0c3da1723b782550fea380d0dbeb0342d2fb5441108b1ad0827a1a7a6ddd10a05514e31613
-  data.tar.gz: 3bd7e9f3086be31a0428b8b7a6c6bd493b7c12c7b0ad3c7ce5885a16a34237933a660575e4747b84af842e1e7c8613c8ed8b6ac5eadae51fb507c0cde62b9348
+  metadata.gz: 8f302790c5949e94eeff407e35b8275035a8e18e2e2dfe801874aec617192c582730593d0bcf8a4586c723055f98c317e6e6b55f8868a92cf3b7182fd7cb62b8
+  data.tar.gz: b3999b0c146778044f4a29a018ecfc9bc31d85768fd17362efa108ef86d1753dc4dd2c6dd3d53585a5d9a59f5ff9d3610237aa45548e8849fe6d7d0a24e3d1ac

data/.gitignore

@@ -1,5 +1,6 @@
 *.gem
 *.rbc
+*.swp
 .bundle
 .config
 .yardoc

data/.rubocop.yml

@@ -1,17 +1,7 @@
-ClassLength:
-  Max: 400
-
-CyclomaticComplexity:
-  Max: 10
-
 Documentation:
-  Enabled: false
+  Exclude:
+    - lib/lita/handlers/deploygate.rb
 
 FileName:
-  Enabled: false
-
-LineLength:
-  Max: 105
-
-MethodLength:
-  Max: 30
+  Exclude:
+    - lib/lita-deploygate.rb

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
-  - 2.0.0
-script: bundle exec rake
-before_install:
-  - gem update --system
+  - 2.1
+  - 2.2
 services:
   - redis-server
+sudo: false
+cache: bundler

data/Gemfile

@@ -1,3 +1,3 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 gemspec

data/README.md

@@ -7,7 +7,7 @@
 [![Code Climate](https://img.shields.io/codeclimate/github/esigler/lita-deploygate.svg)](https://codeclimate.com/github/esigler/lita-deploygate)
 [![Gemnasium](https://img.shields.io/gemnasium/esigler/lita-deploygate.svg)](https://gemnasium.com/esigler/lita-deploygate)
 
-DeployGate (http://deploygate.com) handler for inviting and removing application collaborators.
+A [Deploygate](http://deploygate.com) plugin for [Lita](https://github.com/jimmycuadra/lita).
 
 ## Installation
 

data/Rakefile

@@ -3,6 +3,6 @@ require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
-Rubocop::RakeTask.new(:rubocop)
+RuboCop::RakeTask.new(:rubocop)
 
-task default: [ :spec, :rubocop ]
+task default: [:spec, :rubocop]

data/lib/lita/handlers/deploygate.rb

@@ -1,13 +1,16 @@
 module Lita
   module Handlers
     class Deploygate < Handler
+      config :user_name, required: true
+      config :api_key, required: true
+      config :app_names
+
       route(
         /^(deploygate|dg)\sadd\s(\S+)\s(\S+)$/,
         :add,
         command: true,
         help: {
-          'deploygate add <username or email> <short name>' =>
-          'Add <username or email> to <short name>'
+          t('help.add_key') => t('help.add_value')
         }
       )
 
@@ -16,8 +19,7 @@ module Lita
         :remove,
         command: true,
         help: {
-          'deploygate remove <username or email> <short name>' =>
-          'Remove <username or email> from <short name>'
+          t('help.remove_key') => t('help.remove_value')
         }
       )
 
@@ -26,74 +28,53 @@ module Lita
         :list,
         command: true,
         help: {
-          'deploygate list <short name>' =>
-          'List all users associated with <short name>'
+          t('help.list_key') => t('help.list_value')
         }
       )
 
-      def self.default_config(config)
-        config.user_name      = nil
-        config.api_key        = nil
-        config.default_app_id = nil
-      end
-
       def add(response)
-        short_name = response.matches[0][2]
-        user_identifier = response.matches[0][1]
-        if valid_app_name?(short_name)
-          result = api_request('post',
-                               "/#{app_path(short_name)}/members",
-                               'users' => "[#{user_identifier}]")
-          if result
-            response.reply("#{short_name}: #{user_identifier} added")
-          else
-            response.reply('There was an error making the request to DeployGate')
-          end
-        else
-          response.reply("#{short_name}: unknown application name")
-        end
+        app = response.matches[0][2]
+        user = response.matches[0][1]
+        response.reply(change(app, 'post', 'add.success', user))
       end
 
       def remove(response)
-        short_name = response.matches[0][2]
-        user_identifier = response.matches[0][1]
-        if valid_app_name?(short_name)
-          result = api_request('delete',
-                               "/#{app_path(short_name)}/members",
-                               'users' => "[#{user_identifier}]")
-          if result
-            response.reply("#{short_name}: #{user_identifier} removed")
-          else
-            response.reply('There was an error making the request to DeployGate')
-          end
-        else
-          response.reply("#{short_name}: unknown application name")
-        end
+        app = response.matches[0][2]
+        user = response.matches[0][1]
+        response.reply(change(app, 'delete', 'remove.success', user))
       end
 
+      # rubocop:disable Metrics/AbcSize
       def list(response)
-        short_name = response.matches[0][1]
-        if valid_app_name?(short_name)
-          result = api_request('get', "/#{app_path(short_name)}/members")
-          if result
-            users = result['results']['users']
-            if users.count > 0
-              users.each do |user|
-                response.reply("#{short_name}: #{user['name']}, role: #{user['role']}")
-              end
-            else
-              response.reply("#{short_name}: No users")
-            end
-          else
-            response.reply('There was an error making the request to DeployGate')
-          end
-        else
-          response.reply("#{short_name}: unknown application name")
+        app = response.matches[0][1]
+        users = members(app)
+        return response.reply(users) unless users.is_a? Array
+        return response.reply(t('list.none', app: app)) unless users.count > 0
+        users.each do |user|
+          response.reply(t('list.user', app: app, user: user['name'],
+                                        role: user['role']))
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       private
 
+      def change(app, method, success_key, user)
+        return t('error.unknown_app', app: app) unless valid_app_name?(app)
+        result = api_request(method,
+                             "/#{app_path(app)}/members",
+                             'users' => "[#{user}]")
+        return t('error.request') unless result
+        t(success_key, app: app, user: user)
+      end
+
+      def members(app)
+        return t('error.unknown_app', app: app) unless valid_app_name?(app)
+        result = api_request('get', "/#{app_path(app)}/members")
+        return t('error.request') unless result
+        result['results']['users']
+      end
+
       def valid_app_name?(name)
         Lita.config.handlers.deploygate.app_names.key?(name)
       end
@@ -102,33 +83,23 @@ module Lita
         Lita.config.handlers.deploygate.app_names[name]
       end
 
+      # rubocop:disable Metrics/AbcSize
       def api_request(method, component, args = {})
-        if Lita.config.handlers.deploygate.user_name.nil? ||
-           Lita.config.handlers.deploygate.api_key.nil?
-          Lita.logger.error('Missing API key or Page ID for Deploygate')
-          fail 'Missing config'
-        end
-
-        url = "https://deploygate.com/api/users/" \
-              "#{Lita.config.handlers.deploygate.user_name}" \
-              "#{component}"
-
-        args['token'] = Lita.config.handlers.deploygate.api_key
+        url = "https://deploygate.com/api/users/#{config.user_name}#{component}"
+        args['token'] = config.api_key
 
         http_response = http.send(method) do |req|
           req.url url, args
         end
 
-        if http_response.status == 200 ||
-           http_response.status == 201
-          MultiJson.load(http_response.body)
-        else
-          Lita.logger.error("HTTP #{method} for #{url} with #{args} " \
-                            "returned #{http_response.status}")
-          Lita.logger.error(http_response.body)
-          nil
+        unless http_response.status == 200 || http_response.status == 201
+          log.error("#{method}:#{component}:#{args}:#{http_response.status}")
+          return nil
         end
+
+        MultiJson.load(http_response.body)
       end
+      # rubocop:enable Metrics/AbcSize
     end
 
     Lita.register_handler(Deploygate)

data/lita-deploygate.gemspec

@@ -1,20 +1,20 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-deploygate'
-  spec.version       = '0.1.0'
+  spec.version       = '0.1.1'
   spec.authors       = ['Eric Sigler']
   spec.email         = ['me@esigler.com']
-  spec.description   = %q{Add, remove members to Deploygate releases}
-  spec.summary       = %q{Add, remove members to Deploygate releases}
+  spec.description   = 'A Deploygate plugin for Lita'
+  spec.summary       = 'A Deploygate plugin for Lita'
   spec.homepage      = 'http://github.com/esigler/lita-deploygate'
   spec.license       = 'MIT'
   spec.metadata      = { 'lita_plugin_type' => 'handler' }
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables   = spec.files.grep(%r{^bin\/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)\/})
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'lita', '>= 3.1'
+  spec.add_runtime_dependency 'lita', '>= 4.0'
   spec.add_runtime_dependency 'multi_json'
 
   spec.add_development_dependency 'bundler', '~> 1.3'

data/locales/en.yml

@@ -2,3 +2,20 @@ en:
   lita:
     handlers:
       deploygate:
+        add:
+          success: "%{app}: %{user} added"
+        error:
+          request: There was an error making the request to DeployGate
+          unknown_app: "%{app}: unknown application name"
+        help:
+          add_key: deploygate add <username or email> <short name>
+          add_value: Add <username or email> to <short name>
+          list_key: deploygate list <short name>
+          list_value: List all users associated with <short name>
+          remove_key: deploygate remove <username or email> <short name>
+          remove_value: Remove <username or email> from <short name>
+        list:
+          none: "%{app}: No users"
+          user: "%{app}: %{user}, role: %{role}"
+        remove:
+          success: "%{app}: %{user} removed"

data/spec/lita/handlers/deploygate_spec.rb

@@ -17,33 +17,21 @@ describe Lita::Handlers::Deploygate, lita_handler: true do
     File.read('spec/files/members_remove.json')
   end
 
-  it { routes_command('deploygate add username abc123').to(:add) }
-  it { routes_command('deploygate add foo@example.com abc123').to(:add) }
-  it { routes_command('deploygate remove username abc123').to(:remove) }
-  it { routes_command('deploygate remove foo@example.com abc123').to(:remove) }
-  it { routes_command('deploygate list abc123').to(:list) }
-  it { routes_command('dg add username abc123').to(:add) }
-  it { routes_command('dg remove username abc123').to(:remove) }
-  it { routes_command('dg list abc123').to(:list) }
-
-  describe '.default_config' do
-    it 'sets user_name to nil' do
-      expect(Lita.config.handlers.deploygate.user_name).to be_nil
-    end
-
-    it 'sets api_key to nil' do
-      expect(Lita.config.handlers.deploygate.api_key).to be_nil
-    end
-
-    it 'sets app_names to nil' do
-      expect(Lita.config.handlers.deploygate.app_names).to be_nil
-    end
+  def grab_request(method, status, body)
+    response = double('Faraday::Response', status: status, body: body)
+    expect_any_instance_of(Faraday::Connection).to \
+      receive(method.to_sym).and_return(response)
   end
 
-  describe 'without valid config' do
-    it 'errors out on any command' do
-      Lita.config.handlers.deploygate.app_names = { 'abc123' => 'path/to/places' }
-      expect { send_command('dg list abc123') }.to raise_error('Missing config')
+  %w(deploygate dg).each do |name|
+    it do
+      is_expected.to route_command("#{name} add username abc123").to(:add)
+      is_expected.to route_command("#{name} add foo@example.com abc123")
+        .to(:add)
+      is_expected.to route_command("#{name} remove username abc123").to(:remove)
+      is_expected.to route_command("#{name} remove foo@example.com abc123")
+        .to(:remove)
+      is_expected.to route_command("#{name} list abc123").to(:list)
     end
   end
 
@@ -51,90 +39,85 @@ describe Lita::Handlers::Deploygate, lita_handler: true do
     before do
       Lita.config.handlers.deploygate.user_name = 'foo'
       Lita.config.handlers.deploygate.api_key = 'bar'
-      Lita.config.handlers.deploygate.app_names = { 'abc123' => 'path/to/places' }
+      Lita.config.handlers.deploygate.app_names = { 'abc123' =>
+                                                    'path/to/places' }
     end
 
     describe '#add' do
       it 'shows an ack when a username is added' do
-        response = double('Faraday::Response', status: 200, body: members_add)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+        grab_request('post', 200, members_add)
         send_command('deploygate add username abc123')
         expect(replies.last).to eq('abc123: username added')
       end
 
       it 'shows an ack when an email is added' do
-        response = double('Faraday::Response', status: 200, body: members_add)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+        grab_request('post', 200, members_add)
         send_command('deploygate add foo@example.com abc123')
         expect(replies.last).to eq('abc123: foo@example.com added')
       end
 
-      it 'shows a warning if the short name does not exist when adding someone' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate add username doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue adding someone' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:post).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('post', 500, nil)
         send_command('deploygate add username abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
 
     describe '#remove' do
       it 'shows an ack when a username is removed' do
-        response = double('Faraday::Response', status: 200, body: members_remove)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+        grab_request('delete', 200, members_remove)
         send_command('deploygate remove username abc123')
         expect(replies.last).to eq('abc123: username removed')
       end
 
       it 'shows an ack when an email is removed' do
-        response = double('Faraday::Response', status: 200, body: members_remove)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+        grab_request('delete', 200, members_remove)
         send_command('deploygate remove foo@example.com abc123')
         expect(replies.last).to eq('abc123: foo@example.com removed')
       end
 
-      it 'shows a warning if the short name does not exist when removing someone' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate remove username doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue removing someone' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:delete).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('delete', 500, nil)
         send_command('deploygate remove username abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
 
     describe '#list' do
       it 'shows a list of users when there are any' do
-        response = double('Faraday::Response', status: 200, body: members_full)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+        grab_request('get', 200, members_full)
         send_command('deploygate list abc123')
         expect(replies.last).to eq('abc123: username, role: 1')
       end
 
       it 'shows an empty list of users when there arent any' do
-        response = double('Faraday::Response', status: 200, body: members_empty)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+        grab_request('get', 200, members_empty)
         send_command('deploygate list abc123')
         expect(replies.last).to eq('abc123: No users')
       end
 
-      it 'shows a warning if the short name does not exist when listing' do
+      it 'shows a warning if the app name does not exist' do
         send_command('deploygate list doesnotexist')
         expect(replies.last).to eq('doesnotexist: unknown application name')
       end
 
-      it 'shows an error if there was an issue listing users' do
-        response = double('Faraday::Response', status: 500, body: nil)
-        expect_any_instance_of(Faraday::Connection).to receive(:get).once.and_return(response)
+      it 'shows an error if there was an issue with the request' do
+        grab_request('get', 500, nil)
         send_command('deploygate list abc123')
-        expect(replies.last).to eq('There was an error making the request to DeployGate')
+        expect(replies.last).to eq('There was an error making the request ' \
+                                   'to DeployGate')
       end
     end
   end

data/spec/spec_helper.rb

@@ -8,3 +8,5 @@ SimpleCov.start { add_filter '/spec/' }
 
 require 'lita-deploygate'
 require 'lita/rspec'
+
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-deploygate
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Eric Sigler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-12 00:00:00.000000000 Z
+date: 2016-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Add, remove members to Deploygate releases
+description: A Deploygate plugin for Lita
 email:
 - me@esigler.com
 executables: []
@@ -168,10 +168,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: Add, remove members to Deploygate releases
+summary: A Deploygate plugin for Lita
 test_files:
 - spec/files/members_add.json
 - spec/files/members_empty.json