lita-buildkite 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f2d6d1cbb193523fc730a4fca088c95df973b850
-  data.tar.gz: 0c7b5cb7886c4d1c158b171a4ede9691ee44cbc6
+SHA256:
+  metadata.gz: 953eff0635c21e6f0ba534ae8f83f2e03f25e8bb3601df454ab4a6a4deba7884
+  data.tar.gz: 3445aeec102832ad704e80e1dee4be328d22cc40311956bea6fa8d5966f8c3af
 SHA512:
-  metadata.gz: bc9b1cd17771c91682069cb3b95055bc3d5297ee9b1ce3e38f09ff4e12097f3d38ce7fe230a8ec26df5a25bbab2cec313e6b422df6455172b0d49c2957a19620
-  data.tar.gz: f5aa95d1bafa05f914d192e4ee24ddd059454028ddfc67fc752d3ce7ebfd076be65aab089ac06ebe832bb6943cd3e6787a6e57101f556513730679babbfb9a90
+  metadata.gz: b8f366eba228d5c038f4e101c51fdcac0865ffa878af7fb0a55e5bda3196d27e8ac53b06f1c540bad6a218b96040b29f34d98788a716488abff1b65d67994104
+  data.tar.gz: f2937b54070e20ae5364ba75d97b884fe05cb3177c5a51c4f00803fe26df3e6804dc93b3a5cb6301bd82de91ef233982def94b99a3c4d5f8d6c969fbd7b32ba6

data/lib/lita/build_status_report.rb

@@ -0,0 +1,26 @@
+class BuildStatusReport
+  def initialize(event, days_since_last_failure, prev_days_since_last_failure, most_successful_days)
+    @event = event
+    @days_since_last_failure = days_since_last_failure
+    @prev_days_since_last_failure = prev_days_since_last_failure
+    @most_successful_days = most_successful_days
+
+    yield message if message
+  end
+
+  private
+
+  def message
+    @message ||= begin
+      if @days_since_last_failure > @prev_days_since_last_failure
+        "#{@event.pipeline} is #{@days_since_last_failure} days without a failure"
+      elsif @days_since_last_failure < @prev_days_since_last_failure
+        if @prev_days_since_last_failure >= @most_successful_days
+          "#{@event.pipeline} ended it's record breaking run of #{@prev_days_since_last_failure} days without a failure 😢"
+        else
+          "#{@event.pipeline} failed after #{@prev_days_since_last_failure} days, previous best was #{@most_successful_days}"
+        end
+      end
+    end
+  end
+end

data/lib/lita/buildkite_build_finished_event.rb

@@ -29,6 +29,10 @@ class BuildkiteBuildFinishedEvent
     @data.fetch("pipeline", {}).fetch("slug", "")
   end
 
+  def build_web_url
+    @data.fetch("build", {}).fetch("web_url", "")
+  end
+
   def passed?
     @data.fetch("build", {}).fetch("state", "") == "passed"
   end

data/lib/lita/days_since_master_failure.rb

@@ -24,16 +24,15 @@ module Lita
       private
 
       def process_build_finished(event, &block)
-        repository = DaysSinceMasterFailureRepository.new(redis, event.pipeline)
-        repository.record_result(event.passed?) do |days_since_last_failure, prev_days_since_last_failure|
-          if days_since_last_failure < prev_days_since_last_failure
-            yield "Oh Oh, #{days_since_last_failure} day(s) since the last master failure on #{event.pipeline}"
-          elsif days_since_last_failure > prev_days_since_last_failure
-            yield "Congratulations! #{days_since_last_failure} day(s) since the last master failure on #{event.pipeline}"
-          end
+        repository(event).record_result(event) do |message|
+          yield message
         end
       end
 
+      def repository(event)
+        DaysSinceMasterFailureRepository.new(redis, event.pipeline)
+      end
+
       def target
         Source.new(room: Lita::Room.find_by_name(config.channel_name) || "general")
       end

data/lib/lita/days_since_master_failure_repository.rb

@@ -1,3 +1,5 @@
+require 'lita/build_status_report'
+
 # Provides all persistence logic for the DaysSinceMasterFailure handler, insulating
 # the handler from any knowledge of redis
 class DaysSinceMasterFailureRepository
@@ -5,18 +7,29 @@ class DaysSinceMasterFailureRepository
     @redis = redis
     @last_failure_key = "last-failure-at-#{pipeline_name}"
     @last_reported_days_key = "last-reported-days-#{pipeline_name}"
+    @most_successful_days_key = "most-successful-days-#{pipeline_name}"
 
     initialise_last_failure_at_if_not_set
+    initialise_most_successful_days_if_not_set
   end
 
-  def record_result(success, &block)
-    touch_last_failure_at if !success
-    yield days_since_last_failure, last_reported_days
+  def record_result(event, &block)
+    touch_last_failure_at if !event.passed?
+    touch_most_successful_days if !event.passed? && new_record?
+
+    BuildStatusReport.new(event, days_since_last_failure, last_reported_days, most_successful_days) do |message|
+      yield message
+    end
+
     touch_last_reported_days
   end
 
   private
 
+  def new_record?
+    last_reported_days > most_successful_days
+  end
+
   def seconds_to_days(secs)
     secs.to_i / 60 / 60 / 24
   end
@@ -33,6 +46,10 @@ class DaysSinceMasterFailureRepository
     set_last_reported_days(days_since_last_failure)
   end
 
+  def touch_most_successful_days
+    set_most_successful_days(last_reported_days)
+  end
+
   def fetch_last_failure_at
     @redis.get(@last_failure_key).to_i
   end
@@ -41,11 +58,23 @@ class DaysSinceMasterFailureRepository
     @redis.set(@last_reported_days_key, days.to_i)
   end
 
+  def set_most_successful_days(days)
+    @redis.set(@most_successful_days_key, days.to_i)
+  end
+
   def last_reported_days
     @redis.get(@last_reported_days_key).to_i
   end
 
+  def most_successful_days
+    @redis.get(@most_successful_days_key).to_i
+  end
+
   def initialise_last_failure_at_if_not_set
     @redis.setnx(@last_failure_key, ::Time.now.to_i)
   end
+
+  def initialise_most_successful_days_if_not_set
+    @redis.setnx(@most_successful_days_key, days_since_last_failure)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-buildkite
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - James Healy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-21 00:00:00.000000000 Z
+date: 2018-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -93,6 +93,7 @@ files:
 - MIT-LICENSE
 - README.md
 - lib/lita-buildkite.rb
+- lib/lita/build_status_report.rb
 - lib/lita/buildkite.rb
 - lib/lita/buildkite_build_finished_event.rb
 - lib/lita/buildkite_event.rb
@@ -121,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Lita handler for interacting with buildkite.com, a continuous integration