lita-ambush 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a39a401d61432161c983804ae906bf6bd68a72bd
-  data.tar.gz: aba8aee042fec23f6074b762f97923e2434f503c
+  metadata.gz: aae89189322cc97c87fa2264ae4be004da5c75c7
+  data.tar.gz: cfc777349ea31853e7ec3a417bf2698343c7a5a8
 SHA512:
-  metadata.gz: 4429a15dcfbd1ca8b7d72a1a626e21b62da3bea8ab7d1ccab6e71fa844e127ad009726e602e772af5e8eea01ae1d7bf1fcfa29a3399a15151e495f8c2f2b4935
-  data.tar.gz: e7ee310ae3171c394a3069bdab252a1314690e019abf650d8c1c5e5340783d21fb1edd9eb89dbfe1175b5fc46eb14618aa893b167a49fe15b737bdd61d8dbb0a
+  metadata.gz: be1cee30fbc133d4aab87ba74055068f5d971669b388efa090ef5c6bc5cca22d6d6642af398d80636a53b151fe14156ae4cc7efcad63fe13c059537aee9e3697
+  data.tar.gz: 72c53bfd7959f7c76e63b8cbc2d5c9b7450f7767571b349eaf026fa6d5b39993bc83bd2aa98a0722dcc8605ee9832761aadad1fb9c85ed12b66ec70fa93bc53b

data/README.md

@@ -1,9 +1,12 @@
 # lita-ambush
 
+[![Build Status](https://travis-ci.org/jjasghar/lita-ambush.svg?branch=master)](https://travis-ci.org/jjasghar/lita-ambush)[![Coverage Status](https://coveralls.io/repos/jjasghar/lita-ambush/badge.svg?branch=master)](https://coveralls.io/r/jjasghar/lita-ambush?branch=master)
 
 **lita-ambush** is a handler for [Lita](http://lita.io/) that stores messages for a user and displays
 them the next time they say something.
 
+We also recorded the three of us making this plugin. You can watch it [here](http://youtu.be/mQ6ULfjewE0).
+
 ## Installation
 
 Add lita-ambush to your Lita instance's Gemfile:
@@ -16,30 +19,40 @@ gem "lita-ambush"
 
 ### Optional attributes
 
-Still TODO
-* `preview_join_messages` (Symbol) - Post a message for the user when they
-just join the room. Options are `:on`, and `:off`. Default: `:off`.
-
-### Example
-
-Still TODO
-```
-Lita.configure do |config|
-  config.handlers.ambush.preview_join_messages = :off
-end
-```
+None
 
 ## Usage
 
 ```
 user1> lita ambush user2: Ohai! You forgot your card at lunch!
 Lita> Ambush Prepared
-User2 joined the channel
-Lita> User2 you have 1 message(s) waiting (Still TODO)
 user2> That was a great lunch!
 Lita> user2: while you were out, user1 said: Ohai! You forgot your card at lunch!
 ```
 
+## TODO
+
+- Have the plugin tell the time elapsed since the ambush was created, example:
+`user2: while you were out, user1 said: Ohai! You forgot your card at lunch! was sent 10 minutes ago`
+
+- Have the plugin report the number of waiting messages you have when a `JOIN` action happens, example:
+
+```
+User2 joined the channel
+Lita> User2 you have 1 message(s) waiting
+```
+
+Configuration can happen via:
+
+* `preview_join_messages` (Symbol) - Post a message for the user when they
+just join the room. Options are `:on`, and `:off`. Default: `:off`.
+
+```
+Lita.configure do |config|
+  config.handlers.ambush.preview_join_messages = :off
+end
+```
+
 ## License
 
 [MIT](http://opensource.org/licenses/MIT)

data/lib/lita/handlers/ambush.rb

@@ -4,7 +4,7 @@ module Lita
   module Handlers
     class Ambush < Handler
 
-      route(/^ambush:\s+(\S+):\s(.+)/, :ambush, command: true)
+      route(/^ambush\s+(\S+):\s(.+)/, :ambush, command: true, help: { "ambush USER: message" => "Ambushes the USER with the message you leave."} )
       route(/./, :response)
 
       def ambush(request)

data/lita-ambush.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-ambush"
-  spec.version       = "1.0.0"
+  spec.version       = "1.0.1"
   spec.authors       = ["JJ Asghar","Chris Baker","Greg Kitson"]
   spec.email         = ["jjasghar@gmail.com","dosman711@gmail.com","greg.kitson@gmail.com"]
   spec.description   = %q{Allow lita to ambush your users}

data/spec/lita/handlers/ambush_spec.rb

@@ -7,7 +7,7 @@ describe Lita::Handlers::Ambush, lita_handler: true do
 
   it "testing the storage into redis" do
     user1 = Lita::User.create(123, name: "user1")
-    send_command("ambush: user1: this is a taco!", as: user1)
+    send_command("ambush user1: this is a taco!", as: user1)
     expect(replies.last).to eq("#{user1.name} I've stored the ambush")
     redis_rpop=Lita.redis.rpop("handlers:ambush:#{user1.name}")
     outputted_yaml=YAML.load(redis_rpop)
@@ -17,8 +17,8 @@ describe Lita::Handlers::Ambush, lita_handler: true do
 
   it "should send store two messages" do
     user1 = Lita::User.create(123, name: "user1")
-    send_command("ambush: user1: this is a taco!", as: user1)
-    send_command("ambush: user1: this is a burruto!", as: user1)
+    send_command("ambush user1: this is a taco!", as: user1)
+    send_command("ambush user1: this is a burruto!", as: user1)
     expect(replies.last).to eq("#{user1.name} I've stored the ambush")
     expect(replies.last).to eq("#{user1.name} I've stored the ambush")
     redis_rpop=Lita.redis.rpop("handlers:ambush:#{user1.name}")
@@ -37,7 +37,7 @@ describe Lita::Handlers::Ambush, lita_handler: true do
   it "should respond with the message stored" do
     user1 = Lita::User.create(123, name: "user1")
     user2 = Lita::User.create(456, name: "user2")
-    send_command("ambush: #{user2.name}: this is a taco!", as: user1)
+    send_command("ambush #{user2.name}: this is a taco!", as: user1)
     send_message("I like to watch Sulvester Stalone!", as: user2)
     expect(replies.last).to eq("#{user2.name}: While you were out, #{user1.name} said: this is a taco!")
   end
@@ -52,8 +52,8 @@ describe Lita::Handlers::Ambush, lita_handler: true do
   it "should respond with the multiple messages stored" do
     user1 = Lita::User.create(123, name: "user1")
     user2 = Lita::User.create(456, name: "user2")
-    send_command("ambush: #{user2.name}: this is a taco!", as: user1)
-    send_command("ambush: #{user2.name}: this is a burrito!", as: user1)
+    send_command("ambush #{user2.name}: this is a taco!", as: user1)
+    send_command("ambush #{user2.name}: this is a burrito!", as: user1)
     send_message("I like to watch Sulvester Stalone!", as: user2)
     expect(replies[2]).to eq("#{user2.name}: While you were out, #{user1.name} said: this is a taco!")
     expect(replies[3]).to eq("#{user2.name}: While you were out, #{user1.name} said: this is a burrito!")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-ambush
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - JJ Asghar
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-28 00:00:00.000000000 Z
+date: 2015-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita