linzer 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94cad96e720cc1235948c2a2ef20b1056f444b4a456364c8551cfda414c539fb
-  data.tar.gz: fbd2f500e2c64e010fa380ac525e2afeef1a1fc7de055655263138a1a6afab27
+  metadata.gz: e05d05474d794c882d28a6fb83949147497218f141ae1e40e6c07e750407b421
+  data.tar.gz: 58b26e247acd0ca13e9029ace69ebb7459f1639b7908733e07ac88566ac255d1
 SHA512:
-  metadata.gz: f187e852f367e8d6428eb8cb61919693c67f0650a6b723e20211b1eabc47d0834c0b1facaaf89790e0d2e7335fe65752c09b0b136734e9d3214578b54fac794c
-  data.tar.gz: a5fa3a4eb24c9362918197d0828347095a354ed2151f3f08e6582d42854a0fd19460163b16523148823f82ada8a1aa95a4d467553490b909b39cba52a0ae9166
+  metadata.gz: 3af97f2888d5c4bd40900c490945590077604b93c954819c9308d2ab8fe767c491a08d2cbe5054aaced580a4da568a1d1cf11f82048048532feb5150dd59dfea
+  data.tar.gz: b4a47fd541623baef9582cc0b361975b504cc7824fd926f47f56f7f692f6a6d8dec0d8e4afdb5e64967d6e1d7a2107656165b95f383af5e902bddd26f0efe387

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [0.4.1] - 2024-03-25
+
+- Fix one-off error on ECDSA P-256 and P-384 curve signature generation.
+  In some cases, an invalid signature of 63 or 95 bytes could be generated.
+
 ## [0.4.0] - 2024-03-16
 
 - Add support for capitalized HTTP header names.

data/lib/linzer/ecdsa.rb

@@ -25,12 +25,12 @@ module Linzer
         case digest
         when "SHA256"
           raise Linzer::Error.new(msg) if sig.length != 64
-          r_bn = OpenSSL::BN.new(sig[0..31].unpack1("H*").to_i(16))
-          s_bn = OpenSSL::BN.new(sig[32..63].unpack1("H*").to_i(16))
+          r_bn = OpenSSL::BN.new(sig[0..31].unpack1("H64").to_i(16))
+          s_bn = OpenSSL::BN.new(sig[32..63].unpack1("H64").to_i(16))
         when "SHA384"
           raise Linzer::Error.new(msg) if sig.length != 96
-          r_bn = OpenSSL::BN.new(sig[0..47].unpack1("H*").to_i(16))
-          s_bn = OpenSSL::BN.new(sig[48..95].unpack1("H*").to_i(16))
+          r_bn = OpenSSL::BN.new(sig[0..47].unpack1("H96").to_i(16))
+          s_bn = OpenSSL::BN.new(sig[48..95].unpack1("H96").to_i(16))
         else
           msg = "Cannot verify signature, unsupported digest algorithm: '%s'" % digest
           raise Linzer::Error.new(msg)
@@ -44,13 +44,21 @@ module Linzer
       end
 
       def decode_der_signature(der_sig)
+        digest = @params[:digest]
+        msg = "Unsupported digest algorithm: '%s'" % digest
         OpenSSL::ASN1
           .decode(der_sig)
           .value
-          .map { |n| n.value.to_s(16) }
-          .map { |s| [s].pack("H*")   }
+          .map do |n|
+            case digest
+            when "SHA256" then "%.64x" % n.value
+            when "SHA384" then "%.96x" % n.value
+            else raise Linzer::Error.new(msg)
+            end
+          end
+          .map { |s| [s].pack("H#{s.length}") }
           .reduce(:<<)
-          .force_encoding(Encoding::ASCII_8BIT)
+          .encode(Encoding::ASCII_8BIT)
       end
     end
   end

data/lib/linzer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Linzer
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: linzer
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Miguel Landaeta
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-16 00:00:00.000000000 Z
+date: 2024-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ed25519