linterbot 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c2e9bd02e15964967d9c7006c8069ece73e5e67
-  data.tar.gz: 2034fbd20f8876edd421ecca00a001f96ba99a65
+  metadata.gz: abcda56ecd4fea3e725995d9de4133e317ed45c4
+  data.tar.gz: 1bf1db02125fb034dceffd0ef74f84dbaa5e438c
 SHA512:
-  metadata.gz: c776bac236b0e9954ae61411fb3fcff3682dcc208c350a69cf2ac9925efb6de0110136d527fbfe164a777ebb928b451d91be5c319cf136dd3f10f350299b8dd7
-  data.tar.gz: 502c31793d29772ede43f838cf0673f5059633aa56e9075469a6d25560726db5edcf8aa8b7d2d1fa79ebfecb9cb1296e98e286d419fcc1bd3c8c609e437d678b
+  metadata.gz: b2b799eec7600fac75d9a963c88542a156d7155308613d4de492cbca436e910fe89e730b6643463858d9e4ec5eed3ccd2a8d716a73c509fabd8b4776f02eff22
+  data.tar.gz: 8a82dd0167db2fba31b3d2affa9cac0546ccda44f0392cec028d0f8900c2c369e59fc16b08d3d52952c40d7d98ca91560b200f74f8a0c419671c8008c46aeff8

data/README.md

@@ -42,7 +42,7 @@ If you want to run it in TravisCI for every pull request triggered build you can
 if [ "$TRAVIS_PULL_REQUEST" != "false" ]
 then
   swiftlint --reporter json > switlint-report.json || false
-  linterbot $TRAVIS_REPO_SLUG $TRAVIS_PULL_REQUEST < swiftlint-report
+  linterbot $TRAVIS_REPO_SLUG $TRAVIS_PULL_REQUEST < swiftlint-report.json
 fi
 ```
 *`|| false` avoids a build fail if there are severe lint error*
@@ -75,7 +75,9 @@ linterbot help run
 
 ### GitHub access
 
-In order for linterbot to be able to comment on your pull request it needs write access to the specified repository. You can provided an access token by either using the environmental variable `GITHUB_ACCESS_TOKEN` or using the `.linterbot.yml` (which should not be committed to your git repository).
+In order for linterbot to be able to comment on your pull request it needs write access to the specified repository. Remember to add the `repo` scope when you create the GitHub access token. If you don't lintebot won't be able to run. For more information on how to create an access token check [this](https://help.github.com/articles/creating-an-access-token-for-command-line-use/) tutorial. If you want to know more about GitHub's OAuth scopes check [this](https://developer.github.com/v3/oauth/#scopes) section in their documentation.
+
+You can provided an access token by either using the environmental variable `GITHUB_ACCESS_TOKEN` or using the `.linterbot.yml` (which should not be committed to your git repository).
 
 ### Configuration file
 

data/exe/linterbot

@@ -46,7 +46,15 @@ command :run do |c|
       puts "Linterbot has successfully reviewed your PR ;-)"
     rescue Linterbot::RunnerConfiguration::MissingAttribute => exception
       STDERR.puts "Missing configuration attribute '#{exception.attribute_name}'"
-      STDERR.puts "#{exception.fix_description}"
+      STDERR.puts "#{exception.fix_description}\n"
+      exit 1
+    rescue Linterbot::RunnerConfiguration::InvalidGitHubCredentials => exception
+      STDERR.puts "Invalid GitHub credentials"
+      STDERR.puts "The given access token does not have the 'repo' scope"
+      STDERR.puts "\nFor more info on how to create an access token check:"
+      STDERR.puts "https://help.github.com/articles/creating-an-access-token-for-command-line-use/"
+      STDERR.puts "\nIf you want to know more about GitHub's OAuth scopes check:"
+      STDERR.puts "https://developer.github.com/v3/oauth/#scopes\n"
       exit 1
     end
   end

data/lib/linterbot/runner_configuration.rb

@@ -21,6 +21,9 @@ module Linterbot
 
     end
 
+    class InvalidGitHubCredentials < Exception
+    end
+
     DEFAULT_PROJECT_BASE_PATH = './'
     DEFAULT_CONFIG_FILE_PATH = './.linterbot.yml'
 
@@ -70,6 +73,7 @@ module Linterbot
         github_access_token = ENV["GITHUB_ACCESS_TOKEN"] || base_config[:github_access_token]
         raise missing_github_access_token unless github_access_token
         github_client = Octokit::Client.new(access_token: github_access_token)
+        validate_github_access!(github_client)
 
         configuration = new(github_client, base_config)
         configuration.project_base_path = options.project_base_path if options.project_base_path
@@ -83,6 +87,14 @@ module Linterbot
         configuration
       end
 
+      def validate_github_access!(github_client)
+        raise InvalidGitHubCredentials.new unless full_repo_access?(github_client)
+      end
+
+      def full_repo_access?(github_client)
+        github_client.scopes.include?("repo")
+      end
+
     end
 
     def initialize(github_client, options)

data/lib/linterbot/version.rb

@@ -1,3 +1,3 @@
 module Linterbot
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: linterbot
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Guido Marucci Blas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-07 00:00:00.000000000 Z
+date: 2016-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler