linked-list 0.0.12 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d11a48bdb387744768bf129513fce5e6f31001988e8cf45bf8b974009938e98
-  data.tar.gz: 9ba15ea4897065b9a111e6add68d6a60dac5ab61b9e3aba0ab83c7b42e91f8b5
+  metadata.gz: 11374e3455b233cc16781e3275650c2242fa34aa1631636ca7874eb6576d40af
+  data.tar.gz: 4d86d4d970ae13882d9599bd207abda51cc3472327346adf540e3ee5dc286003
 SHA512:
-  metadata.gz: 13f2b676935b4b18a9302e9a484f888c9c4730e81cab6fb6a891e4da5cc721fd0adf07d3f62b7a490fe985d32ed6143fdd9e01f586904214824c29c1cc8ed6f6
-  data.tar.gz: 5f844ebe95b710614b30ebc6a0a732c361987882ea661cc30e3773432f1702c347a2cf8979f63c6b50e6011cdd348adff1f458d0a81d22cab67aaf3b15528c36
+  metadata.gz: 148fb602013aaefce59532166566f1720988b1f419ad23106b990d9dc3efb4b25386947ba067dcab618ca5af41b959b230c6aa8e4a4be658ba07eebbc5dce95f
+  data.tar.gz: 66d06537f183dfc5174bed493862b906f83238a74ad1a57549fa8af813fd0076a964177dd290836167b68a5478d1ab101e43d9c64fe003aecdc1a23ecf0d69a6

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+# 0.0.13 / 2018-11-27
+
+## Fixed
+
+- Delete duplicate method definitions (nex3 in [#7](https://github.com/spectator/linked-list/pull/7))
+
+## Added
+
+- Allow `List#delete` to delete a `Node` in O(1) time (nex3 in [#6](https://github.com/spectator/linked-list/pull/6))
+
+[Compare v0.0.12...v0.0.13](https://github.com/spectator/linked-list/compare/v0.0.12...v0.0.13)
+
 # 0.0.12 / 2018-09-04
 
 ## Added

data/lib/linked-list/list.rb

@@ -130,10 +130,19 @@ module LinkedList
 
     # Removes first matched node.data from the the list by passed block or value.
     #
+    # If +val+ is a +Node+, removes that node from the list. Behavior is
+    # undefined if +val+ is a +Node+ that's not a member of this list.
+    #
     # == Returns:
-    # Deleted node
+    # Deleted node's data
     #
     def delete(val = nil, &block)
+      if val.respond_to?(:to_node)
+        node = val.to_node
+        __unlink_node(node)
+        return node.data
+      end
+
       each_node.find(&__to_matcher(val, &block)).tap do |node_to_delete|
         return unless node_to_delete
         __unlink_node(node_to_delete)
@@ -274,45 +283,6 @@ module LinkedList
       self
     end
 
-    # Inserts data after passed node.
-    #
-    # == Returns:
-    # Inserted node
-    #
-    def insert_after_node(data, node)
-      Node(data).tap do |new_node|
-        new_node.prev = node
-        new_node.next = node.next
-        if node.next
-          node.next.prev = new_node
-        else
-          @tail = new_node
-        end
-        node.next = new_node
-        @length += 1
-      end
-    end
-
-
-    # Inserts data before passed node.
-    #
-    # == Returns:
-    # Inserted node
-    #
-    def insert_before_node(data, node)
-      Node(data).tap do |new_node|
-        new_node.next = node
-        new_node.prev = node.prev
-        if node.prev
-          node.prev.next = new_node
-        else
-          @head = new_node
-        end
-        node.prev = new_node
-        @length += 1
-      end
-    end
-
     private
 
     def __unlink_node(node)

data/lib/linked-list/version.rb

@@ -2,6 +2,6 @@
 
 module Linked
   module List
-    VERSION = '0.0.12'
+    VERSION = '0.0.13'
   end
 end

data/test/list_test.rb

@@ -4,6 +4,7 @@ describe LinkedList::List do
   let(:list)   { create_list }
   let(:node_1) { create_node('foo') }
   let(:node_2) { create_node('bar') }
+  let(:node_3) { create_node('baz') }
 
   describe 'instantiation' do
     it 'assigns first to nil' do
@@ -476,6 +477,56 @@ describe LinkedList::List do
         end
       end
     end
+
+    describe 'by node' do
+      it 'deletes first node' do
+        list.push(node_1)
+        list.push(node_2)
+        list.push(node_3)
+        list.delete(node_1)
+        assert_equal ['bar', 'baz'], list.to_a
+      end
+
+      it 'returns deleted value' do
+        list.push(node_1)
+        list.delete(node_1)
+        assert_equal node_1.data, list.delete(node_1)
+      end
+
+      it 'decreases length of list' do
+        list.push('foo')
+        list.push('bar')
+        list.push('baz')
+        list.delete('foo')
+        assert_equal 2, list.length
+      end
+
+      describe 'position edge cases' do
+        before do
+          list.push(node_1)
+          list.push(node_2)
+          list.push(node_3)
+        end
+
+        it 'deletes value from head' do
+          list.delete(node_1)
+          assert_equal ['bar', 'baz'], list.to_a
+          assert_equal 'bar', list.first
+        end
+
+        it 'deletes value from middle' do
+          list.delete(node_2)
+          assert_equal ['foo', 'baz'], list.to_a
+        end
+
+
+        it 'deletes value from tail' do
+          list.delete(node_3)
+          assert_equal ['foo', 'bar'], list.to_a
+          assert_equal 'bar', list.last
+        end
+      end
+    end
   end
 
   describe '#delete_all' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: linked-list
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - Yury Velikanau
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-05 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler