link_thumbnailer 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd2de89ee93a079ce228bbf77fd1362e359f5ce8
-  data.tar.gz: db435fc9864ba56d81d16425802f625e2faeeaf7
+  metadata.gz: 42c12677181ae4f47f9809a31f3b857e90b6de3f
+  data.tar.gz: d6e394503da26997c9c5cf67c58f0d9c2bea62ea
 SHA512:
-  metadata.gz: 32bf121c87417dfb69a716a3ebb912367b1eb107794d268f342b8eb9bda090b986faea21ff2d2e9db2a4546cca0d39e9d833ec75d719c08b89776ca98fbbfa05
-  data.tar.gz: 5ece7aa51e0a7211e0ac92e15c364591497f622dbfdd09d1525bb5aeca1cd4f14f65d1e67d2c89c86ca5eb9ee737b4f878ccac59be95548ff0170191616b4018
+  metadata.gz: 6d29145f60542d6a5b7b8a8ba1fddc76587823348e78bf38830b3b6d75772c53e37bda89281a0586f2a56b1a0869df9ea964cc0f58d925e8d8ef2a3a067207d5
+  data.tar.gz: 1980e7240d0c7fbe42a652ac7c1e29feceb90579dd3a6e46526cfb12d381c67e4ef55bcfd13a6d55a37a00f20cc8b37647fef6595e1bd18ca26f10e2ea56d52b

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 3.0.3
+
+- Fix an issue when dealing with absolute urls. https://github.com/gottfrois/link_thumbnailer/issues/68
+- Fix an issue with http redirection and location header not beeing present. https://github.com/gottfrois/link_thumbnailer/issues/70
+- Rescue and raise custom LinkThumbnailer exceptions. https://github.com/gottfrois/link_thumbnailer/issues/71
+
 # 3.0.2
 
 - Replace FastImage gem dependency by [ImageInfo](https://github.com/gottfrois/image_info) to improve performances when

data/lib/link_thumbnailer/exceptions.rb

@@ -1,7 +1,9 @@
 module LinkThumbnailer
-  class Exceptions      < StandardError; end
-  class RedirectLimit   < Exceptions; end
-  class BadUriFormat    < Exceptions; end
-  class FormatNotSupported < Exceptions; end
-  class ScraperInvalid  < Exceptions; end
+  Exceptions         = Class.new(StandardError)
+  RedirectLimit      = Class.new(Exceptions)
+  BadUriFormat       = Class.new(Exceptions)
+  FormatNotSupported = Class.new(Exceptions)
+  ScraperInvalid     = Class.new(Exceptions)
+  HTTPError          = Class.new(Exceptions)
+  SyntaxError        = Class.new(Exceptions)
 end

data/lib/link_thumbnailer/parser.rb

@@ -3,10 +3,10 @@ require 'nokogiri'
 module LinkThumbnailer
   class Parser
 
-    attr_reader :document
-
     def call(source)
-      @document ||= ::Nokogiri::HTML(source)
+      ::Nokogiri::HTML(source)
+    rescue ::Nokogiri::XML::SyntaxError => e
+      raise ::LinkThumbnailer::SyntaxError.new(e.message)
     end
 
   end

data/lib/link_thumbnailer/processor.rb

@@ -26,6 +26,8 @@ module LinkThumbnailer
         set_http_options
         perform_request
       end
+    rescue ::Net::HTTPExceptions, ::SocketError, ::Timeout::Error => e
+      raise ::LinkThumbnailer::HTTPError.new(e.message)
     end
 
     private
@@ -60,7 +62,7 @@ module LinkThumbnailer
         response.body
       when ::Net::HTTPRedirection
         call(
-          resolve_relative_url(response['location']),
+          resolve_relative_url(response['location'].to_s),
           redirect_count + 1,
           headers
         )

data/lib/link_thumbnailer/scrapers/default/images.rb

@@ -44,7 +44,7 @@ module LinkThumbnailer
         end
 
         def needs_prefix?(uri)
-          !uri.is_a?(::URI::HTTP)
+          !uri.host
         end
 
         def prefix_uri(uri)

data/lib/link_thumbnailer/version.rb

@@ -1,3 +1,3 @@
 module LinkThumbnailer
-  VERSION = '3.0.2'
+  VERSION = '3.0.3'
 end

data/spec/processor_spec.rb

@@ -38,7 +38,7 @@ describe LinkThumbnailer::Processor do
         stub_request(:get, url).to_return(status: 500, body: '', headers: {})
       end
 
-      it { expect { action }.to raise_error(Net::HTTPFatalError) }
+      it { expect { action }.to raise_error(LinkThumbnailer::HTTPError) }
 
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Pierre-Louis Gottfrois
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-10 00:00:00.000000000 Z
+date: 2015-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport