link_thumbnailer 2.2.0 → 2.2.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmMxNTZhYWFkN2E4N2JjN2NkNjRlMmFlMjU3YWYxMDJlOWVmNzBhMw==
+    NTMzZGRhYzQxZTMxNTI4YzI3NDExMWY3NmVkZDBjZmU2Yzg3YWYyYw==
   data.tar.gz: !binary |-
-    MDMwOWQ2NWYyYmUxMGExOWI0MzM5YjA2ZTkwZTNlY2ViZmVlOGFhYQ==
+    Y2RmZDhmMDllZDBmNmEwNWFjZjQ3NDA0ZjBkYzZmNmU5YzQ1NzcxNg==
 SHA512:
   metadata.gz: !binary |-
-    YmM4MDg1ZTFlZTJlZGJiZTYxMzc2MWI5N2FkYjkxMDc4NmEzNjdmYjVjMDJj
-    ZDQxMTc5YTY3ZjY3MzY5MWRjNjk4ODFmYWJjNTE4ZmQwMGI2YTI2ZjhiMjU3
-    ZGFhMzNlNzcwNjIzZWFhYTNkYWQ3NWY5OTU1M2Q0NDM0ZjQxYzU=
+    NWIxNDBkMzE4YmQ3NzZmYzQ3YzZhZDVkNjQ3NWMxOGI2YjQwNDFkMTQ0OTZj
+    YzYxM2MzYzcwOWE3YTY0NzJkZTc0NzA5M2FhNzY0NmY2MDc1ZjY4YmE0MzIz
+    MDM4YWY5OTMzY2I5Zjk0ZDBkNWJjNjEyNTZlZDEyN2M3NGUzZDA=
   data.tar.gz: !binary |-
-    MDRlNWY3MGQ1ZWI4MTYyNzY0ZmY0MGIxY2U2NDA5NTg4Zjc2MGI5NDgxNzBl
-    MzRiOTUwNmVlMTdjZmFiMGFkZThmODFkYjllN2QxMWZlOTI5NWM1MzNmMDA1
-    MmU5YjcxYWY3Y2RjZGE5ZjJmNDU5NjBkMzc1MjNiODA5YjIxMGI=
+    NjEzM2M4NDhjZmVmMGViMjRmY2VjZjc1ZmRlM2UxZTM5ZWI1NjU5OTIyYjhj
+    YjMzMThlNDJiMDY1OTE2MWExMTBkMzU2OTA3NWFjMmI0N2UwNGIxYTk3ODRj
+    NjgwNzZkMmZlN2RmMjZmZDc5Nzg2ZmY0NjA3OTQ0ZjQ5M2VhYzI=

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.2.1
+
+- Fix issue when computing link density ratio
+
 # 2.2.0
 
 - Add support for `og:video`

data/lib/link_thumbnailer/graders/base.rb

@@ -14,7 +14,7 @@ module LinkThumbnailer
       end
 
       def call(current_score)
-        raise 'must implement'
+        fail NotImplementedError
       end
 
       private

data/lib/link_thumbnailer/graders/link_density.rb

@@ -3,7 +3,8 @@ module LinkThumbnailer
     class LinkDensity < ::LinkThumbnailer::Graders::Base
 
       def call(current_score)
-        current_score *= (1 - density)
+        return 0 if density_ratio == 0
+        current_score *= density_ratio
       end
 
       private
@@ -13,6 +14,10 @@ module LinkThumbnailer
         links.length / text.length.to_f
       end
 
+      def density_ratio
+        1 - density
+      end
+
       def links
         node.css('a').map(&:text)
       end

data/lib/link_thumbnailer/image_comparators/base.rb

@@ -9,7 +9,7 @@ module LinkThumbnailer
       end
 
       def call
-        raise 'you must implement this method'
+        fail NotImplementedError
       end
 
     end

data/lib/link_thumbnailer/railtie.rb

@@ -1,9 +1,4 @@
 module LinkThumbnailer
   class Railtie < ::Rails::Railtie
-
-    initializer 'link_thumbnailer.routes' do
-      LinkThumbnailer::Rails::Routes.install!
-    end
-
   end
 end

data/lib/link_thumbnailer/version.rb

@@ -1,3 +1,3 @@
 module LinkThumbnailer
-  VERSION = '2.2.0'
+  VERSION = '2.2.1'
 end

data/spec/graders/link_density_spec.rb

@@ -8,14 +8,27 @@ describe LinkThumbnailer::Graders::LinkDensity do
   describe '#call' do
 
     let(:previous_score)  { 1 }
-    let(:density)         { 10 }
     let(:action)          { instance.call(previous_score) }
 
-    before do
-      instance.stub(:density).and_return(density)
+    context 'when density_ratio is 0' do
+
+      before do
+        instance.stub(:density_ratio).and_return(0)
+      end
+
+      it { expect(action).to eq(0) }
+
     end
 
-    it { expect(action).to eq(-9) }
+    context 'when density is not 0' do
+
+      before do
+        instance.stub(:density_ratio).and_return(10)
+      end
+
+      it { expect(action).to eq(10) }
+
+    end
 
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Pierre-Louis Gottfrois
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-17 00:00:00.000000000 Z
+date: 2014-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport