link_thumbnailer 0.0.5 → 0.0.6

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 0.0.6
+
+- Update readme
+- Add `to_a` to WebImage class
+- Refactor `to_json` for WebImage class
+- Add specs corresponding
+
 # 0.0.5
 
 - Bug fix

data/README.md

@@ -64,6 +64,15 @@ Now with a regular website with no particular protocol:
 	object.images.first.source_url
 	 => #<URI::HTTP:0x007ff7a923ef58 URL:http://foo.com/media/BAhbB1sHOgZmSSItMjAxMi8wNC8yNi8yMC8xMS80OS80MjYvY29yZG92YWJlYWNoLmpwZwY6BkVUWwg6BnA6CnRodW1iSSINNzUweDIwMCMGOwZU/cordovabeach.jpg>
 
+	object.images.first.to_json
+	 => "{\"source_url\":\"http://foo.com/media/BAhbB1sHOgZmSSItMjAxMi8wNC8yNi8yMC8xMS80OS80MjYvY29yZG92YWJlYWNoLmpwZwY6BkVUWwg6BnA6CnRodW1iSSINNzUweDIwMCMGOwZU/cordovabeach.jpg\",\"mime_type\":\"image/jpeg\",\"density\":\"72x72\",\"rows\":200,\"filesize\":46501,\"number_colors\":9490}"
+
+	object.images.first.to_a
+	 => {:source_url=>#<URI::HTTP:0x007f8a4a2561c0 URL:http://foo.com/media/BAhbB1sHOgZmSSItMjAxMi8wNC8yNi8yMC8xMS80OS80MjYvY29yZG92YWJlYWNoLmpwZwY6BkVUWwg6BnA6CnRodW1iSSINNzUweDIwMCMGOwZU/cordovabeach.jpg>, :mime_type=>"image/jpeg", :density=>"72x72", :rows=>200, :filesize=>46501, :number_colors=>9490}
+
+	object.images.map(&:to_a)
+	 => [{:source_url=>#<URI::HTTP:0x007f8a4a2561c0 URL:http://foo.com/media/BAhbB1sHOgZmSSItMjAxMi8wNC8yNi8yMC8xMS80OS80MjYvY29yZG92YWJlYWNoLmpwZwY6BkVUWwg6BnA6CnRodW1iSSINNzUweDIwMCMGOwZU/cordovabeach.jpg>, :mime_type=>"image/jpeg", :density=>"72x72", :rows=>200, :filesize=>46501, :number_colors=>9490}]
+
 You can check whether this object is valid or not (set mandatory attributes in the initializer, defaults are `[url, title, images]`)
 
 	object.valid?

data/lib/link_thumbnailer/version.rb

@@ -1,3 +1,3 @@
 module LinkThumbnailer
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/link_thumbnailer/web_image.rb

@@ -3,16 +3,19 @@ require 'json'
 module LinkThumbnailer
   module WebImage
 
-    attr_accessor :source_url
-    attr_accessor :doc
+    attr_accessor :source_url, :doc
 
-    def to_json
-      result = []
+    def to_a
+      result = {}
       %w(source_url mime_type density colums rows filesize number_colors).each {|m|
-        result << { m.to_sym => self.send(m) } if self.respond_to?(m)
+        result[m.to_sym] = self.send(m) if self.respond_to?(m)
       }
 
-      JSON(result)
+      result
+    end
+
+    def to_json
+      JSON(self.to_a)
     end
 
   end

data/spec/web_image_spec.rb

@@ -13,34 +13,72 @@ describe LinkThumbnailer::WebImage do
 
   subject { foo }
 
+  it { should respond_to :to_a }
   it { should respond_to :to_json }
   it { should respond_to :source_url }
   it { should respond_to :doc }
 
+  describe ".to_a" do
+
+    context "with default attributes" do
+
+      let(:attributes) { [:source_url] }
+
+      subject { foo.to_a }
+
+      it { subject.keys.should eq(attributes) }
+
+    end
+
+    context "with all attributes" do
+
+      let(:attributes) { [:source_url, :mime_type, :density, :colums, :rows, :filesize, :number_colors] }
+
+      before do
+        attributes.each {|a| foo.class.send(:define_method, a.to_sym) { 'foo' } }
+      end
+
+      after do
+        attributes.each {|a| foo.class.send(:undef_method, a.to_sym) }
+      end
+
+      subject { foo.to_a }
+
+      it { subject.keys.should eq(attributes) }
+      it { subject.values.should include('foo') }
+
+    end
+
+  end
+
   describe ".to_json" do
 
     context "with default attributes" do
 
-      let(:attributes) { %w(source_url) }
+      let(:attributes) { [:source_url] }
 
       subject { foo.to_json }
 
-      it { JSON.parse(subject).first.keys.should eq(attributes) }
+      it { JSON.parse(subject).keys.map(&:to_sym).should eq(attributes) }
 
     end
 
     context "with all attributes" do
 
-      let(:attributes) { %w(source_url mime_type density colums rows filesize number_colors) }
+      let(:attributes) { [:source_url, :mime_type, :density, :colums, :rows, :filesize, :number_colors] }
 
       before do
         attributes.each {|a| foo.class.send(:define_method, a.to_sym) { 'foo' } }
       end
 
+      after do
+        attributes.each {|a| foo.class.send(:undef_method, a.to_sym) }
+      end
+
       subject { foo.to_json }
 
-      it { puts JSON.parse(subject).map {|e| e.keys.first }.should eq(attributes) }
-      it { puts JSON.parse(subject).map {|e| e.values.first }.should include('foo') }
+      it { JSON.parse(subject).keys.map(&:to_sym).should eq(attributes) }
+      it { JSON.parse(subject).values.should include('foo') }
 
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_thumbnailer
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors: