link_oracle 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: be327867cb2f7bb24b4f06cfd40d609fac3171c9
-  data.tar.gz: aeaea157fe4058f168e2130b50f286453afa97eb
+  metadata.gz: 22de0311b5c6ff2460a3b3af8334693daebcaba3
+  data.tar.gz: 5c4e063fcb0e5723afc2ae015d956753684629e1
 SHA512:
-  metadata.gz: 37b17d27fc7f6ec1988cc75f1e0baebe92ec98775039740b7bddbbadabd3009a4fcc0db2b35abb8930645c91382c4f3cbdbd9af0495426bbab29f4717f375735
-  data.tar.gz: bc5f0db1a7cdfdc8abd5e0ba3e51dc62058239298441c62eaf3a49eeb96c889e468b0b62e79ed1da74fd4cfcdf9a52e48d4014d83ed4acf03ca9d8c3b9af3798
+  metadata.gz: d142a141bfb054ba44fafc6570d356b1697e740863474c8d9e46540c4daeebb28f483524aff3bdeb3dd536e882387178de9caed11cbca591e508a30389d8c64a
+  data.tar.gz: 52dcbb19795887a351118f17d552ac9f34b206ef7562f1584eaac1ba07e372cf894d97bb98090d946e195363641353bf69221ae04fd0aafda9944f111785bb80

data/lib/link_oracle/request.rb

@@ -52,6 +52,8 @@ class LinkOracle
       c
     rescue Curl::Err::HostResolutionError
       raise ServerNotFound
+    rescue Curl::Err::SSLCACertificateError
+      raise BadSslCertificate
     end
 
     def error_class
@@ -75,4 +77,5 @@ class LinkOracle
   class BadThingsHappened < StandardError; end
   class InvalidUrl < StandardError; end
   class ParsingError < StandardError; end
+  class BadSslCertificate < StandardError ; end
 end

data/lib/link_oracle/version.rb

@@ -1,3 +1,3 @@
 class LinkOracle
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

data/spec/link_oracle/request_spec.rb

@@ -29,62 +29,66 @@ describe LinkOracle::Request do
   describe '#parsed_url' do
     context 'request failures' do
       before do
-        stub_request(:any, url).to_return(response_hash)
+        stub_request(:get, url).to_return(response_hash)
       end
 
-      context 'page not found' do
-        context 'response code is 404' do
-          let(:code) { 404 }
+      context 'response code is 404' do
+        let(:code) { 404 }
 
-          it 'should raise PageNotFound' do
-            expect {
-              requester.parsed_url
-            }.to raise_error(LinkOracle::PageNotFound)
-          end
+        it 'should raise PageNotFound' do
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::PageNotFound)
         end
+      end
 
-        context 'nonexistant url' do
-          it 'should raise ServerNotFound' do
-            curl = double('curl', "follow_location=" => true, "max_redirects=" => true)
-            allow(curl).to receive(:perform).and_raise(Curl::Err::HostResolutionError)
-            allow(Curl::Easy).to receive(:new).and_return(curl)
-
-            expect {
-              requester.parsed_url
-            }.to raise_error(LinkOracle::ServerNotFound)
-          end
+      context 'nonexistant url' do
+        it 'should raise ServerNotFound' do
+          stub_request(:get, url).to_raise(Curl::Err::HostResolutionError)
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::ServerNotFound)
         end
+      end
 
-        context 'response code is 403' do
-          let(:code) { 403 }
+      context 'response code is 403' do
+        let(:code) { 403 }
 
-          it 'should raise PermissionDenied' do
-            expect {
-              requester.parsed_url
-            }.to raise_error(LinkOracle::PermissionDenied)
-          end
+        it 'should raise PermissionDenied' do
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::PermissionDenied)
         end
+      end
 
-        context 'response code is weird' do
-          let(:code) { 42 }
+      context 'response code is weird' do
+        let(:code) { 42 }
 
-          it 'should raise BadThingsHappened' do
-            expect {
-              requester.parsed_url
-            }.to raise_error(LinkOracle::BadThingsHappened)
-          end
+        it 'should raise BadThingsHappened' do
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::BadThingsHappened)
+        end
+      end
+
+      context "when the server's SSL certificate is untrusted" do
+        it "raises BadSslCertificate" do
+          stub_request(:get, url).to_raise(Curl::Err::SSLCACertificateError)
+          expect do
+            requester.parsed_url
+           end.to raise_error(LinkOracle::BadSslCertificate)
         end
+      end
 
-        context 'parsing goes awry' do
-          before do
-            ::Nokogiri::HTML.should_receive(:parse).and_raise(ArgumentError)
-          end
+      context 'parsing goes awry' do
+        before do
+          ::Nokogiri::HTML.should_receive(:parse).and_raise(ArgumentError)
+        end
 
-          it 'should raise ParsingError' do
-            expect {
-              requester.parsed_url
-            }.to raise_error(LinkOracle::ParsingError)
-          end
+        it 'should raise ParsingError' do
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::ParsingError)
         end
       end
     end
@@ -112,7 +116,7 @@ describe LinkOracle::Request do
 
       context "the url has weird characters in it" do
         before do
-          stub_request(:any, url).to_return(response_hash)
+          stub_request(:get, url).to_return(response_hash)
         end
 
         let(:url) { 'http://www.autoblog.com/2014/09/26/porsche-911-nissan-gtr-world-greatest-drag-race-video/?icid=autos|latest-auto-news|content' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Ian Cooper
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-13 00:00:00.000000000 Z
+date: 2014-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri