link_oracle 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d19780fb7f9cd2688937b8cc94e32f3c82b514ac
-  data.tar.gz: d4ebf911932fc368456526e26c19544b8e843762
+  metadata.gz: be327867cb2f7bb24b4f06cfd40d609fac3171c9
+  data.tar.gz: aeaea157fe4058f168e2130b50f286453afa97eb
 SHA512:
-  metadata.gz: 36a66ac4d7f24a076fff08a21e892f365d8749da383cf3e006340c73fda2fb8f3ee4a0a626720561001850523c4e1dd3d176197656a5b0a9511279329ddb7d7c
-  data.tar.gz: d30bbc6cbbd2abf2f2eb397b0648f6ee1921793d55e715ceb51cbeab4e751e413a7ec446c25b9a6e4e3426a8b6f86710b24f4f8e28d4fb7de0dcea54ac0c1f4e
+  metadata.gz: 37b17d27fc7f6ec1988cc75f1e0baebe92ec98775039740b7bddbbadabd3009a4fcc0db2b35abb8930645c91382c4f3cbdbd9af0495426bbab29f4717f375735
+  data.tar.gz: bc5f0db1a7cdfdc8abd5e0ba3e51dc62058239298441c62eaf3a49eeb96c889e468b0b62e79ed1da74fd4cfcdf9a52e48d4014d83ed4acf03ca9d8c3b9af3798

data/lib/link_oracle/extractor/body.rb

@@ -20,7 +20,7 @@ class LinkOracle
       end
 
       def images
-        @images ||= valid_size_images
+        @images ||= first_valid_size_image ? [first_valid_size_image] : []
       end
 
       def parsed_images
@@ -30,11 +30,11 @@ class LinkOracle
       end
 
       def formatted_images
-        parsed_images.map { |image_url| ::Utils::ImageUrlFormatter.new(url, image_url).perform }
+        @formatted_images ||= parsed_images.map { |image_url| ::Utils::ImageUrlFormatter.new(url, image_url).perform }
       end
 
-      def valid_size_images
-        formatted_images.select do |image|
+      def first_valid_size_image
+        @first_valid_size_image ||= formatted_images.find do |image|
           size = image_size(image)
           size[0] >= 100 && size[1] >= 100 if size
         end

data/lib/link_oracle/version.rb

@@ -1,3 +1,3 @@
 class LinkOracle
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

data/spec/link_oracle/extractor/body_spec.rb

@@ -75,12 +75,9 @@ describe LinkOracle::Extractor::Body do
           FastImage.stub(:size).and_return([100, 121])
         end
 
-        it 'should populate link_data image_urls' do
+        it 'should populate link_data image_urls with the first image of the right size' do
           expect(link_data.image_urls).to match_array([
-            "http://berkin.com",
-            "http://cherbin.com",
-            "http://flerbin.com",
-            "http://berkin.com/berkin/cherbin.jpg"
+            "http://berkin.com"
           ])
         end
       end
@@ -92,14 +89,13 @@ describe LinkOracle::Extractor::Body do
       end
 
       context 'some images are correct size and some are not' do
-        it 'should populate link_data image_urls only with the correctly sized images' do
+        it 'should populate link_data image_urls only with the first correctly sized images' do
           FastImage.should_receive(:size).with("http://berkin.com").and_return([50, 60])
-          FastImage.should_receive(:size).with("http://flerbin.com").and_return([60, 55])
-          FastImage.should_receive(:size).with("http://cherbin.com").and_return([160, 155])
           FastImage.should_receive(:size).with("http://berkin.com/berkin/cherbin.jpg").and_return([160, 155])
+          FastImage.should_not_receive(:size).with("http://cherbin.com")
+          FastImage.should_not_receive(:size).with("http://flerbin.com")
 
           expect(link_data.image_urls).to match_array([
-            "http://cherbin.com",
             "http://berkin.com/berkin/cherbin.jpg"
           ])
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Ian Cooper
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-11 00:00:00.000000000 Z
+date: 2014-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri