link_oracle 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5037a462b2f18aa3bf1f4ea925c3cefb1697e46a
-  data.tar.gz: 824da5dd8ae7e12a8e5c412151c145866641f961
+  metadata.gz: d19780fb7f9cd2688937b8cc94e32f3c82b514ac
+  data.tar.gz: d4ebf911932fc368456526e26c19544b8e843762
 SHA512:
-  metadata.gz: 17b1f57667b2b5b5470408b6edb9ef46196da92a6a96ba67f98c1e1c70d6d4e51f062890c15e353c4636dadc504b70c50509a83d910b17c188ac87e921547c39
-  data.tar.gz: 675f26ded878ecce2d5d179f12c7f81a2f10e251001d8b693fb37945ce2c8b8a0b2f8aca145dbff49139b81dfdd8e5765ffadb77ab96dfc2a6ffc9a472a7b92c
+  metadata.gz: 36a66ac4d7f24a076fff08a21e892f365d8749da383cf3e006340c73fda2fb8f3ee4a0a626720561001850523c4e1dd3d176197656a5b0a9511279329ddb7d7c
+  data.tar.gz: d30bbc6cbbd2abf2f2eb397b0648f6ee1921793d55e715ceb51cbeab4e751e413a7ec446c25b9a6e4e3426a8b6f86710b24f4f8e28d4fb7de0dcea54ac0c1f4e

data/lib/link_oracle/request.rb

@@ -50,6 +50,8 @@ class LinkOracle
         c.perform
       end
       c
+    rescue Curl::Err::HostResolutionError
+      raise ServerNotFound
     end
 
     def error_class
@@ -68,6 +70,7 @@ class LinkOracle
   end
 
   class PageNotFound < StandardError; end
+  class ServerNotFound < StandardError; end
   class PermissionDenied < StandardError; end
   class BadThingsHappened < StandardError; end
   class InvalidUrl < StandardError; end

data/lib/link_oracle/version.rb

@@ -1,3 +1,3 @@
 class LinkOracle
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

data/spec/link_oracle/request_spec.rb

@@ -26,14 +26,13 @@ describe LinkOracle::Request do
     </html>"
   }
 
-
-  describe 'perform' do
+  describe '#parsed_url' do
     context 'request failures' do
       before do
         stub_request(:any, url).to_return(response_hash)
       end
 
-      context 'invalid url' do
+      context 'page not found' do
         context 'response code is 404' do
           let(:code) { 404 }
 
@@ -44,6 +43,18 @@ describe LinkOracle::Request do
           end
         end
 
+        context 'nonexistant url' do
+          it 'should raise ServerNotFound' do
+            curl = double('curl', "follow_location=" => true, "max_redirects=" => true)
+            allow(curl).to receive(:perform).and_raise(Curl::Err::HostResolutionError)
+            allow(Curl::Easy).to receive(:new).and_return(curl)
+
+            expect {
+              requester.parsed_url
+            }.to raise_error(LinkOracle::ServerNotFound)
+          end
+        end
+
         context 'response code is 403' do
           let(:code) { 403 }
 
@@ -100,12 +111,16 @@ describe LinkOracle::Request do
       end
 
       context "the url has weird characters in it" do
+        before do
+          stub_request(:any, url).to_return(response_hash)
+        end
+
         let(:url) { 'http://www.autoblog.com/2014/09/26/porsche-911-nissan-gtr-world-greatest-drag-race-video/?icid=autos|latest-auto-news|content' }
 
         it "should encode and not raise an error" do
           expect {
             requester.parsed_url
-          }.to_not raise_error(LinkOracle::InvalidUrl)
+          }.to_not raise_error
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Ian Cooper
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2014-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri