link_oracle 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 384b604e728c753c47f036b2c714b10cf26a8549
-  data.tar.gz: 0d8c11d04441682e63c0b5a2c644143008fe7530
+  metadata.gz: 5037a462b2f18aa3bf1f4ea925c3cefb1697e46a
+  data.tar.gz: 824da5dd8ae7e12a8e5c412151c145866641f961
 SHA512:
-  metadata.gz: a99406314c99255ec4be08fd66bf60b93491332c5b28a947c1d569e64c90d7d95d60869f01620ccac6231ec9bc22ecd8fa29c9d81a0e702034b09b597ef6730c
-  data.tar.gz: e3a4a293759f35aa51d9e2ab6b47ec3f60c18f62d32c8967df9435050caf12db5dc0a47db5464035120d933ee8af3b659021e06724861087e2d715e960056c65
+  metadata.gz: 17b1f57667b2b5b5470408b6edb9ef46196da92a6a96ba67f98c1e1c70d6d4e51f062890c15e353c4636dadc504b70c50509a83d910b17c188ac87e921547c39
+  data.tar.gz: 675f26ded878ecce2d5d179f12c7f81a2f10e251001d8b693fb37945ce2c8b8a0b2f8aca145dbff49139b81dfdd8e5765ffadb77ab96dfc2a6ffc9a472a7b92c

data/lib/link_oracle/request.rb

@@ -24,11 +24,17 @@ class LinkOracle
     end
 
     def validate_url
-      !!URI.parse(url)
+      encoded_url = encode_url(url)
+      !!URI.parse(encoded_url)
     rescue URI::InvalidURIError
       raise InvalidUrl, url
     end
 
+    def encode_url(url)
+      return if url.nil? || url.empty?
+      URI.encode(url)
+    end
+
     def response
       @response ||= request
     end

data/lib/link_oracle/version.rb

@@ -1,3 +1,3 @@
 class LinkOracle
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/link_oracle/request_spec.rb

@@ -88,6 +88,26 @@ describe LinkOracle::Request do
           }.to raise_error(LinkOracle::InvalidUrl)
         end
       end
+
+      context 'url is blank' do
+        let(:url) { '' }
+
+        it 'should raise InvalidUrl' do
+          expect {
+            requester.parsed_url
+          }.to raise_error(LinkOracle::InvalidUrl)
+        end
+      end
+
+      context "the url has weird characters in it" do
+        let(:url) { 'http://www.autoblog.com/2014/09/26/porsche-911-nissan-gtr-world-greatest-drag-race-video/?icid=autos|latest-auto-news|content' }
+
+        it "should encode and not raise an error" do
+          expect {
+            requester.parsed_url
+          }.to_not raise_error(LinkOracle::InvalidUrl)
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: link_oracle
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Ian Cooper
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-02 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri