line_up 0.0.3 → 0.1.0

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/bukowskis/line_up.png)](https://travis-ci.org/bukowskis/line_up)
+
 # LineUp
 
 With LineUp you can enqueue Resque jobs in arbitrary Redis namespaces.

data/lib/line_up/version.rb

@@ -1,8 +1,8 @@
 module LineUp
   module VERSION #:nodoc:
     MAJOR = 0
-    MINOR = 0
-    TINY  = 3
+    MINOR = 1
+    TINY  = 0
 
     STRING = [MAJOR, MINOR, TINY].compact.join('.')
   end

data/lib/line_up.rb

@@ -19,6 +19,22 @@ module LineUp
     false
   end
 
+  def self.ensure(application, jobclass, *args)
+    if queue_length(application, jobclass) == 0
+      push(application, jobclass, *args)
+    end
+  end
+
+  def self.queue_length(application, jobclass)
+    redis_for application do |r|
+      job = Job.new jobclass
+      return r.llen "queue:#{job.queue_name}"
+    end
+  rescue Exception => e
+    Trouble.notify e, caller: caller[1], message: "LineUp could not get the queue length", code: :getting_queue_length_failed, redis: config.redis.inspect, application: application.inspect, job: jobclass.inspect
+    false
+  end
+
   private
 
   def self.redis_for(application, &block)

data/spec/lib/line_up/configuration_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe LineUp do
+
+  let(:logger)      { mock(:logger) }
+
+  let(:lineup) { LineUp }
+
+  describe '.config' do
+    before do
+      LineUp.reset!
+    end
+
+    it 'is an STDOUT logger' do
+      Logger.should_receive(:new).with(STDOUT).and_return logger
+      lineup.config.logger.should be logger
+    end
+
+    context 'with Rails' do
+      before do
+        ensure_module :Rails
+        Rails.stub!(:logger).and_return(logger)
+      end
+
+      after do
+        Object.send(:remove_const, :Rails)
+      end
+
+      it 'is the Rails logger' do
+        lineup.config.logger.should be Rails.logger
+      end
+    end
+  end
+end

data/spec/lib/line_up_spec.rb

@@ -81,26 +81,47 @@ describe LineUp do
     end
   end
 
-  describe '.config' do
-    before do
-      LineUp.reset!
-    end
+  describe ".queue_length" do
 
-    it 'is an STDOUT logger' do
-      Logger.should_receive(:new).with(STDOUT).and_return logger
-      lineup.config.logger.should be logger
+    it "returns the length of the given queue in the given application" do
+      lineup.push(application, job, 1)
+      lineup.push(application, job, 2)
+      lineup.queue_length(application, job).should == 2
     end
 
-    context 'with Rails' do
+    context 'when the key for the List Job Queue is occupied by the wrong data format' do
       before do
-        ensure_module :Rails
-        Rails.stub!(:logger).and_return(logger)
+        redis.set 'other_app:resque:queue:send_email', :anything_but_a_list
       end
 
-      it 'is the Rails logger' do
-        lineup.config.logger.should be Rails.logger
+      it 'logs the error' do
+        Trouble.should_receive(:notify) do |exception, metadata|
+          exception.should be_instance_of Redis::CommandError
+          metadata[:code].should == :getting_queue_length_failed
+          metadata[:application].should == ':otherApp'
+          metadata[:job].should == ':SendEmail'
+          metadata[:caller].should include('line_up_spec.rb')
+        end
+        lineup.queue_length(application, job)
+      end
+
+      it "returns false" do
+        lineup.queue_length(application, job).should be_false
       end
     end
   end
 
+  describe ".ensure" do
+
+    it "pushes the job if the queue is empty" do
+      lineup.should_receive(:push).with(application, job, *args)
+      lineup.ensure application, job, *args
+    end
+
+    it "does not push the job if the queue already has a job with the same name" do
+      lineup.push application, job, *args
+      lineup.should_not_receive(:push)
+      lineup.ensure application, job, *args
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: line_up
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-13 00:00:00.000000000 Z
+date: 2013-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trouble
@@ -50,7 +50,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -58,7 +58,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -119,6 +119,7 @@ files:
 - lib/line_up/string_extensions.rb
 - lib/line_up/version.rb
 - lib/line_up.rb
+- spec/lib/line_up/configuration_spec.rb
 - spec/lib/line_up_spec.rb
 - spec/spec_helper.rb
 - README.md