limit_detectors 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 19b534365562333e42bee1656992c44a58935616
-  data.tar.gz: 4e4eedd3a948fdbdd494d8b9ad4be99741822b84
+  metadata.gz: 7644179e8d3eebef16e330ab12f116dd998bd296
+  data.tar.gz: dfa8b5e932662cfacb2ae1544a8fc45e02efba88
 SHA512:
-  metadata.gz: 551125436affcdaf9720eadeec53ee228b9d217ab298e6553bd6c498f8aa5b642179c50c32ac26a3b1c67cebf1feeeed26acf7ae3ac0f74a95862d1aaa877e10
-  data.tar.gz: 21eed54f9b88dcfec2b964b17c8afe80c086e37e4a41c7a36f2cb0d10cbce57f377460a5c4281736f718779b6c0022266aec27004625fbea8c527db3eea44a4c
+  metadata.gz: 524180318768013866c5b7fa49adf446cbd2dc0062f596676cdd83ceac77a19bcf1c71b47a4b9c81014566609890965204bd6a69a091d4d3d3e912d63ac7368f
+  data.tar.gz: 6a4d3d272d93b6220e7194904e949d48da916169bf7cc7260137a6bad65df98ec8f604cc44a6322f2a97fed5917b79543dcd699b2947035e074c9e09b4123acc

data/.travis.yml

@@ -5,3 +5,5 @@ rvm:
   - "2.0"
   - "2.1"
   - "2.1.1"
+  - jruby
+  - rbx

data/Gemfile

@@ -2,3 +2,11 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in limit_detectors.gemspec
 gemspec
+
+
+# To support Rubinius on Travis-CI
+platforms :rbx do
+  gem 'racc'
+  gem 'rubysl', '~> 2.0'
+  gem 'psych'
+end

data/README.md

@@ -48,13 +48,13 @@ may not be compatible with the current version.
 
 This gem is tested with these (MRI) Ruby versions:
 
-* 1.8.7
-* 1.9.3
-* 2.0
-* 2.1
-* 2.1.1
-
+* 1.8.7,
+* 1.9.3,
+* 2.0,
+* 2.1,
+* 2.1.1,
 
+as well as current version of Jruby and Rubinius.
 
 ## Contributing
 

data/lib/limit_detectors.rb

@@ -2,15 +2,27 @@ require 'limit_detectors/version'
 
 module LimitDetectors
 
+  # Deprecated, use at_mmost? instead
+  def at_most(limit, &block)
+    Kernel.warn "'at_most' is deprecated, use 'at_most?' instead"
+    at_most? limit, &block
+  end
+
+  # Deprecated, use at_mmost? instead
+  def at_least(limit, &block)
+    Kernel.warn "'at_least' is deprecated, use 'at_least?' instead"
+    at_least? limit, &block
+  end
+
   # Check whether the condition given in the block
   # occurs at most limit times in the collection
-  def at_most(limit, &block)
+  def at_most?(limit, &block)
     ocurrences_of(&block) <= limit
   end
 
   # Check whether the condition given in the block
   # occurs at least limit times in the collection
-  def at_least(limit, &block)
+  def at_least?(limit, &block)
     ocurrences_of(&block) >= limit
   end
 

data/lib/limit_detectors/version.rb

@@ -1,3 +1,3 @@
 module LimitDetectors
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/limit_detectors_spec.rb

@@ -5,57 +5,70 @@ Array.send :include, LimitDetectors
 describe '#at_most' do
 
   it 'is true for an empty Array' do
-    expect([].at_most(5){ true }).to be_true
+    expect(Kernel).to_not receive(:warn)
+    expect([].at_most?(5){ true }).to be_true
   end
 
   it 'is true if the criterion is met once' do
-    expect(["it's there"].at_most(1){ |el| el == "it's there"}).to be_true
+    expect(["it's there"].at_most?(1){ |el| el == "it's there"}).to be_true
   end
 
   it 'is true if all elements meet the criterion and the size is the given maximum number' do
-    expect([1,1,1].at_most(3){|e| e == 1})
+    expect([1,1,1].at_most?(3){|e| e == 1})
   end
 
   it 'is false if not enough elements meet the criterion' do
-    expect([1, 2, 4].at_most(1){|e| e.even?}).to be_false
+    expect([1, 2, 4].at_most?(1){|e| e.even?}).to be_false
   end
 
   it 'is true if 0 elements are expected to match' do
     r = Array.new(10){rand}
-    expect(r.at_most(0){ |i| i > 2 }).to be_true
+    expect(r.at_most?(0){ |i| i > 2 }).to be_true
   end
 
   describe 'Hash#at_most' do
     Hash.send :include, LimitDetectors
     it 'detects a condition based on key as well as value properties' do
       h = { 'foo' => 1, 'bar' => 4, 'baz' => 5, 'bum' => 1, 'fum' => 0}
-      expect( h.at_most(3){|ky,vl| ky.match(/^b/) || vl > 1  }).to be_true
+      expect( h.at_most?(3){|ky,vl| ky.match(/^b/) || vl > 1  }).to be_true
     end
   end
 
 end
 
 describe '#at_least' do
-  it 'is true for an empty Array' do
-    expect([].at_least(1){ true }).to be_false
+  it 'is false for an empty Array' do
+    expect(Kernel).to_not receive(:warn)
+    expect([].at_least?(1){ true }).to be_false
+    expect([].at_least?(1){ false }).to be_false
   end
 
-  it 'is true if the criterion is met once' do
-    expect(["it's there"].at_least(1){ |el| el == "it's there"}).to be_true
+  it 'is true if the expected number is 0 and Array is empty' do
+    expect([].at_least?(0){ true }).to be_true
+    expect([].at_least?(0){ false }).to be_true
   end
 
-  it 'is true if all elements meet the criterion and the size is the given maximum number' do
-    expect([1,1,1].at_least(3){|e| e == 1})
+  it 'is false if the container ist smaller than the expected number' do
+    size = 10
+    expect(Array.new(10).at_least?(size + 1){true}).to be_false
   end
 
-  it 'is false if not enough elements meet the criterion' do
-    expect([1, 2, 4].at_least(1){|e| e.even?}).to be_true
+  it 'is true if the criterion is met and expected once' do
+    expect(["it's there"].at_least?(1){ |el| el == "it's there"}).to be_true
   end
 
-  it 'is true if 0 elements are expected to match' do
+  it 'is true if all elements meet the criterion and the size is the given minimum number' do
+    expect([1,1,1].at_least?(3){|e| e == 1}).to be_true
+  end
+
+  it 'is true if enough elements meet the criterion' do
+    expect([1, 2, 4, 8].at_least?(2){|e| e.even?}).to be_true
+  end
+
+  it 'is true if there are enough elements to match' do
     r = Array.new(10){|i|i}
-    expect(r.at_least(7){ |i| i > 2 }).to be_true
-    expect(r.at_least(8){ |i| i > 2 }).to be_false
+    expect(r.at_least?(7){ |i| i > 2 }).to be_true
+    expect(r.at_least?(8){ |i| i > 2 }).to be_false
   end
 
 end
@@ -64,6 +77,18 @@ describe 'Using an object that doesn\'t respond to #inject will raise an excepti
   object = Object.new
   object.extend LimitDetectors
   it 'will raise an exception, if it\'s sent #atmost' do
-    expect{ object.at_most(1){ |el| el.condition? } }.to raise_exception(NoMethodError, /undefined method .inject./)
+    expect{ object.at_most?(1){ |el| el.condition? } }.to raise_exception(NoMethodError, /undefined method .inject./)
   end
 end
+
+describe 'Give a warning, if non-predicate versions are used' do
+  it 'sends message Kernel.warn, if old-style method is used for at_most' do
+    expect(Kernel).to receive(:warn).with(/'at_most'.+deprecated.+'at_most\?'/)
+    [1,2,4,8].at_most(2) {|e| e.even?}
+  end
+
+  it 'sends message Kernel.warn, if old-style method is used for at_least' do
+    expect(Kernel).to receive(:warn).with(/'at_least'.+deprecated.+'at_least\?'/)
+    [1,2,4,8].at_least(2) {|e| e.even?}
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: limit_detectors
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Stephan Kämper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-21 00:00:00.000000000 Z
+date: 2014-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler