lilypad 0.1.2 → 0.1.3

data/README.markdown

@@ -15,7 +15,6 @@ Use it
 
 <pre>
 require 'rack/lilypad'
-
 use Rack::Lilypad, 'fd48c7d26f724503a0280f808f44b339fc65fab8'
 </pre>
 
@@ -27,6 +26,23 @@ use Rack::Lilypad, 'fd48c7d26f724503a0280f808f44b339fc65fab8' do |hoptoad|
 end
 </pre>
 
+In Rails, you may need to do this:
+
+<pre>
+ENV['RACK_ENV'] = ENV['RAILS_ENV']
+</pre>
+
+Debug
+-----
+
+Use the log option to see what is happening:
+
+<pre>
+use Rack::Lilypad, 'fd48c7d26f724503a0280f808f44b339fc65fab8' do |hoptoad|
+  hoptoad.log = '/var/www/log/hoptoad.log'
+end
+</pre>
+
 Thanks
 ------
 

data/gemspec.rb

@@ -13,5 +13,5 @@ GEM_SPEC = Gem::Specification.new do |s|
   s.name = GEM_NAME
   s.platform = Gem::Platform::RUBY
   s.require_path = "lib"
-  s.version = "0.1.2"
+  s.version = "0.1.3"
 end

data/lib/rack/lilypad.rb

@@ -6,13 +6,15 @@ module Rack
   class Lilypad
     
     attr_accessor :filters
+    attr_accessor :log
 
     def initialize(app, api_key = nil)
       @app = app
       @filters = []
+      @log = false
       yield self if block_given?
       @filters.flatten!
-      @hoptoad = Hoptoad.new(api_key, @filters)
+      @hoptoad = Hoptoad.new(api_key, @filters, @log)
     end
 
     def call(env)
@@ -29,9 +31,10 @@ module Rack
 
     class Hoptoad
       
-      def initialize(api_key = nil, filters = [])
+      def initialize(api_key, filters, log)
         @api_key = api_key
         @filters = filters
+        @log = log
       end
       
       def backtrace(exception)
@@ -49,6 +52,10 @@ module Rack
         end
       end
       
+      def log(msg)
+        ::File.open(@log, 'a') { |f| f.write(msg) } if @log
+      end
+      
       def post(exception, env)
         return unless production?
         uri = URI.parse("http://hoptoadapp.com/notices/")
@@ -59,11 +66,17 @@ module Rack
           }
           http.read_timeout = 5 # seconds
           http.open_timeout = 2 # seconds
-          begin
+          response = begin
             http.post uri.path, xml(exception, env), headers
             env['hoptoad.notified'] = true
           rescue TimeoutError => e
           end
+          case response
+          when Net::HTTPSuccess then
+            log "Hoptoad Success: #{response.class}"
+          else
+            log "Hoptoad Failure: #{response.class}\n\n#{response.body if response.respond_to? :body}\n\n#{@@last_response}"
+          end
         end
       end
       

data/spec/rack/lilypad_spec.rb

@@ -10,21 +10,34 @@ describe Rack::Lilypad do
   
   before(:each) do
     ENV['RACK_ENV'] = 'production'
+    @app = lambda { |env| raise TestError, 'Test' }
+    @env = Rack::MockRequest.env_for("/raise")
     @http = mock(:http)
     @http.stub!(:read_timeout=)
     @http.stub!(:open_timeout=)
-    @http.stub!(:post)
+    @http.stub!(:post).and_return Net::HTTPSuccess
     Net::HTTP.stub!(:start).and_yield(@http)
   end
   
-  it "yields a configuration object to the block when created" do
-    notifier = Rack::Lilypad.new(lambda {}, '') do |app|
+  it "should yield a configuration object to the block when created" do
+    notifier = Rack::Lilypad.new(@app, '') do |app|
       app.filters << %w(T1 T2)
     end
     notifier.filters.should include('T1')
     notifier.filters.should include('T2')
   end
   
+  it "should write to a log if specified" do
+    path = "#{SPEC}/fixtures/hoptoad.log"
+    notifier = Rack::Lilypad.new(@app, '') do |app|
+      app.log = path
+    end
+    notifier.call(@env) rescue nil
+    File.exists?(path).should == true
+    File.delete path
+    File.exists?(path).should == false
+  end
+  
   it "should post an error to Hoptoad" do
     @http.should_receive(:post)
     get "/raise" rescue nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: lilypad
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Winton Welsh