lightweight_user_agent_parser 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d4a832dabf1e799e41f3e7923924f742f3bbea3
-  data.tar.gz: 02963528db35f5ff59c17d46533b754f07fb7887
+  metadata.gz: 04a55b38d3ecf70c795febaa61b68981bc1888b5
+  data.tar.gz: 9b13ef73e36f46ad8de140375f87b18a1c36dc9e
 SHA512:
-  metadata.gz: 82cd70103cc1fe4c65acb1063d5958a4103a85304f5c4110600125519b873407aab2922ce46dd2cac02080dd7f4de1f248af5469ac5aa5b77cdfa9cdcda8bde5
-  data.tar.gz: ac138337c6af9a100005121de9e02b5fb174ae820c3a44d524be4d6726037bd8822b238f5d8ea424b8f6cf238c743e4d5d16e8a00858d1f9ac40051662f75342
+  metadata.gz: ad069fbad7fb6c497930c71b397c6248bb692f3883d67095396d358b4149139be6de207507a22ad816d642e188f49798ccc080ef6fefdb9d5ac015d60f6fd8aa
+  data.tar.gz: 2dab9275d52f62360b5af65e95ef2e15cb3ca38c8f7e0f4736495ffd7fe341186567d794b52860c54fa57ee4987fb670798ce87efb17fb575391997d4101ca1d

data/lib/lightweight_user_agent_parser.rb

@@ -12,7 +12,7 @@ class LightweightUserAgentParser
   alias to_s user_agent_string
 
   def initialize(user_agent_str)
-    @user_agent_string = user_agent_str || raise(ArgumentError)
+    @user_agent_string = (user_agent_str || raise(ArgumentError)).to_s
   end
 
   def platform
@@ -30,7 +30,6 @@ class LightweightUserAgentParser
         end
       end
 
-      # if detected as a mobile such as Nokia C2-01 and others than Symbian
       return :other
 
     }.call
@@ -40,7 +39,7 @@ class LightweightUserAgentParser
     mobile = !!(user_agent_string =~ MOBILE_REGEXP)
     desktop = !!(user_agent_string =~ DESKTOP_REGEXP)
 
-    (mobile or not desktop) #and not anonymized?
+    (mobile or not desktop) and not empty?
   end
 
   alias mobile? is_mobile?
@@ -49,4 +48,10 @@ class LightweightUserAgentParser
     !!(user_agent_string =~ ANONYMIZED_REGEXP)
   end
 
+  protected
+
+  def empty?
+    user_agent_string.empty?
+  end
+
 end

data/lib/lightweight_user_agent_parser/version.rb

@@ -1,3 +1,3 @@
 class LightweightUserAgentParser
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.3.1'.freeze
 end

data/spec/lightweight_user_agent_parser_spec.rb

@@ -3,6 +3,12 @@ require 'spec_helper'
 RSpec.describe LightweightUserAgentParser do
 
   TEST_CASES = [
+
+      {
+          ua_str: '',
+          mobile: false,
+          platform: 'other'
+      },
       {
           ua_str: 'UCWEB/2.0 (Linux; U; Adr 4.2.1; zh-CN; Lenovo A3000) U2/1.0.0 UCBrowser/9.8.5.442 U2/1.0.0 Mobile',
           mobile: true,
@@ -112,11 +118,15 @@ RSpec.describe LightweightUserAgentParser do
     TEST_CASES.each do |meta|
 
       context "when platform is #{meta[:platform]}" do
-        let(:ua_str) { meta[:ua_str] }
 
-        it "then the mobile state should be #{meta[:mobile]}" do
-          is_expected.to eq meta[:mobile]
+        context "and the user agent string is: #{meta[:ua_str].inspect}" do
+          let(:ua_str) { meta[:ua_str] }
+
+          it "then the mobile state should be #{meta[:mobile]}" do
+            is_expected.to eq meta[:mobile]
+          end
         end
+
       end
 
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lightweight_user_agent_parser
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Emarsys Technologies