lightrail_stripe 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '0870e939ca6c8301e58b197d60406d893ebcc04a'
-  data.tar.gz: 48214fff42bd21c8a8067c38e198b219a7ec73bc
+  metadata.gz: bf24c31aac59035ef5eab9e90857dadc1d9e4aab
+  data.tar.gz: d9f2f8734f528ee81b5463a1d902bbd5a58ec41d
 SHA512:
-  metadata.gz: 97aede42f3020b5cd3ba135b96f8848c510f6a36965d459490686260a11869323f8031da5112d80e1e8eeb0d238171bf859b4504ec9574b408b4c44c00554069
-  data.tar.gz: 6249dbb30a3e91c2f13eff5efdede46be2aa258722523e8e1bc467cececce57141c936d4bcc933b9a9c3c799dfa86b4049c20d7f2edd3fa2a4881de304797cd0
+  metadata.gz: 14ec104eb935d404daf405d212f1ee877b40a942028103abe2df9672be593f50dfd490ed8743982e66d03aac7f7220f384308a6981ef10e6014691cb9709f6a6
+  data.tar.gz: bf3724b197efff1923a73b1f73ed612b01c0a43cb720c870a0e74a4d5508c86c97075bb3d4af2f1cc8f1ff7b200e3aafde075f658734d1af35adcbe200a97c4c

data/lib/lightrail_stripe/split_tender_validator.rb

@@ -1,16 +1,19 @@
 module Lightrail
   class SplitTenderValidator < Lightrail::Validator
 
-    def self.validate_split_tender_charge_params! (split_tender_charge_params)
-      begin
-        return true if ((split_tender_charge_params.is_a? Hash) &&
-            Lightrail::Validator.validate_amount!(split_tender_charge_params[:amount]) &&
-            Lightrail::Validator.validate_currency!(split_tender_charge_params[:currency]) &&
-            (self.has_lightrail_payment_option?(split_tender_charge_params) ||
-                self.has_stripe_payment_option?(split_tender_charge_params)))
-      rescue Lightrail::LightrailArgumentError
-      end
-      raise Lightrail::LightrailArgumentError.new("Invalid split_tender_charge_params: #{split_tender_charge_params.inspect}")
+    def self.validate_split_tender_charge_params! (split_tender_charge_params, lr_share=0)
+
+      raise Lightrail::LightrailArgumentError.new("Invalid split_tender_charge_params - must be a hash: #{split_tender_charge_params.inspect}") unless (split_tender_charge_params.is_a? Hash)
+
+      raise Lightrail::LightrailArgumentError.new("Invalid amount in split_tender_charge_params: #{split_tender_charge_params.inspect}") unless Lightrail::Validator.validate_amount!(split_tender_charge_params[:amount])
+
+      raise Lightrail::LightrailArgumentError.new("Amount in split_tender_charge_params less than specified Lightrail share of #{lr_share}: #{split_tender_charge_params.inspect}") unless (split_tender_charge_params[:amount] >= lr_share)
+
+      raise Lightrail::LightrailArgumentError.new("Invalid currency in split_tender_charge_params: #{split_tender_charge_params.inspect}") unless Lightrail::Validator.validate_currency!(split_tender_charge_params[:currency])
+
+      raise Lightrail::LightrailArgumentError.new("Must provide a payment method for either Lightrail or Stripe: #{split_tender_charge_params.inspect}") unless (self.has_lightrail_payment_option?(split_tender_charge_params) || self.has_stripe_payment_option?(split_tender_charge_params))
+
+      return true
     end
 
     def self.has_stripe_payment_option?(charge_params)

data/lib/lightrail_stripe/stripe_lightrail_split_tender_charge.rb

@@ -4,7 +4,7 @@ module Lightrail
 
     def self.create (charge_params, lr_share)
       # Convert to Translator.translate_split_tender_charge_params!()
-      Lightrail::SplitTenderValidator.validate_split_tender_charge_params!(charge_params)
+      Lightrail::SplitTenderValidator.validate_split_tender_charge_params!(charge_params, lr_share)
 
       total_amount = charge_params[:amount]
       currency = charge_params[:currency]
@@ -55,7 +55,7 @@ module Lightrail
     end
 
     def self.simulate (charge_params, lr_share)
-      Lightrail::SplitTenderValidator.validate_split_tender_charge_params!(charge_params)
+      Lightrail::SplitTenderValidator.validate_split_tender_charge_params!(charge_params, lr_share)
 
       total_amount = charge_params[:amount]
       currency = charge_params[:currency]

data/lib/lightrail_stripe/version.rb

@@ -1,3 +1,3 @@
 module LightrailStripe
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lightrail_stripe
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Lightrail
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-18 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler