light_store 0.0.1 → 0.0.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: bb309c6ef19cbc223dae997c56c151c239eed2bc
+  data.tar.gz: 1602d8998fd1aa3eee4b0dc530f36d8588ee6f42
+SHA512:
+  metadata.gz: e203288dcb0e5740f2471801116e19b840fa9b1f75d20aa38920289216611020314de90088be18800dfd2e82897fee1be1b36277db685e7f4bf8d2991f024f97
+  data.tar.gz: 4fd957efae0dc08162dbcb8c83da8447f1788bfb80aba877904e27884d64d2f4e62a87cee53e6b24e6b4c7436405cb5defca5d8dd199751a0a00499c096551df

data/README.md

@@ -2,15 +2,15 @@
 
 A library for storing data about an object in spreadsheet-like format (array of hashes).
 
-This library aims to provide an easy way to store data about objects.  Data that is typically generated with complex queries could be stored in a flat format.  This is meant to be a general purpose library, but it was created to improve performance of dynamic report generators.  This comes from an idea that each 'row' of report data could be identified by the object id and a secondary id relevant to the report.  
+This library aims to provide an easy way to store data about objects.  Data that is typically generated with complex queries could be stored in a flat format.  This is meant to be a general purpose library, but it was created to improve performance of dynamic report generators.  This comes from an idea that each 'row' of report data could be identified by the object id and a date constraint relevant to the report.  
 
 Data format example: `[{account_id: 1, month: '2014-11', revenue: 987.65}, {account_id: 1, month: '2014-12', revenue: 1234.56}]`
 
-In the above example `account_id:` is a primary id and `month:` is a secondary id.
+In the above example `account_id:` is a primary key and `month:` is a date constraint field.
 
 ## Installation
 
-This gem relies on redis for storage.
+This gem relies on [redis](http://redis.io/) for storage.  This gem depends on [redis-rb](https://github.com/redis/redis-rb) gem.  Please be sure that it's installed and working correctly.
 
 Add this line to your application's Gemfile:
 
@@ -34,13 +34,8 @@ Define a class:
 
 ```ruby
 class RevenueReport < LightStore::Data
- set_prefix 'revenue_report'
- set_primary_key :id       # default
- set_secondary_key :month  # required
- 
- set_sortable_field :month, :datetime
- set_sortable_field :revenue, :float
- set_sortable_field :number_of_orders, :integer
+ primary_field :id
+ date_constraint_field :month  # required
 end
 ```
 
@@ -67,16 +62,16 @@ data = RevenueReport.get_data()
 
 Getting data for a given id:
 ```ruby
-data = RevenueReport.get_data(2)
+data = RevenueReport.get_data(primary_key: 2)
 ```
 
 Getting data for a given id within range:
 ```ruby
-data = RevenueReport.get_sorted_data(2, :month, '2012-02', '2012-04')
-# or
-data = RevenueReport.get_sorted_data(2, :number_of_orders, 20, 30)
+data = RevenueReport.get_sorted_data(primary_key: 2, date_range: ['2012-02', '2012-04'])
 ```
 
+Running `RevenueReport.add_data(data)` for the same data will not result in duplication.  The dataset passed to `light_store` instance could be the same or slightly different, it doesn't matter.  All records will be handled correctly.  `LightStore` will generate a key that combines primary key and date constraint field.  Data corresponding to that record will be either created or updated.
+
 
 ## Contributing
 

data/lib/light_store.rb

@@ -1,6 +1,7 @@
 require "light_store/version"
 require "light_store/configuration"
 require "light_store/class_methods"
+require "light_store/class_accessor_methods"
 
 module LightStore
 
@@ -15,6 +16,7 @@ module LightStore
   class << self
     def included(base)
       base.extend ClassMethods
+      base.extend ClassAccessorMethods
     end
   end
 

data/lib/light_store/class_accessor_methods.rb

@@ -0,0 +1,51 @@
+module LightStore
+  module ClassAccessorMethods
+    def base_name
+      "LightStore:#{self.name}"
+    end
+
+    def primary_field(x = nil)
+      @primary_field = x unless x.nil?
+      raise ArgumentError, 'primary_field must be set' unless @primary_field
+      @primary_field
+    end
+
+    def date_constraint_field(x = nil)
+      @date_constraint_field = x if x
+      raise ArgumentError, 'date_constraint_field must be set' unless @date_constraint_field
+      @date_constraint_field
+    end
+
+    def row=(h)
+      @row = h
+    end
+
+    def row
+      @row
+    end
+
+    def primary_key
+      row[primary_field]
+    end
+
+    def secondary_key
+      Time.parse(row[date_constraint_field].to_s).to_i
+    end
+
+    def row_key
+      "#{base_name}:row:#{primary_key}:#{secondary_key}"
+    end
+
+    def row_reference_key
+      "#{base_name}:key:#{primary_key}:#{secondary_key}"
+    end
+
+    def primary_range_key(x)
+      "#{base_name}:primary_range:#{x}"
+    end
+
+    def range_key
+      "#{base_name}:range"
+    end
+  end
+end

data/lib/light_store/class_methods.rb

@@ -4,51 +4,6 @@ module LightStore
       LightStore.configuration.redis
     end
 
-    def set_namespace(x)
-      @namespace = x
-    end
-
-    def namespace
-      @namespace ||= 'light_store'
-    end
-
-    def set_prefix(x)
-      @prefix = x
-    end
-
-    def prefix
-      @prefix ||= self.name
-    end
-
-    def set_primary_key(x)
-      @primary_key = x
-    end
-
-    def primary_key
-      @primary_key ||= :id
-    end
-
-    def set_secondary_key(x)
-      @secondary_key = x
-    end
-
-    def secondary_key
-      raise ArgumentError, 'secondary_key must be set' unless @secondary_key
-      @secondary_key
-    end
-
-    def set_sortable_field(field_name, field_type = :integer)
-      allowed_field_types = [:integer, :float, :datetime]
-      raise ArgumentError, 'field_type must be [:integer, :float, :datetime]' unless allowed_field_types.include?(field_type)
-      h = {field_name: field_name, field_type: field_type}
-      @sortable_fields = self.sortable_fields
-      @sortable_fields.push(h) unless @sortable_fields.include?(h)
-    end
-
-    def sortable_fields
-      @sortable_fields ||= []
-    end
-
     def marshal(h)
       Marshal.dump(h)
     end
@@ -57,149 +12,97 @@ module LightStore
       Marshal.load(h)
     end
 
-    def base_key
-      "#{namespace}:#{prefix}"
-    end
-
-    def base_data_key
-      "#{base_key}:data"
-    end
-
-    def base_member_ids_key
-      "#{base_key}:member_ids"
-    end
-
-    def base_sorted_member_ids_key
-      "#{base_key}:sorted_member_ids"
-    end
-
-    def get_primary_id(h)
-      raise ArgumentError, 'primary_id must be set' unless h[primary_key]
-      h[primary_key]
-    end
-
-    def get_secondary_id(h)
-      raise ArgumentError, 'secondary_key must be set' unless h[secondary_key]
-      h[secondary_key]
-    end
-
-    def get_data_row_key(h)
-      "#{base_data_key}:#{get_primary_id(h)}:#{get_secondary_id(h)}"
-    end
-
-    def get_member_id_key(h)
-      "#{base_member_ids_key}:#{get_primary_id(h)}"
-    end
-
-    def get_sorted_member_id_key(_primary_id, _sortable_field)
-      "#{base_sorted_member_ids_key}:#{_primary_id}:#{_sortable_field}"
-    end
-
-    def get_score(value, sortable_field_type)
-      raise ArgumentError, "value for #{sortable_field_type} must be set" unless value
-      case sortable_field_type
-      when :integer
-        value.to_i
-      when :float
-        value.to_f
-      when :datetime
-        if value.is_a? Time
-          value.to_i
-        else
-          Time.parse(value).to_i
-        end
+    def time_to_integer(t)
+      case t
+      when Integer, String
+        t = Time.new(t)
+      when Date, Time
+        # do nothing
       else
-        raise ArgumentError, "score value for #{sortable_field_type} must be in proper format"
+        raise ArgumentError, "#{t.inspect}: #{t.class.name} should be string,integer,date or time"
       end
+      Time.parse(t.to_s).to_i
     end
 
-    def add_member_id(h)
-      member_id_key = get_member_id_key(h)
-      data_row_key = get_data_row_key(h)
-      datastore.sadd(member_id_key, data_row_key)
-    end
-
-    def add_sorted_member_ids(h)
-      sortable_fields.each do |s|
-        field_name = s[:field_name]
-        field_type = s[:field_type]
-        add_sorted_member_id(h, field_name, field_type)
+    def add_data(data)
+      add_data_block = proc {
+        data.each do |h|
+          self.row = h
+          self.persist_row
+        end
+      }
+      if LightStore.configuration.pipelined?
+        datastore.pipelined do
+          add_data_block.call
+        end
+      else
+        add_data_block.call
       end
     end
 
-    def add_sorted_member_id(h, field_name, field_type)
-      primary_id = get_primary_id(h)
-      sorted_member_id = get_sorted_member_id_key(primary_id, field_name)
-      data_row_key = get_data_row_key(h)
-      value = h[field_name]
-      score = get_score(value, field_type)
-      datastore.zadd(sorted_member_id, score, data_row_key)
+    def persist_row
+      datastore.set(row_key, marshal(self.row))
+      datastore.set(row_reference_key, row_key)
+      _primary_range_key = primary_range_key(self.primary_key)
+      datastore.zadd(_primary_range_key, secondary_key, row_reference_key)
+      datastore.zadd(range_key, secondary_key, row_reference_key)
     end
 
-    def get_member_ids(_primary_key = nil)
-      key = _primary_key ? "#{base_member_ids_key}:#{_primary_key}" : base_member_ids_key
-      member_keys = datastore.keys("#{key}*")
-      member_keys.collect{ |k| datastore.smembers(k) }.flatten
-    end
-
-    def add_data(data)
-      added_records_count = 0
-      data.each do |h|
-        data_row_key = get_data_row_key(h)
-        marshaled_h = marshal(h)
-        new_member_check = add_member_id(h)
-        if new_member_check
-          datastore.set(data_row_key, marshaled_h)
-          add_sorted_member_ids(h)
+    def get_data(options = {})
+      reference_keys = []
+      if options.has_key?(:primary_key)
+        # With primary key.
+        if options.has_key?(:date_range)
+          # With date range.
+          reference_keys = get_data_by_range(options[:primary_key], *options[:date_range])
         else
-          old_value = datastore.getset(data_row_key, marshaled_h)
-          if old_value != marshaled_h
-            add_sorted_member_ids(h)
-          end
+          # date_range was not passed in, getting data for the key.
+          reference_keys = get_all_reference_keys(options[:primary_key])
+        end
+      else
+        # Without primary key.
+        if options.has_key?(:date_range)
+          reference_keys = get_data_by_range(nil, *options[:date_range])
+        else
+          # date_range was not passed in, getting all data.
+          reference_keys = get_all_reference_keys()
         end
-        added_records_count += 1 if new_member_check
       end
-      #plural_records = added_records_count == 1 ? "record" : "records"
-      return added_records_count
+      return [] if reference_keys.empty?
+      get_data_by_reference_keys(reference_keys)
     end
 
-    def get_data(_primary_key = nil)
-      data_keys = _primary_key ? get_member_ids(_primary_key) : get_member_ids()
-      return [] if data_keys.empty?
-      marshaled_data = datastore.mget(data_keys)
-      unmarshaled_data = marshaled_data.collect{ |d| unmarshal(d) }
+    def get_data_by_reference_keys(reference_keys)
+      row_keys = datastore.mget(reference_keys)
+      marshaled_data = datastore.mget(row_keys)
+      marshaled_data.collect{ |d| unmarshal(d) }
     end
 
-    def get_sorted_data(_primary_key, _sortable_field, min, max, options = {})
-      grouped_sortable_fields = sortable_fields.group_by { |f| f[:field_name] }
-      raise ArgumentError, "No sortable fields declared" if grouped_sortable_fields.empty?
-      raise ArgumentError, "sortable field '#{_sortable_field}' not declared" unless grouped_sortable_fields.has_key?(_sortable_field)
-      field_type = grouped_sortable_fields[_sortable_field].first[:field_type]
-      min = get_score(min, field_type) unless min == '-inf'
-      max = get_score(max, field_type) unless max == '+inf'
-      sorted_member_id = get_sorted_member_id_key(_primary_key, _sortable_field)
-
-      data_keys = datastore.zrangebyscore(sorted_member_id, min, max, options)
-      marshaled_data = datastore.mget(data_keys)
-      unmarshaled_data = marshaled_data.collect{ |d| unmarshal(d) }
+    def get_all_reference_keys(primary_key = nil)
+      key_substring = "#{base_name}:key:#{primary_key}*"
+      datastore.keys(key_substring)
     end
 
-    def clear_all_data
-      data_keys = datastore.keys("#{base_member_ids_key}*")
-      data_keys = data_keys.concat(datastore.keys("#{base_sorted_member_ids_key}*"))
-      data_keys = data_keys.concat(datastore.keys("#{base_data_key}*"))
-      clear(data_keys)
+    def get_data_by_range(_primary_key = nil, start_date, stop_date)
+      min = time_to_integer(start_date)
+      max = time_to_integer(stop_date)
+      if _primary_key.nil?
+        # range_key
+        return datastore.zrangebyscore(range_key, min, max)
+      else
+        # primary_range_key
+        _primary_range_key = primary_range_key(_primary_key)
+        return datastore.zrangebyscore(_primary_range_key, min, max)
+      end
     end
 
     def clear_all
-      all_keys = datastore.keys("#{base_key}*")
+      all_keys = datastore.keys("#{base_name}*")
       clear(all_keys)
     end
 
-    # make private.
     def clear(keys)
       deleted_count = datastore.del(keys) unless keys.empty?
     end
-
   end
 end

data/lib/light_store/configuration.rb

@@ -2,6 +2,7 @@ module LightStore
   class Configuration
     def initialize
       self.redis = nil
+      self.pipelined = true
     end
 
     def redis
@@ -11,5 +12,13 @@ module LightStore
     def redis=(r)
       @redis = r
     end
+
+    def pipelined?
+      @pipelined
+    end
+
+    def pipelined=(b)
+      @pipelined = b
+    end
   end
 end

data/lib/light_store/version.rb

@@ -1,3 +1,3 @@
 module LightStore
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/light_store.gemspec

@@ -21,6 +21,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "faker"
+  spec.add_development_dependency "mock_redis"
 
   spec.add_dependency "redis"
 end

data/spec/class_accessor_methods_spec.rb

@@ -0,0 +1,79 @@
+require 'light_store'
+require 'rubygems'
+require 'bundler'
+Bundler.setup(:default, :test)
+Bundler.require(:default, :test)
+
+require 'rspec'
+require 'redis'
+require 'logger'
+describe LightStore::Data do
+  before(:each) do
+    LightStore.configure do |config|
+      config.redis = Redis.new
+      config.pipelined = false
+    end
+  end
+  context 'for class accessor methods' do
+    before(:each) do
+      class TestReport < LightStore::Data
+        primary_field :some_field_name
+        date_constraint_field :some_date_field
+      end
+      class DefaultTestReport < LightStore::Data
+      end
+    end
+    context 'for base_name' do
+      it 'sets base_name' do
+        TestReport.base_name.should == 'LightStore:TestReport'
+      end
+    end
+    context 'for primary_field' do
+      it 'returns primary_field' do
+        TestReport.primary_field.should_not be_nil
+      end
+      it 'errors without primary_field' do
+        expect{DefaultTestReport.primary_field}
+          .to raise_error(ArgumentError, 'primary_field must be set')
+      end
+    end
+    context 'for date_constraint_field' do
+      it 'returns date_constraint_field' do
+        TestReport.date_constraint_field.should_not be_nil
+      end
+      it 'errors without date_constraint_field' do
+        expect{DefaultTestReport.date_constraint_field}
+          .to raise_error(ArgumentError, 'date_constraint_field must be set')
+      end
+    end
+    context 'for row' do
+      let(:date) { '2012-05-15' }
+      let(:key) { 1 }
+      let(:h) {{some_field_name: 1, some_date_field: date}}
+      before(:each) do
+        TestReport.row = h
+      end
+      it 'sets and gets row' do
+        TestReport.row.should == h
+      end
+      it 'gets primary_key' do
+        TestReport.primary_key.should == key
+      end
+      it 'gets secondary_key' do
+        TestReport.secondary_key.should == Time.parse(date).to_i
+      end
+      it 'has row_key' do
+        TestReport.row_key.should match(":row:#{TestReport.primary_key}:#{TestReport.secondary_key}")
+      end
+      it 'has row_reference_key' do
+        TestReport.row_reference_key.should match(":key:#{TestReport.primary_key}:#{TestReport.secondary_key}")
+      end
+      it 'has primary_range_key' do
+        TestReport.primary_range_key(TestReport.primary_key).should match(":primary_range:#{TestReport.primary_key}")
+      end
+      it 'has range_key' do
+        TestReport.range_key.should match(":range")
+      end
+    end
+  end
+end

data/spec/class_methods_spec.rb

@@ -0,0 +1,58 @@
+require 'light_store'
+require 'rubygems'
+require 'bundler'
+Bundler.setup(:default, :test)
+Bundler.require(:default, :test)
+
+require 'rspec'
+require 'redis'
+require 'logger'
+describe LightStore::Data do
+  before(:each) do
+    LightStore.configure do |config|
+      config.redis = Redis.new
+      config.pipelined = false
+    end
+  end
+  context 'for class methods' do
+    let(:dataset1) {
+        [
+          {id: 2, s_id: 20, name_1: 'John', name_2: 'Krakis', super_date: Time.new(2002)},
+          {id: 2, s_id: 25, name_1: 'Jake', name_2: 'Harken', super_date: Time.new(2003)},
+          {id: 3, s_id: 30, name_1: 'Jake', name_2: 'Marken', super_date: Time.new(2004)},
+          {id: 3, s_id: 35, name_1: 'Jake', name_2: 'Barken', super_date: Time.new(2005)},
+          {id: 3, s_id: 40, name_1: 'Jake', name_2: 'Farken', super_date: Time.new(2006)},
+          {id: 3, s_id: 45, name_1: 'Jake', name_2: 'Larken', super_date: Time.new(2007)},
+          {id: 3, s_id: 50, name_1: 'Jake', name_2: 'Tarken', super_date: Time.new(2008)},
+        ]
+      }
+    before(:each) do
+      class SomeReport < LightStore::Data
+        primary_field :id
+        date_constraint_field :super_date
+      end
+      SomeReport.add_data(dataset1)
+    end
+    after(:each) do
+      SomeReport.clear_all
+    end
+    # make these tests testier
+    describe '#add_data' do
+      it 'sets data' do
+        SomeReport.add_data(dataset1)
+      end
+      it 'gets data no args' do
+        SomeReport.get_data()
+      end
+      it 'gets data with primary key' do
+        SomeReport.get_data(primary_key: 2)
+      end
+      it 'gets data with date range' do
+        SomeReport.get_data(date_range: [2000, '2013'])
+      end
+      it 'gets data with primary key and date range' do
+        SomeReport.get_data(primary_key: 1, date_range: [Time.new(2001), Time.new(2013)])
+      end
+    end
+  end
+end

metadata

@@ -1,78 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: light_store
 version: !ruby/object:Gem::Version
-  version: 0.0.1
-  prerelease: 
+  version: 0.0.2
 platform: ruby
 authors:
 - Michael Kompanets
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-26 00:00:00.000000000 Z
+date: 2014-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: faker
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mock_redis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A library for storing data about an object in spreadsheet-like format
@@ -83,41 +102,42 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/light_store.rb
+- lib/light_store/class_accessor_methods.rb
 - lib/light_store/class_methods.rb
 - lib/light_store/configuration.rb
 - lib/light_store/version.rb
 - light_store.gemspec
-- spec/light_store_spec.rb
+- spec/class_accessor_methods_spec.rb
+- spec/class_methods_spec.rb
 homepage: https://github.com/mkompanets/light_store
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: This library aims to provide an easy way to store report data about objects.  Data
   that is typically generated with complex queries and methods could be stored in
   a flat and accessible format.  This is meant to be a general purpose library, but
@@ -125,5 +145,6 @@ summary: This library aims to provide an easy way to store report data about obj
   from an idea that each 'row' of report data could be identified by the object id
   and a secondary id relevant to the report.
 test_files:
-- spec/light_store_spec.rb
+- spec/class_accessor_methods_spec.rb
+- spec/class_methods_spec.rb
 has_rdoc: 

data/spec/light_store_spec.rb

@@ -1,299 +0,0 @@
-require 'light_store'
-require 'rubygems'
-require 'bundler'
-Bundler.setup(:default, :test)
-Bundler.require(:default, :test)
-
-require 'rspec'
-require 'redis'
-require 'logger'
-describe LightStore::Data do
-  before(:each) do
-    LightStore.configure do |config|
-      config.redis = Redis.new
-    end
-  end
-  context 'for class initialization' do
-    before(:each) do
-      class DefaultValuesClass < LightStore::Data
-      end
-      class SetValuesClass < LightStore::Data
-        set_namespace 'some_namespace'
-        set_prefix 'some_prefix'
-        set_primary_key 'some_id'
-        set_secondary_key 'some_secondary_key'
-        set_sortable_field :f1
-        set_sortable_field :f2, :integer
-        set_sortable_field :f3, :float
-        set_sortable_field :f4, :datetime
-      end
-      SetValuesClass.clear_all
-    end
-    describe 'DefaultValuesClass' do
-      let(:default_values_instance) { DefaultValuesClass.new }
-      it 'datastore type is Redis' do
-        DefaultValuesClass.datastore.class.name.should == 'Redis'
-      end
-      it 'sets class level namespace to light_store' do
-        DefaultValuesClass.namespace.should == 'light_store'
-      end
-      it 'sets class level prefix to class name' do
-        DefaultValuesClass.prefix.should == 'DefaultValuesClass'
-      end
-      it 'sets instance level namespace to light_store' do
-        default_values_instance.namespace.should == 'light_store'
-      end
-      it 'sets class level primary_key to :id by default' do
-        DefaultValuesClass.primary_key.should == :id
-      end
-      it 'sets instance level primary_key to :id by default' do
-        default_values_instance.primary_key.should == :id
-      end
-      it 'raises ArgumentError if secondary_key not set' do
-        expect{DefaultValuesClass.secondary_key}.to raise_error(ArgumentError)
-      end
-    end
-    describe 'SetValuesClass' do
-      let(:set_values_instance) { SetValuesClass.new }
-      let(:sample_h1) {
-        {
-          'some_id' => 1,
-          'some_secondary_key' => 's2',
-          f1: '1',
-          f2: '2',
-          f3: '3.2',
-          f4: Time.now,
-        }
-      }
-      context 'for class methods' do
-        it 'sets class namespace to some_namespace' do
-          SetValuesClass.namespace.should == 'some_namespace'
-        end
-        it 'sets class level prefix to some_prefix' do
-        SetValuesClass.prefix.should == 'some_prefix'
-      end
-        it 'sets class primary_key to some_id' do
-          SetValuesClass.primary_key.should == 'some_id'
-        end
-        it 'sets class secondary_key to some_secondary_key' do
-          SetValuesClass.secondary_key.should == 'some_secondary_key'
-        end
-      end
-      context 'for key setting methods' do
-        describe '#base_key' do
-          it 'sets key to #{namespace}:#{prefix}' do
-            k = "#{SetValuesClass.namespace}:#{SetValuesClass.prefix}"
-            SetValuesClass.base_key.should == k
-          end
-        end
-        describe '#base_member_ids_key' do
-          it 'sets key to #{base_key}:member_ids' do
-            k = "#{SetValuesClass.base_key}:member_ids"
-            SetValuesClass.base_member_ids_key.should == k
-          end
-        end
-        describe '#base_sorted_member_ids_key' do
-          it 'sets key to "#{base_key}:sorted_member_ids"' do
-            k = "#{SetValuesClass.base_key}:sorted_member_ids"
-            SetValuesClass.base_sorted_member_ids_key.should == k
-          end
-        end
-        describe '#base_data_key' do
-          it 'sets key to #{namespace}:#{prefix}:data' do
-            k = "#{SetValuesClass.namespace}:#{SetValuesClass.prefix}:data"
-            SetValuesClass.base_data_key.should == k
-          end
-        end
-        describe '#get_primary_id' do
-          it 'gets primary key' do
-            k = sample_h1['some_id']
-            SetValuesClass.get_primary_id(sample_h1).should == k
-          end
-          it 'raises ArgumentError if not set' do
-            expect{SetValuesClass.get_primary_id({})}.to raise_error(ArgumentError)
-          end
-        end
-        describe '#get_secondary_id' do
-          it 'gets secondary_key key' do
-            k = sample_h1['some_secondary_key']
-            SetValuesClass.get_secondary_id(sample_h1).should == k
-          end
-          it 'raises ArgumentError if not set' do
-            expect{SetValuesClass.get_secondary_id({})}.to raise_error(ArgumentError)
-          end
-        end
-        describe '#sortable_fields' do
-          it 'field_type defaults to integer' do
-            SetValuesClass.sortable_fields.should include({field_name: :f1, field_type: :integer})
-          end
-        end
-        describe '#get_data_row_key' do
-          it 'gets data row key' do
-            d = SetValuesClass.get_data_row_key(sample_h1)
-            base_key = SetValuesClass.base_data_key
-            primary_id = SetValuesClass.get_primary_id(sample_h1)
-            secondary_id = SetValuesClass.get_secondary_id(sample_h1)
-            d.should == "#{base_key}:#{primary_id}:#{secondary_id}"
-          end
-        end
-        describe '#get_member_id_key' do
-          it 'gets member id key' do
-            d = SetValuesClass.get_member_id_key(sample_h1)
-            base_key = SetValuesClass.base_member_ids_key
-            primary_id = SetValuesClass.get_primary_id(sample_h1)
-            d.should == "#{base_key}:#{primary_id}"
-          end
-        end
-        describe '#get_sorted_member_id_key' do
-          it 'gets sorted member id key' do
-            field_name = SetValuesClass.sortable_fields.first[:field_name]
-            primary_id = SetValuesClass.get_primary_id(sample_h1)
-            d = SetValuesClass.get_sorted_member_id_key(sample_h1, field_name)
-          end
-        end
-        describe '#get_score' do
-          it 'gets the score for integer type' do
-            v = 1
-            SetValuesClass.get_score(v, :integer).should be_a Integer
-          end
-          it 'gets the score for float type' do
-            v = 1
-            SetValuesClass.get_score(v, :float).should be_a Float
-          end
-          it 'gets the score for datetime type' do
-            v = Time.now.to_s
-            SetValuesClass.get_score(v, :datetime).should be_a Integer
-          end
-          it 'raises an error for nil value' do
-            v = nil
-            expect{SetValuesClass.get_score(v, :unknown)}.to raise_error(ArgumentError)
-          end
-          it 'raises an error for unexpected type' do
-            v = Time.now.to_s
-            expect{SetValuesClass.get_score(v, :unknown)}.to raise_error(ArgumentError)
-          end
-        end
-        describe '#add_member_id' do
-          it 'adds member id to set' do
-            SetValuesClass.add_member_id(sample_h1).should be_true
-            row_id = SetValuesClass.get_data_row_key(sample_h1)
-            SetValuesClass.get_member_ids.should include(row_id)
-          end
-        end
-        describe '#add_sorted_member_ids' do
-          it 'adds sorted member ids to set' do
-            SetValuesClass.add_sorted_member_ids(sample_h1)
-          end
-        end
-        describe '#add_sorted_member_id' do
-          it 'adds sorted member id to set' do
-            field_name = SetValuesClass.sortable_fields.first[:field_name]
-            field_type = SetValuesClass.sortable_fields.first[:field_type]
-            SetValuesClass.add_sorted_member_id(sample_h1, field_name, field_type)
-          end
-        end
-      end
-      context 'for instance methods' do
-        it 'sets instance namespace to some_namespace' do
-          set_values_instance.namespace.should == 'some_namespace'
-        end
-        it 'sets instance primary_key to some_id' do
-          set_values_instance.primary_key.should == 'some_id'
-        end
-        it 'sets instance secondary_key to some_secondary_key' do
-          set_values_instance.secondary_key.should == 'some_secondary_key'
-        end
-      end
-    end
-  end
-
-  context 'for class methods' do
-    let(:dataset1) {
-        [
-          {id: 2, s_id: 20, name_1: 'John', name_2: 'Krakis', super_date: Time.new(2002)},
-          {id: 2, s_id: 25, name_1: 'Jake', name_2: 'Harken', super_date: Time.new(2003)},
-          {id: 3, s_id: 30, name_1: 'Jake', name_2: 'Marken', super_date: Time.new(2004)},
-          {id: 3, s_id: 35, name_1: 'Jake', name_2: 'Barken', super_date: Time.new(2005)},
-          {id: 3, s_id: 40, name_1: 'Jake', name_2: 'Farken', super_date: Time.new(2006)},
-          {id: 3, s_id: 45, name_1: 'Jake', name_2: 'Larken', super_date: Time.new(2007)},
-          {id: 3, s_id: 50, name_1: 'Jake', name_2: 'Tarken', super_date: Time.new(2008)},
-        ]
-      }
-    before(:each) do
-      class SomeData < LightStore::Data
-        set_prefix 'some_data'
-        set_secondary_key :s_id
-        set_sortable_field :super_date, :datetime
-      end
-      SomeData.clear_all
-    end
-
-    describe '#add_data' do
-      it 'sets data' do
-        new_rows = SomeData.add_data(dataset1)
-      end
-      it 'does not duplicate data' do
-        SomeData.add_data(dataset1)
-        new_rows = SomeData.add_data(dataset1)
-        new_rows.should == 0
-      end
-    end
-    describe '#get_data' do
-      it 'gets data' do
-        new_rows = SomeData.add_data(dataset1)
-        data = SomeData.get_data
-        data.size.should == new_rows
-      end
-      it 'gets data in proper format' do
-        SomeData.add_data(dataset1)
-        data = SomeData.get_data
-        data.should be_a Array
-        data.first.should be_a Hash
-      end
-      it 'gets data correctly by id' do
-        SomeData.add_data(dataset1)
-
-        # Two rows for id: 2
-        data = SomeData.get_data(2)
-        data.size.should == 2
-
-        # Five rows for id: 3
-        data = SomeData.get_data(3)
-        data.size.should == 5
-      end
-    end
-    describe '#get_sorted_data' do
-      it 'get sorted data' do
-        SomeData.add_data(dataset1)
-        data = SomeData.get_sorted_data(3, :super_date, Time.new(2003), Time.new(2007))
-        data.size.should == 4
-      end
-      it 'get sorted data includes correctly sorted values' do
-        SomeData.add_data(dataset1)
-        data = SomeData.get_sorted_data(3, :super_date, Time.new(2003), Time.new(2007))
-        values_within_range = true
-        data.each do |h|
-          sorted_value = h[:super_date]
-          values_between_range = false unless sorted_value >= Time.new(2003) && sorted_value <= Time.new(2007)
-        end
-        values_within_range.should be_true
-      end
-    end
-    describe '#clear_all_data' do
-      it 'clears all data' do
-        SomeData.add_data(dataset1)
-        SomeData.clear_all_data
-        data = SomeData.get_data
-        data.size.should == 0
-      end
-    end
-    describe '#clear_all' do
-      it 'clears all data' do
-        SomeData.add_data(dataset1)
-        SomeData.clear_all
-        all_keys = SomeData.datastore.keys("#{SomeData.base_key}*")
-        all_keys.size.should == 0
-      end
-    end
-  end
-end