light_serializer 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25bb1a6af47fb69f5eabb3aaba9b52c2323751b86c3abd229c20935320f06c2c
-  data.tar.gz: 57b67a1e1d29806e0028c6f9b7ad069b99ba57253e99adcef249dd292b1cf633
+  metadata.gz: e19a7ae11ca3bfee4350cad7874ba08e2f07a01031886c51585dda15538b9963
+  data.tar.gz: 38e370df48a4f0ec77b627038320f045425a761c2dceb3021a032eadd387a402
 SHA512:
-  metadata.gz: 6c6f7a76a1e8c6f618547a9d0dbbc6e0a475ae2d009b0122b4b32de9572b378c6ebd61ee1dc41ddb74e0eed27be1afa1644f584cbd5a46c7959f95dbbd8a9925
-  data.tar.gz: f3e6c53d11d2495711506281626c037f7870d061115cbafcb0f9b6741969dd9f4ef0615c8f310a0751ff65cd4c42342f0f1ad9e9cb3b5d6d92a1119dea1d34a3
+  metadata.gz: 172a24e89701dbb0d0784ef48aed9e3565f11184abdf8f70bfa0a0bbdf605df822593bf7da179995988159fb42d53ba3ae431c0deea071add5b675edfd843962
+  data.tar.gz: f5c0dc2b82b75a95a547061d59e3682eb96828704a252a1f844c25b5ca3a29cc12de99f7e63621bef67e2d04fb91b2bf81c622cc85bbd54505193036bfd3c0a9

data/.reek.yml

@@ -8,3 +8,5 @@ detectors:
 
 exclude_paths:
   - vendor
+  - ./bench.rb
+

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    light_serializer (0.0.6)
+    light_serializer (0.0.8)
       oj (~> 3)
 
 GEM
@@ -37,9 +37,9 @@ GEM
     kwalify (0.7.2)
     method_source (0.9.0)
     minitest (5.11.3)
-    oj (3.7.1)
+    oj (3.7.4)
     parallel (1.12.1)
-    parser (2.5.1.2)
+    parser (2.5.3.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pry (0.11.3)
@@ -50,7 +50,7 @@ GEM
       pry (~> 0.10)
     rainbow (3.0.0)
     rake (10.5.0)
-    reek (5.1.0)
+    reek (5.2.0)
       codeclimate-engine-rb (~> 0.4.0)
       kwalify (~> 0.7.0)
       parser (>= 2.5.0.0, < 2.6, != 2.5.1.1)

data/bench.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
 require 'bundler/inline'
 
@@ -297,3 +299,4 @@ benchmark_collection(ams_arg: '(without logging)', oj_arg: '(with Oj)')
 # Associations
 benchmark_associations_instance
 benchmark_associations_collection
+# rubocop:enable Metrics/AbcSize,Metrics/MethodLength

data/lib/light_serializer/hashed_object.rb

@@ -54,7 +54,7 @@ module LightSerializer
     end
 
     def active_record_relation?(object)
-      !!(defined?(ActiveRecord::Relation) && object.is_a?(ActiveRecord::Relation))
+      defined?(ActiveRecord::Relation) && object.is_a?(ActiveRecord::Relation)
     end
 
     def hashed_entity(entity, nested_serializer)
@@ -71,6 +71,7 @@ module LightSerializer
       end
     end
 
+    # :reek:ManualDispatch
     def obtain_value(object, attribute)
       if serializer.respond_to?(attribute)
         serializer.public_send(attribute)

data/lib/light_serializer/helpers/with_custom_root.rb

@@ -3,8 +3,9 @@
 module LightSerializer
   module Helpers
     module WithCustomRoot
+      # :reek:UtilityFunction
       def with_custom_root(root)
-        root ? { root.to_sym => yield } : yield
+        root ? { root.to_s => yield } : yield
       end
     end
   end

data/lib/light_serializer/serialize_collection.rb

@@ -14,7 +14,7 @@ module LightSerializer
     end
 
     def to_json
-      with_custom_root(root) { Oj.dump(hashed_collection, mode: :compat) }
+      Oj.dump(collection_with_root, mode: :compat)
     end
 
     def to_hash
@@ -23,6 +23,10 @@ module LightSerializer
 
     private
 
+    def collection_with_root
+      with_custom_root(root) { hashed_collection }
+    end
+
     def hashed_collection
       collection.map { |entity| serializer.new(entity, context: context).to_hash }
     end

data/lib/light_serializer/serializer.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# :reek:TooManyInstanceVariables { max_instance_variables: 5 }
 module LightSerializer
   class Serializer
     attr_reader :object, :root, :context, :meta

data/lib/light_serializer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LightSerializer
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light_serializer
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Pavel Rodionov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-30 00:00:00.000000000 Z
+date: 2018-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj