light_operations 1.2.3 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 120f4477b3c4b1686f3d07cc4c564df3351f8578
-  data.tar.gz: f0e1b9faba7d576412ec3893b9a9403cf292743a
+  metadata.gz: 6eb1ef4942cfe0f54c0ffbd0eed62d760985938e
+  data.tar.gz: b7abe127ef43fda487f71433bd819a4f88d99975
 SHA512:
-  metadata.gz: 1d91b8c07498b912dab7fc457080421b4ca7100fda94c78e471f0dda274da955e8f96a63bb0d57942c95162de75d8cf42786005460bc1cec1df906c42722be1d
-  data.tar.gz: 7577acb71547cc68c16669c84f534cb9b52d56104f0be6bcb56c7f4b458ef35897b2d93238f98f83cfc88595d06e7539136bf45bab28175922c35bb7a62452a4
+  metadata.gz: 489534160e4dcdf6b79fa88bfd512cf863cf93eaae3098a3df0901a7d53a918e89cef871298eabf6f1636a8ee9165e9afd428f8094c48196aec8f0a5639aa50b
+  data.tar.gz: d3d817d97798ceaaefea0d55cb4e422e6e841f4de20736a11595f9d59d973521ef8944de1e02d6c106875fc0db321837832f78fad1df43df8389e2e92c593b7c

data/.rubocop.yml

@@ -40,10 +40,11 @@ Documentation:
   Enabled: false
 
 Metrics/LineLength:
-  Max: 120
+  Max: 180
 
 AllCops:
   Exclude:
     - '**/Guardfile'
     - '**/model_operations.gemspec'
     - '**/spec/support/factory_helper.rb'
+    - '**/tmp/*.rb'

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
 script: bundle exec rake
 rvm:
-  - 2.1.4
-  - 2.2.0
+  - 2.2.5
+  - 2.4.1

data/README.md

@@ -5,8 +5,8 @@
 [![Dependency Status](https://gemnasium.com/pniemczyk/light_operations.svg)](https://gemnasium.com/pniemczyk/light_operations)
 [![Code Climate](https://codeclimate.com/github/pniemczyk/light_operations/badges/gpa.svg)](https://codeclimate.com/github/pniemczyk/light_operations)
 
-When you want have slim controllers or some logic with several operations
-this gem could help you to have nice separated and clan code. CAN HELP YOU! :D
+When you want to have slim controllers or some logic with several operations
+this gem could help you to have nice separated and clean code. CAN HELP YOU! :D
 
 ## Installation
 
@@ -28,17 +28,17 @@ Or install it yourself as:
 
 ## How it works
 
-Basicly this is a Container for buissnes logic.
+Basically, this is a Container for business logic.
 
 You can define dependencies during initialization and run with custom parameters.
 When you define deferred actions on `success` and `fail` before operation execution is finished,
-after execution one of those action depend for execution result will be executed.
-Actions could be a block (Proc) or you could delgate execution to method other object,
-by binding operation with specific object with those methods.
+after execution one of those actions depend on for execution result will be executed.
+Actions could be a block (Proc) or you could delegate execution to method another object,
+by binding operation with the specific object with those methods.
 You also could use operation as simple execution and check status by `success?` or `fail?` method
 and then by using `subject` and `errors` method build your own logic to finish your result.
-There is many possible usecases where and how you could use operations.
-You can build csacade of opreations, use them one after the other,
+There are many possible use-cases where and how you could use operations.
+You can build cascade of operations, use them one after the other,
 use them recursively and a lot more.
 
 
@@ -132,7 +132,7 @@ MyOperation.new.on_success { |operation| render :done, locals: { model: operatio
 MyOperation.new.on(success: -> () { |operation| render :done, locals: { model: operation.subject } )
 ```
 
-When you bind operation with other object you could delegate actions to binded object methods
+When you bind operation with another object you could delegate actions to bound object methods
 
 ```ruby
 # 1
@@ -207,13 +207,12 @@ Operation
 
 ```ruby
 class ArticleVoteBumperOperation < LightOperations::Core
-  rescue_from ActiveRecord::ActiveRecordError, with: :on_ar_error
+  rescue_from ActiveRecord::RecordInvalid, with: :on_ar_error
 
   def execute(_params = nil)
-    dependency(:article_model).tap do |article|
-      article.vote = article.vote.next
-      article.save
-    end
+    article = dependency(:article_model)
+    article.vote = article.vote.next
+    article.save!
     { success: true }
   end
 
@@ -228,23 +227,19 @@ Controller
 ```ruby
 class ArticleVotesController < ApplicationController
   def up
+    operation = ArticleVoteBumperOperation.new(article_model: article)
     response = operation.run.success? ? response.subject : response.errors
     render :up, json: response
   end
 
   private
-
-  def operation
-    @operation ||= ArticleVoteBumperOperation.new(article_model: article)
-  end
-
   def article
     Article.find(params.require(:id))
   end
 end
 ```
 
-#### Basic recursive execution to collect newsfeeds from 2 sources
+#### Basic recursive execution to collect news feeds from 2 sources
 
 Operation
 
@@ -486,7 +481,7 @@ class AuthController < ApplicationController
 end
 ```
 
-Register success and fails action is avialable by `#on` like :
+Register success and fails action is available by `#on` like:
 
 ```ruby
   def create
@@ -500,16 +495,16 @@ Operation have some helper methods (to improve recursive execution)
 - `#unbind!`                    => unbind binded object
 - `#clear_subject_with_errors!` => clear subject and errors
 
-When operation status is most importent we can simply use `#success?` or `#fail?` on the executed operation
+When operation status is most important we can simply use `#success?` or `#fail?` on the executed operation
 
 Errors are available by `#errors` after operation is executed
 
 ### Whats new in 1.2.x
-New module LightOperations::Flow which gives very simple and easy way to create operation per action in controller (tested on rails).
+New module LightOperations::Flow which gives very simple and easy way to create operation per action in the controller (tested on rails).
 
 #### How it works:
 
-include module in controller like this
+include the module in a controller like this
 ```ruby
 class AccountsController < VersionController
   include LightOperations::Flow
@@ -560,7 +555,7 @@ But it is not all :D (operation params gives you a lot more)
 class AccountsController < VersionController
   include LightOperations::Flow
   operation(
-    :accounts, # top level namespace
+    :accounts, # top-level namespace
     namespace: Operations, # Base namespace by default is Kernel
     actions: [:create, :show], # those are operations executed by router
     default_view: nil, # By changing this option you can have one method for render all successful operations for all actions.
@@ -570,7 +565,7 @@ class AccountsController < VersionController
 end
 ```
 
-This simple module should give you power to create something like this:
+This simple module should give you the power to create something like this:
 
 ```ruby
 module Api

data/lib/light_operations/core.rb

@@ -8,7 +8,7 @@ module LightOperations
     attr_reader :subject
 
     def self.subject_name(method_name)
-      send(:define_method, method_name, proc { self.subject })
+      send(:define_method, method_name, proc { subject })
     end
 
     def initialize(dependencies = {})
@@ -18,7 +18,7 @@ module LightOperations
     # do no.t override this method
     def run(params = {})
       clear_subject_with_errors!
-      @subject = execute(params)
+      @subject = method(:execute).arity == 0 ? execute : execute(params)
       execute_actions
       self
     rescue => exception
@@ -55,7 +55,9 @@ module LightOperations
     end
 
     def clear_subject_with_errors!
-      @subject, @fail_errors, @errors = nil, nil, nil
+      @subject = nil
+      @fail_errors = nil
+      @errors = nil
       self
     end
 

data/lib/light_operations/flow.rb

@@ -7,7 +7,7 @@ module LightOperations
     attr_reader :operation_opts, :operation_dependencies
 
     module ClassMethods
-      def operation(operation_name, namespace: Kernel, actions: [], default_view: nil, view_prefix: 'render_', default_fail_view: nil, fail_view_prefix: 'render_fail_')
+      def operation(operation_name, namespace: Kernel, actions: [], default_view: nil, view_prefix: 'render_', default_fail_view: nil, fail_view_prefix: 'render_fail_') # rubocop:disable all
         actions.each do |action_name|
           operation_method = "#{action_name}_op"
 

data/lib/light_operations/version.rb

@@ -1,3 +1,3 @@
 module LightOperations
-  VERSION = '1.2.3'
+  VERSION = '1.2.5'.freeze
 end

data/light_operations.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/pniemczyk/light_operations'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']

data/spec/lib/core_spec.rb

@@ -50,7 +50,7 @@ describe LightOperations::Core do
         end
       end
 
-      before { subject.on(success: lambda { |_subject| }) }
+      before { subject.on(success: ->(_subject) {}) }
 
       it 'is allowed when is initialized correctly' do
         expect { subject.run }.not_to raise_error
@@ -69,7 +69,7 @@ describe LightOperations::Core do
     context '.rescue_from specific error' do
       TestError = Class.new(StandardError)
 
-      before { subject.on(success: lambda { |_subject| }) }
+      before { subject.on(success: ->(_subject) {}) }
 
       context 'by block' do
         subject do
@@ -139,7 +139,7 @@ describe LightOperations::Core do
         end
 
         it 'when block is used' do
-          block_to_exec = lambda {}
+          block_to_exec = -> {}
           expect(block_to_exec).not_to receive(:call)
           subject.on_fail(&block_to_exec).run
         end
@@ -175,7 +175,7 @@ describe LightOperations::Core do
         end
 
         it 'when block is used' do
-          block_to_exec = lambda {}
+          block_to_exec = -> {}
           expect(block_to_exec).not_to receive(:call)
           subject.on_success(&block_to_exec).run
         end
@@ -226,7 +226,7 @@ describe LightOperations::Core do
     end
 
     it '#clear_subject_with_errors!' do
-      %w{ subject fail_errors errors }.each do |variable|
+      %w{subject fail_errors errors}.each do |variable|
         subject.instance_variable_set("@#{variable}", variable)
       end
       expect(subject.subject).to eq('subject')
@@ -288,4 +288,21 @@ describe LightOperations::Core do
       subject.run(result: :success)
     end
   end
+
+  context 'Operation execution without params' do
+    subject do
+      subject_factory do
+        def execute
+          'hello world!'
+        end
+      end
+    end
+
+    it 'is allowed' do
+      subject
+        .bind_with(binding_object)
+        .on(success: :success_action, fail: :error_action)
+      expect(subject.run.success?).to eq(true)
+    end
+  end
 end

data/spec/lib/flow_spec.rb

@@ -5,8 +5,6 @@ require 'rspec/rails'
 # prevent Test::Unit's AutoRunner from executing during RSpec's rake task
 Test::Unit.run = true if defined?(Test::Unit) && Test::Unit.respond_to?(:run=)
 
-
-
 describe 'LightOperations::Flow', type: :controller do
   RailsApp = Class.new(Rails::Application)
   RailsApp.config.secret_key_base = '5308dcbbb7dea1b44e3d1d55ea7656f9'
@@ -67,7 +65,6 @@ describe 'LightOperations::Flow', type: :controller do
       end
     end
 
-
     it '#render_create as success' do
       post :create, correct: true
       expect(response.body).to eq('Create OK')
@@ -94,7 +91,6 @@ describe 'LightOperations::Flow', type: :controller do
       end
     end
 
-
     it '#view_create as success' do
       post :create, correct: true
       expect(response.body).to eq('Create OK')
@@ -118,7 +114,6 @@ describe 'LightOperations::Flow', type: :controller do
       end
     end
 
-
     it '#render_create as success' do
       post :create, correct: true
       expect(response.body).to eq('Create OK')
@@ -147,7 +142,6 @@ describe 'LightOperations::Flow', type: :controller do
       end
     end
 
-
     it '#render_view as success' do
       post :create, correct: true
       expect(response.body).to eq('Create OK')
@@ -186,7 +180,6 @@ describe 'LightOperations::Flow', type: :controller do
       end
     end
 
-
     it '#render_view as success' do
       post :update, correct: true, id: 1
       expect(response.body).to eq('Update OK')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: light_operations
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.5
 platform: ruby
 authors:
 - Pawel Niemczyk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2017-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -208,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Light operations